fix(extension): content appearing multiple times, fix #66

Author: softvar

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## **v4.0.1** - 17th July, 2020
+
+  - Fix #66 i.e. content appearing multiple times
+
 ## **v4.0.0** - 26th June, 2020
 
   - Support new GitHub Design. Refer [GitHub Blog](https://github.blog/changelog/2020-06-23-design-updates-to-repositories-and-github-ui/)

src/utils/domUtil.js

@@ -29,7 +29,7 @@ let domUtil = {
     return elemClass.split(' ').indexOf(className) > -1;
   },
   appendRepoSizeElement: function() {
-    commonUtil.removePrevInstancesOf('.repo-size');
+    commonUtil.removePrevInstancesOf('.eg-repo-size');
 
     let formattedFileSize = commonUtil.convertSizeToHumanReadableFormat(storageUtil.get('repoSize') * 1024); // GitHub API return size in KB for repo
 
@@ -39,7 +39,7 @@ let domUtil = {
 
       if (elem) {
         let html = `
-          <div class="mt-3">
+          <div class="mt-3 eg-repo-size">
             <a href="javascript:void(0)" class="muted-link">
               <svg class="octicon octicon-database mr-2" mr="2" aria-hidden="true" height="16" version="1.1" viewBox="0 0 12 16" width="16">
                 <path d="M6 15c-3.31 0-6-.9-6-2v-2c0-.17.09-.34.21-.5.67.86 3 1.5 5.79 1.5s5.12-.64 5.79-1.5c.13.16.21.33.21.5v2c0 1.1-2.69 2-6 2zm0-4c-3.31 0-6-.9-6-2V7c0-.11.04-.21.09-.31.03-.06.07-.13.12-.19C.88 7.36 3.21 8 6 8s5.12-.64 5.79-1.5c.05.06.09.13.12.19.05.1.09.21.09.31v2c0 1.1-2.69 2-6 2zm0-4c-3.31 0-6-.9-6-2V3c0-1.1 2.69-2 6-2s6 .9 6 2v2c0 1.1-2.69 2-6 2zm0-5c-2.21 0-4 .45-4 1s1.79 1 4 1 4-.45 4-1-1.79-1-4-1z"></path>
@@ -55,6 +55,7 @@ let domUtil = {
 
       return;
     }
+    commonUtil.removePrevInstancesOf('.repo-size');
     let elem = document.querySelector('ul.numbers-summary');
 
     if (elem) {

src/utils/handlersUtil.js

@@ -45,6 +45,8 @@ let handlersUtil = {
 
     if (commonUtil.isForGithUbNewUi()) {
       setTimeout(function() {
+        commonUtil.removePrevInstancesOf('.eg-download'); // remove before adding new ones
+
         const containerItems = document.querySelectorAll(
           '.js-navigation-container.js-active-navigation-container .js-navigation-item'
         );
@@ -62,7 +64,7 @@ let handlersUtil = {
               let formattedFileSize = commonUtil.getFileSizeAndUnit(data[actualDataIndex]);
 
               let html = `
-                <div role="gridcell" class="mr-1 text-gray-light" style="width: 95px;">
+                <div role="gridcell" class="mr-1 text-gray-light eg-download" style="width: 95px;">
                   <span class="css-truncate css-truncate-target d-block">
                     <span style="margin-right: 5px;">
                       ${formattedFileSize}
@@ -80,7 +82,7 @@ let handlersUtil = {
               commitElem.insertAdjacentHTML('afterend', html);
             } else {
               const defaultHtml = `
-                <div role="gridcell" class="mr-1" style="width: 90px;"></div>
+                <div role="gridcell" class="mr-1 eg-download" style="width: 90px;"></div>
               `;
 
               commitElem.insertAdjacentHTML('afterend', defaultHtml);