feat: bridge audio param to graph

Author: poneciak57

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioNodeHostObject.cpp

@@ -66,8 +66,8 @@ JSI_HOST_FUNCTION_IMPL(AudioNodeHostObject, connect) {
     connect(*node);
   } else if (obj.isHostObject<AudioParamHostObject>(runtime)) {
     auto param = obj.getHostObject<AudioParamHostObject>(runtime);
-    auto owner = args[1].getObject(runtime).getHostObject<AudioNodeHostObject>(runtime);
-    connectParam(*owner, param->param_.get());
+    // Connect source → bridge (the bridge → owner edge is created at param construction)
+    graph_->addEdge(node_, param->bridgeNode());
   }
   return jsi::Value::undefined();
 }
@@ -84,8 +84,8 @@ JSI_HOST_FUNCTION_IMPL(AudioNodeHostObject, disconnect) {
     disconnect(*node);
   } else if (obj.isHostObject<AudioParamHostObject>(runtime)) {
     auto param = obj.getHostObject<AudioParamHostObject>(runtime);
-    auto owner = args[1].getObject(runtime).getHostObject<AudioNodeHostObject>(runtime);
-    disconnectParam(*owner, param->param_.get());
+    // Disconnect source → bridge
+    graph_->removeEdge(node_, param->bridgeNode());
   }
 
   return jsi::Value::undefined();

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioParamHostObject.cpp

@@ -1,18 +1,30 @@
 #include <audioapi/HostObjects/AudioParamHostObject.h>
 
 #include <audioapi/core/AudioParam.h>
+#include <audioapi/core/utils/graph/BridgeNode.hpp>
 #include <audioapi/utils/AudioArray.hpp>
 
 #include <memory>
 #include <utility>
 
 namespace audioapi {
 
-AudioParamHostObject::AudioParamHostObject(const std::shared_ptr<AudioParam> &param)
-    : param_(param),
+AudioParamHostObject::AudioParamHostObject(
+    std::shared_ptr<utils::graph::Graph> graph,
+    HNode *ownerNode,
+    const std::shared_ptr<AudioParam> &param)
+    : graph_(std::move(graph)),
+      param_(param),
       defaultValue_(param->getDefaultValue()),
       minValue_(param->getMinValue()),
       maxValue_(param->getMaxValue()) {
+  // Create the bridge node in the graph
+  auto bridgeGraphObject = std::make_unique<utils::graph::BridgeNode>(param.get());
+  bridgeNode_ = graph_->addNode(std::move(bridgeGraphObject));
+
+  // Connect bridge → owner so topological sort orders correctly
+  (void)graph_->addEdge(bridgeNode_, ownerNode);
+
   addGetters(
       JSI_EXPORT_PROPERTY_GETTER(AudioParamHostObject, value),
       JSI_EXPORT_PROPERTY_GETTER(AudioParamHostObject, defaultValue),
@@ -31,6 +43,16 @@ AudioParamHostObject::AudioParamHostObject(const std::shared_ptr<AudioParam> &pa
   addSetters(JSI_EXPORT_PROPERTY_SETTER(AudioParamHostObject, value));
 }
 
+AudioParamHostObject::~AudioParamHostObject() {
+  if (graph_ && bridgeNode_) {
+    // Remove outgoing edges (bridge → owner)
+    (void)graph_->removeAllEdges(bridgeNode_);
+    // Remove the bridge node itself
+    (void)graph_->removeNode(bridgeNode_);
+    bridgeNode_ = nullptr;
+  }
+}
+
 JSI_PROPERTY_GETTER_IMPL(AudioParamHostObject, value) {
   return {param_->getValue()};
 }

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioParamHostObject.h

@@ -1,5 +1,6 @@
 #pragma once
 
+#include <audioapi/core/utils/graph/HostNode.hpp>
 #include <audioapi/jsi/JsiHostObject.h>
 
 #include <jsi/jsi.h>
@@ -11,9 +12,27 @@ using namespace facebook;
 
 class AudioParam;
 
+/// @brief Host object for AudioParam that owns its BridgeNode.
+///
+/// When created, a BridgeNode is added to the graph and connected to the
+/// owner node (bridge → owner). Sources connecting to this param connect
+/// to the bridge node (source → bridge).
+///
+/// When destroyed, the BridgeNode is removed from the graph.
 class AudioParamHostObject : public JsiHostObject {
  public:
-  explicit AudioParamHostObject(const std::shared_ptr<AudioParam> &param);
+  using HNode = utils::graph::HostGraph::Node;
+
+  /// @brief Creates an AudioParamHostObject with its BridgeNode.
+  /// @param graph The audio graph
+  /// @param ownerNode The HNode* of the AudioNode that owns this param
+  /// @param param The AudioParam this host object represents
+  explicit AudioParamHostObject(
+      std::shared_ptr<utils::graph::Graph> graph,
+      HNode *ownerNode,
+      const std::shared_ptr<AudioParam> &param);
+
+  ~AudioParamHostObject() override;
 
   JSI_PROPERTY_GETTER_DECL(value);
   JSI_PROPERTY_GETTER_DECL(defaultValue);
@@ -30,9 +49,16 @@ class AudioParamHostObject : public JsiHostObject {
   JSI_HOST_FUNCTION_DECL(cancelScheduledValues);
   JSI_HOST_FUNCTION_DECL(cancelAndHoldAtTime);
 
+  /// @brief Returns the bridge node for this param (for source → bridge connections).
+  [[nodiscard]] HNode *bridgeNode() const {
+    return bridgeNode_;
+  }
+
  private:
   friend class AudioNodeHostObject;
 
+  std::shared_ptr<utils::graph::Graph> graph_;
+  HNode *bridgeNode_ = nullptr;
   std::shared_ptr<AudioParam> param_;
   float defaultValue_;
   float minValue_;

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/BiquadFilterNodeHostObject.cpp

@@ -20,10 +20,13 @@ BiquadFilterNodeHostObject::BiquadFilterNodeHostObject(
           options),
       type_(options.type) {
   auto biquadFilterNode = static_cast<BiquadFilterNode *>(node_->handle->audioNode->asAudioNode());
-  frequencyParam_ = std::make_shared<AudioParamHostObject>(biquadFilterNode->getFrequencyParam());
-  detuneParam_ = std::make_shared<AudioParamHostObject>(biquadFilterNode->getDetuneParam());
-  QParam_ = std::make_shared<AudioParamHostObject>(biquadFilterNode->getQParam());
-  gainParam_ = std::make_shared<AudioParamHostObject>(biquadFilterNode->getGainParam());
+  frequencyParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, biquadFilterNode->getFrequencyParam());
+  detuneParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, biquadFilterNode->getDetuneParam());
+  QParam_ = std::make_shared<AudioParamHostObject>(graph_, node_, biquadFilterNode->getQParam());
+  gainParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, biquadFilterNode->getGainParam());
 
   addGetters(
       JSI_EXPORT_PROPERTY_GETTER(BiquadFilterNodeHostObject, frequency),

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/DelayNodeHostObject.cpp

@@ -16,7 +16,8 @@ DelayNodeHostObject::DelayNodeHostObject(
           std::make_unique<DelayNode>(context, options),
           options) {
   auto delayNode = static_cast<DelayNode *>(node_->handle->audioNode->asAudioNode());
-  delayTimeParam_ = std::make_shared<AudioParamHostObject>(delayNode->getDelayTimeParam());
+  delayTimeParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, delayNode->getDelayTimeParam());
   addGetters(JSI_EXPORT_PROPERTY_GETTER(DelayNodeHostObject, delayTime));
 }
 

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/GainNodeHostObject.cpp

@@ -16,7 +16,7 @@ GainNodeHostObject::GainNodeHostObject(
           std::make_unique<GainNode>(context, options),
           options) {
   auto gainNode = static_cast<GainNode *>(node_->handle->audioNode->asAudioNode());
-  gainParam_ = std::make_shared<AudioParamHostObject>(gainNode->getGainParam());
+  gainParam_ = std::make_shared<AudioParamHostObject>(graph_, node_, gainNode->getGainParam());
 
   addGetters(JSI_EXPORT_PROPERTY_GETTER(GainNodeHostObject, gain));
 }

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/StereoPannerNodeHostObject.cpp

@@ -16,7 +16,8 @@ StereoPannerNodeHostObject::StereoPannerNodeHostObject(
           std::make_unique<StereoPannerNode>(context, options),
           options) {
   auto stereoPannerNode = static_cast<StereoPannerNode *>(node_->handle->audioNode->asAudioNode());
-  panParam_ = std::make_shared<AudioParamHostObject>(stereoPannerNode->getPanParam());
+  panParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, stereoPannerNode->getPanParam());
 
   addGetters(JSI_EXPORT_PROPERTY_GETTER(StereoPannerNodeHostObject, pan));
 }

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferBaseSourceNodeHostObject.cpp

@@ -19,8 +19,10 @@ AudioBufferBaseSourceNodeHostObject::AudioBufferBaseSourceNodeHostObject(
       pitchCorrection_(options.pitchCorrection) {
   auto sourceNode =
       static_cast<AudioBufferBaseSourceNode *>(node_->handle->audioNode->asAudioNode());
-  detuneParam_ = std::make_shared<AudioParamHostObject>(sourceNode->getDetuneParam());
-  playbackRateParam_ = std::make_shared<AudioParamHostObject>(sourceNode->getPlaybackRateParam());
+  detuneParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, sourceNode->getDetuneParam());
+  playbackRateParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, sourceNode->getPlaybackRateParam());
 
   addGetters(
       JSI_EXPORT_PROPERTY_GETTER(AudioBufferBaseSourceNodeHostObject, detune),

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/ConstantSourceNodeHostObject.cpp

@@ -16,7 +16,8 @@ ConstantSourceNodeHostObject::ConstantSourceNodeHostObject(
           options) {
   auto constantSourceNode =
       static_cast<ConstantSourceNode *>(node_->handle->audioNode->asAudioNode());
-  offsetParam_ = std::make_shared<AudioParamHostObject>(constantSourceNode->getOffsetParam());
+  offsetParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, constantSourceNode->getOffsetParam());
 
   addGetters(JSI_EXPORT_PROPERTY_GETTER(ConstantSourceNodeHostObject, offset));
 }

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/OscillatorNodeHostObject.cpp

@@ -20,8 +20,10 @@ OscillatorNodeHostObject::OscillatorNodeHostObject(
           options),
       type_(options.type) {
   auto oscillatorNode = static_cast<OscillatorNode *>(node_->handle->audioNode->asAudioNode());
-  frequencyParam_ = std::make_shared<AudioParamHostObject>(oscillatorNode->getFrequencyParam());
-  detuneParam_ = std::make_shared<AudioParamHostObject>(oscillatorNode->getDetuneParam());
+  frequencyParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, oscillatorNode->getFrequencyParam());
+  detuneParam_ =
+      std::make_shared<AudioParamHostObject>(graph_, node_, oscillatorNode->getDetuneParam());
 
   addGetters(
       JSI_EXPORT_PROPERTY_GETTER(OscillatorNodeHostObject, frequency),