feat: moved disposer out of graph class

Author: poneciak57

packages/react-native-audio-api/common/cpp/audioapi/core/utils/graph/Graph.hpp

@@ -55,10 +55,11 @@ class Graph {
   using HNode = HostGraph::Node;
 
  public:
+  static constexpr size_t kDisposerPayloadSize = HostGraph::kDisposerPayloadSize;
   using ResultError = HostGraph::ResultError;
   using Res = Result<NoneType, ResultError>;
 
-  explicit Graph(size_t eventQueueCapacity) {
+  Graph(size_t eventQueueCapacity, Disposer<kDisposerPayloadSize> *disposer) : disposer_(disposer) {
     using namespace audioapi::channels::spsc;
 
     auto [es, er] = channel<AGEvent, OverflowStrategy::WAIT_ON_FULL, WaitStrategy::BUSY_LOOP>(
@@ -69,9 +70,10 @@ class Graph {
 
   Graph(
       size_t eventQueueCapacity,
+      Disposer<kDisposerPayloadSize> *disposer,
       std::uint32_t initialNodeCapacity,
       std::uint32_t initialEdgeCapacity)
-      : Graph(eventQueueCapacity) {
+      : Graph(eventQueueCapacity, disposer) {
     if (initialNodeCapacity > 0) {
       audioGraph.reserveNodes(initialNodeCapacity);
       nodeCapacity_ = initialNodeCapacity;
@@ -97,7 +99,7 @@ class Graph {
     AGEvent event;
     while (eventReceiver_.try_receive(event) == audioapi::channels::spsc::ResponseStatus::SUCCESS) {
       if (event) {
-        event(audioGraph, disposer_);
+        event(audioGraph, *disposer_);
       }
     }
   }
@@ -281,8 +283,6 @@ class Graph {
   }
 
  private:
-  static constexpr size_t kDisposerPayloadSize = HostGraph::kDisposerPayloadSize;
-
   using OwnedSlotBuffer = std::unique_ptr<InputPool::Slot[]>;
 
   // Aligning to cache line size to prevent false sharing between audio and main thread
@@ -296,7 +296,7 @@ class Graph {
 
   // ── Disposer — destroys old pool buffers off the audio thread ───────────
 
-  DisposerImpl<kDisposerPayloadSize> disposer_{64};
+  Disposer<kDisposerPayloadSize> *disposer_;
 
   // ── Main-thread tracking for pre-growth ─────────────────────────────────
 

packages/react-native-audio-api/common/cpp/test/src/graph/BridgeNodeTest.cpp

@@ -320,10 +320,12 @@ TEST_F(BridgeGraphTest, BridgeOrphanedAndNoInputsGetsCompacted) {
 
 class BridgeGraphWrapperTest : public ::testing::Test {
  protected:
+  static constexpr size_t kPayloadSize = HostGraph::kDisposerPayloadSize;
+  DisposerImpl<kPayloadSize> disposer_{64};
   std::shared_ptr<Graph> graph;
 
   void SetUp() override {
-    graph = std::make_shared<Graph>(4096);
+    graph = std::make_shared<Graph>(4096, &disposer_);
   }
 
   void processAll() {
@@ -465,7 +467,7 @@ TEST_F(BridgeGraphWrapperTest, ConcurrentWithMockGraphProcessor) {
   using Processor = audioapi::test::MockGraphProcessor<ProcessableMockNode>;
   // Pre-allocate node/pool capacity to avoid grow-event allocations inside
   // the AudioThreadGuard scope.
-  auto sharedGraph = std::make_shared<Graph>(4096, 16, 64);
+  auto sharedGraph = std::make_shared<Graph>(4096, &disposer_, 16, 64);
   Processor processor(*sharedGraph);
   processor.start();
 
@@ -497,14 +499,16 @@ TEST_F(BridgeGraphWrapperTest, ConcurrentWithMockGraphProcessor) {
 class BridgeFuzzTest : public ::testing::TestWithParam<uint64_t> {
  protected:
   using HNode = HostGraph::Node;
+  static constexpr size_t kPayloadSize = HostGraph::kDisposerPayloadSize;
 
+  DisposerImpl<kPayloadSize> disposer_{64};
   std::shared_ptr<Graph> graph;
   std::mt19937_64 rng;
   std::vector<HNode *> liveNodes;
   std::vector<AudioParam *> fakeParams;
 
   void SetUp() override {
-    graph = std::make_shared<Graph>(4096);
+    graph = std::make_shared<Graph>(4096, &disposer_);
     rng.seed(GetParam());
 
     // Create a set of fake param pointers

packages/react-native-audio-api/common/cpp/test/src/graph/GraphFuzzTest.cpp

@@ -15,6 +15,7 @@
 
 using namespace audioapi::utils::graph;
 using audioapi::test::MockGraphProcessor;
+using audioapi::utils::DisposerImpl;
 
 // =========================================================================
 // Fixture — parameterized by seed for reproducible randomized testing
@@ -27,6 +28,8 @@ class GraphFuzzTest : public ::testing::TestWithParam<uint64_t> {
   using Res = Graph::Res;
   using ResultError = Graph::ResultError;
 
+  static constexpr size_t kPayloadSize = HostGraph::kDisposerPayloadSize;
+  DisposerImpl<kPayloadSize> disposer_{64};
   std::mt19937_64 rng;
   std::unique_ptr<Graph> graph;
   std::vector<HNode *> nodes; // tracks live (non-removed) nodes
@@ -49,7 +52,7 @@ class GraphFuzzTest : public ::testing::TestWithParam<uint64_t> {
     // Ensure graph growth does not happen on the audio thread during this fuzz run.
     const auto maxNodes = static_cast<std::uint32_t>(initialNodeCount + operationCount + 64);
     const auto maxEdges = static_cast<std::uint32_t>(operationCount * 2 + 64);
-    graph = std::make_unique<Graph>(4096, maxNodes, maxEdges);
+    graph = std::make_unique<Graph>(4096, &disposer_, maxNodes, maxEdges);
 
     // Randomly partition the range 0..99 into 4 operation weights
     size_t total = 100;

packages/react-native-audio-api/common/cpp/test/src/graph/GraphTest.cpp

@@ -13,10 +13,12 @@ namespace audioapi::utils::graph {
 
 class GraphTest : public ::testing::Test {
  protected:
+  static constexpr size_t kPayloadSize = HostGraph::kDisposerPayloadSize;
+  DisposerImpl<kPayloadSize> disposer_{64};
   std::unique_ptr<Graph> graph;
 
   void SetUp() override {
-    graph = std::make_unique<Graph>(4096);
+    graph = std::make_unique<Graph>(4096, &disposer_);
   }
 
   const AudioGraph &getAudioGraph() {