chore: init setup for clang tidy (#982)

Author: mdydek

packages/react-native-audio-api/.clang-tidy

@@ -0,0 +1,30 @@
+# Full clang-tidy configuration for react-native-audio-api C++.
+# See: https://clang.llvm.org/extra/clang-tidy/checks/list.html
+# Tweak checks in .clangd (Diagnostics.ClangTidy.Remove) to disable noisy ones.
+
+Checks: '-*,
+        bugprone-*,
+        -bugprone-easily-swappable-parameters,
+        modernize-*,
+        -modernize-use-trailing-return-type,
+        performance-*,
+        readability-*,
+        -readability-uppercase-literal-suffix,
+        -readability-math-missing-parentheses,
+        -readability-isolate-declaration,
+        -readability-identifier-length,
+        cppcoreguidelines-*,
+        -cppcoreguidelines-non-private-member-variables-in-classes,
+        -cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,
+        -cppcoreguidelines-pro-bounds-pointer-arithmetic,
+        -cppcoreguidelines-pro-type-union-access,
+        -cppcoreguidelines-pro-type-reinterpret-cast,
+        -cppcoreguidelines-avoid-do-while,
+        -cppcoreguidelines-pro-bounds-constant-array-index,
+        -cppcoreguidelines-init-variables,
+        -cppcoreguidelines-pro-type-vararg,
+        concurrency-*'
+
+HeaderFilterRegex: '.*/(audioapi|common/cpp|src/main/cpp)/.*'
+
+FormatStyle: file

packages/react-native-audio-api/.clangd

@@ -0,0 +1,10 @@
+Documentation:
+  CommentFormat: Doxygen
+
+CompileFlags:
+  Add:
+    - -std=c++20
+
+Diagnostics:
+  ClangTidy:
+    FastCheckFilter: Loose

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp

@@ -49,7 +49,7 @@ AndroidAudioRecorder::~AndroidAudioRecorder() {
 
     if (isConnected()) {
       isConnected_.store(false, std::memory_order_release);
-      adapterNode_->cleanup();
+      adapterNode_->adapterCleanup();
     }
   }
 
@@ -198,7 +198,7 @@ Result<std::tuple<std::string, double, double>, std::string> AndroidAudioRecorde
   }
 
   if (isConnected()) {
-    adapterNode_->cleanup();
+    adapterNode_->adapterCleanup();
   }
 
   filePath_ = "";

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioParamHostObject.cpp

@@ -103,7 +103,7 @@ JSI_HOST_FUNCTION_IMPL(AudioParamHostObject, setTargetAtTime) {
 JSI_HOST_FUNCTION_IMPL(AudioParamHostObject, setValueCurveAtTime) {
   auto arrayBuffer =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
-  auto rawValues = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+  auto *rawValues = reinterpret_cast<float *>(arrayBuffer.data(runtime));
   auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));
   auto values = std::make_shared<AudioArray>(rawValues, length);
 

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp

@@ -262,19 +262,19 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createBufferQueueSource) {
 JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createPeriodicWave) {
   auto arrayBufferReal =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
-  auto real = reinterpret_cast<float *>(arrayBufferReal.data(runtime));
+  auto *real = reinterpret_cast<float *>(arrayBufferReal.data(runtime));
   auto length = static_cast<int>(arrayBufferReal.size(runtime) / sizeof(float));
 
   auto arrayBufferImag =
       args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
-  auto imag = reinterpret_cast<float *>(arrayBufferImag.data(runtime));
+  auto *imag = reinterpret_cast<float *>(arrayBufferImag.data(runtime));
 
   auto disableNormalization = args[2].getBool();
 
   auto complexData = std::vector<std::complex<float>>(length);
 
-  for (size_t i = 0; i < length; i++) {
-    complexData[i] = std::complex<float>(static_cast<float>(real[i]), static_cast<float>(imag[i]));
+  for (int i = 0; i < length; i++) {
+    complexData[i] = std::complex<float>(real[i], imag[i]);
   }
 
   auto periodicWave = context_->createPeriodicWave(complexData, disableNormalization, length);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/ConvolverNodeHostObject.cpp

@@ -67,17 +67,17 @@ void ConvolverNodeHostObject::setBuffer(const std::shared_ptr<AudioBuffer> &buff
   }
 
   auto threadPool = std::make_shared<ThreadPool>(4);
-  std::vector<Convolver> convolvers;
+  std::vector<std::unique_ptr<Convolver>> convolvers;
   for (size_t i = 0; i < copiedBuffer->getNumberOfChannels(); ++i) {
     AudioArray channelData(*copiedBuffer->getChannel(i));
-    convolvers.emplace_back();
-    convolvers.back().init(RENDER_QUANTUM_SIZE, channelData, copiedBuffer->getSize());
+    convolvers.push_back(std::make_unique<Convolver>());
+    convolvers.back()->init(RENDER_QUANTUM_SIZE, channelData, copiedBuffer->getSize());
   }
   if (copiedBuffer->getNumberOfChannels() == 1) {
     // add one more convolver, because right now input is always stereo
     AudioArray channelData(*copiedBuffer->getChannel(0));
-    convolvers.emplace_back();
-    convolvers.back().init(RENDER_QUANTUM_SIZE, channelData, copiedBuffer->getSize());
+    convolvers.push_back(std::make_unique<Convolver>());
+    convolvers.back()->init(RENDER_QUANTUM_SIZE, channelData, copiedBuffer->getSize());
   }
 
   auto internalBuffer = std::make_shared<DSPAudioBuffer>(
@@ -87,20 +87,20 @@ void ConvolverNodeHostObject::setBuffer(const std::shared_ptr<AudioBuffer> &buff
 
   struct SetupData {
     std::shared_ptr<AudioBuffer> buffer;
-    std::vector<Convolver> convolvers;
+    std::vector<std::unique_ptr<Convolver>> convolvers;
     std::shared_ptr<ThreadPool> threadPool;
     std::shared_ptr<DSPAudioBuffer> internalBuffer;
     std::shared_ptr<DSPAudioBuffer> intermediateBuffer;
     float scaleFactor;
   };
 
   auto setupData = std::make_shared<SetupData>(SetupData{
-      copiedBuffer,
-      std::move(convolvers),
-      threadPool,
-      internalBuffer,
-      intermediateBuffer,
-      scaleFactor});
+      .buffer = copiedBuffer,
+      .convolvers = std::move(convolvers),
+      .threadPool = threadPool,
+      .internalBuffer = internalBuffer,
+      .intermediateBuffer = intermediateBuffer,
+      .scaleFactor = scaleFactor});
 
   auto event = [convolverNode, setupData](BaseAudioContext &) {
     convolverNode->setBuffer(

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/events/AudioEventHandlerRegistryHostObject.cpp

@@ -7,9 +7,8 @@
 namespace audioapi {
 
 AudioEventHandlerRegistryHostObject::AudioEventHandlerRegistryHostObject(
-    const std::shared_ptr<AudioEventHandlerRegistry> &eventHandlerRegistry) {
-  eventHandlerRegistry_ = eventHandlerRegistry;
-
+    const std::shared_ptr<AudioEventHandlerRegistry> &eventHandlerRegistry)
+    : eventHandlerRegistry_(eventHandlerRegistry) {
   addFunctions(
       JSI_EXPORT_FUNCTION(AudioEventHandlerRegistryHostObject, addAudioEventListener),
       JSI_EXPORT_FUNCTION(AudioEventHandlerRegistryHostObject, removeAudioEventListener));

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferHostObject.cpp

@@ -56,7 +56,7 @@ JSI_HOST_FUNCTION_IMPL(AudioBufferHostObject, getChannelData) {
 JSI_HOST_FUNCTION_IMPL(AudioBufferHostObject, copyFromChannel) {
   auto arrayBuffer =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
-  auto destination = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+  auto *destination = reinterpret_cast<float *>(arrayBuffer.data(runtime));
   auto length = arrayBuffer.size(runtime) / sizeof(float);
   auto channelNumber = static_cast<int>(args[1].getNumber());
   auto startInChannel = static_cast<size_t>(args[2].getNumber());
@@ -69,7 +69,7 @@ JSI_HOST_FUNCTION_IMPL(AudioBufferHostObject, copyFromChannel) {
 JSI_HOST_FUNCTION_IMPL(AudioBufferHostObject, copyToChannel) {
   auto arrayBuffer =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
-  auto source = reinterpret_cast<float *>(arrayBuffer.data(runtime));
+  auto *source = reinterpret_cast<float *>(arrayBuffer.data(runtime));
   auto length = arrayBuffer.size(runtime) / sizeof(float);
   auto channelNumber = static_cast<int>(args[1].getNumber());
   auto startInChannel = static_cast<size_t>(args[2].getNumber());

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferHostObject.h

@@ -27,7 +27,9 @@ class AudioBufferHostObject : public JsiHostObject {
     return *this;
   }
 
-  [[nodiscard]] inline size_t getSizeInBytes() const {
+  ~AudioBufferHostObject() override = default;
+
+  [[nodiscard]] size_t getSizeInBytes() const {
     // *2 because every time buffer is passed we create a copy of it.
     return audioBuffer_->getSize() * audioBuffer_->getNumberOfChannels() * sizeof(float) * 2;
   }

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/sources/AudioBufferQueueSourceNodeHostObject.cpp

@@ -74,8 +74,9 @@ JSI_HOST_FUNCTION_IMPL(AudioBufferQueueSourceNodeHostObject, enqueueBuffer) {
   std::shared_ptr<AudioBuffer> tailBuffer = nullptr;
 
   if (pitchCorrection_ && !stretchHasBeenInit_) {
-    initStretch(copiedBuffer->getNumberOfChannels(), copiedBuffer->getSampleRate());
-    int extraTailFrames =
+    initStretch(
+        static_cast<int>(copiedBuffer->getNumberOfChannels()), copiedBuffer->getSampleRate());
+    auto extraTailFrames =
         static_cast<size_t>((inputLatency_ + outputLatency_) * copiedBuffer->getSampleRate());
     tailBuffer = std::make_shared<AudioBuffer>(
         copiedBuffer->getNumberOfChannels(), extraTailFrames, copiedBuffer->getSampleRate());