Skip to content

Commit 7426b37

Browse files
refactor: implemented aligned audio array implementation (#980)
* refactor: implmented aligned audio array implementation * refactor: renamed includes from AudioArray.h to AudioArray.hpp * refactor: implemented AlignedAudioBuffer * refactor: renamed AudioBuffer.h to AudioBuffer.hpp and updated all includes accordingly * fix: nitpicks * fix: nits * fix: removed unused computeConvolution method from AudioArray and VectorMath * fix: magic number for DSP alignment * fix: magic number for DSP alignment --------- Co-authored-by: maciejmakowski2003 <maciejmakowski2003@users.noreply.github.com>
1 parent 2571df0 commit 7426b37

104 files changed

Lines changed: 866 additions & 1184 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/audiodocs/docs/guides/create-your-own-effect.mdx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ For the sake of a simplicity, we will use value as a raw `double` type, not wrap
4343
```cpp
4444
#pragma once
4545
#include <audioapi/core/AudioNode.h>
46+
#include <audioapi/utils/AudioBuffer.hpp>
4647

4748
namespace audioapi {
48-
class AudioBuffer;
4949

5050
class MyProcessorNode : public AudioNode {
5151
public:
@@ -70,8 +70,8 @@ private:
7070
7171
```cpp
7272
#include "MyProcessorNode.h"
73-
#include <audioapi/utils/AudioBuffer.h>
74-
#include <audioapi/utils/AudioArray.h>
73+
#include <audioapi/utils/AudioBuffer.hpp>
74+
#include <audioapi/utils/AudioArray.hpp>
7575

7676
namespace audioapi {
7777
MyProcessorNode::MyProcessorNode(const std::shared_ptr<BaseAudioContext> &context)

packages/custom-node-generator/templates/basic/shared/MyProcessorNode.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#include "MyProcessorNode.h"
2-
#include <audioapi/utils/AudioBuffer.h>
32

43
namespace audioapi {
54
MyProcessorNode::MyProcessorNode(

packages/custom-node-generator/templates/basic/shared/MyProcessorNode.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
#pragma once
2+
23
#include <audioapi/core/AudioNode.h>
4+
#include <audioapi/utils/AudioBuffer.hpp>
35

46
namespace audioapi {
5-
class AudioBuffer;
67

78
class MyProcessorNode : public AudioNode {
89
public:

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
#include <audioapi/core/utils/Constants.h>
1212
#include <audioapi/core/utils/Locker.h>
1313
#include <audioapi/events/AudioEventHandlerRegistry.h>
14-
#include <audioapi/utils/AudioArray.h>
15-
#include <audioapi/utils/AudioBuffer.h>
1614
#include <audioapi/utils/AudioFileProperties.h>
1715
#include <audioapi/utils/CircularAudioArray.h>
1816
#include <audioapi/utils/CircularOverflowableAudioArray.h>

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AndroidAudioRecorder.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
#include <audioapi/android/core/NativeAudioRecorder.hpp>
44
#include <audioapi/core/inputs/AudioRecorder.h>
5+
#include <audioapi/utils/AudioArray.hpp>
6+
#include <audioapi/utils/AudioBuffer.hpp>
57
#include <audioapi/utils/Result.hpp>
68
#include <oboe/Oboe.h>
79
#include <memory>
810
#include <string>
911

1012
namespace audioapi {
1113

12-
class AudioBuffer;
13-
class AudioArray;
1414
class CircularAudioArray;
1515
class AudioFileProperties;
1616
class AndroidRecorderCallback;

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioPlayer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
#include <audioapi/android/core/AudioPlayer.h>
33
#include <audioapi/core/AudioContext.h>
44
#include <audioapi/core/utils/Constants.h>
5-
#include <audioapi/utils/AudioArray.h>
6-
#include <audioapi/utils/AudioBuffer.h>
5+
#include <audioapi/utils/AudioArray.hpp>
6+
77
#include <jni.h>
88

99
#include <algorithm>

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/AudioPlayer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@
66
#include <memory>
77

88
#include <audioapi/android/core/NativeAudioPlayer.hpp>
9+
#include <audioapi/utils/AudioBuffer.hpp>
910

1011
namespace audioapi {
1112

1213
using namespace oboe;
1314

1415
class AudioContext;
15-
class AudioBuffer;
1616

1717
class AudioPlayer : public AudioStreamDataCallback, AudioStreamErrorCallback {
1818
public:

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/utils/AndroidRecorderCallback.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
#include <audioapi/android/core/utils/AndroidRecorderCallback.h>
44
#include <audioapi/events/AudioEventHandlerRegistry.h>
55
#include <audioapi/libs/miniaudio/miniaudio.h>
6-
#include <audioapi/utils/AudioArray.h>
7-
#include <audioapi/utils/AudioBuffer.h>
6+
#include <audioapi/utils/AudioArray.hpp>
7+
88
#include <audioapi/utils/CircularAudioArray.h>
99

1010
#include <algorithm>

packages/react-native-audio-api/android/src/main/cpp/audioapi/android/core/utils/AndroidRecorderCallback.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
#include <audioapi/core/utils/AudioRecorderCallback.h>
44
#include <audioapi/libs/miniaudio/miniaudio.h>
5+
#include <audioapi/utils/AudioArray.hpp>
6+
#include <audioapi/utils/AudioBuffer.hpp>
57
#include <audioapi/utils/TaskOffloader.hpp>
68
#include <memory>
79
#include <string>
810

911
namespace audioapi {
1012

11-
class AudioBuffer;
12-
class AudioArray;
1313
class CircularAudioArray;
1414
class AudioEventHandlerRegistry;
1515

packages/react-native-audio-api/common/cpp/audioapi/AudioAPIModuleInstaller.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include <audioapi/core/OfflineAudioContext.h>
1111
#include <audioapi/core/inputs/AudioRecorder.h>
1212
#include <audioapi/jsi/JsiPromise.h>
13-
#include <audioapi/utils/AudioBuffer.h>
13+
#include <audioapi/utils/AudioBuffer.hpp>
1414

1515
#include <audioapi/HostObjects/events/AudioEventHandlerRegistryHostObject.h>
1616
#include <audioapi/events/AudioEventHandlerRegistry.h>
@@ -35,7 +35,7 @@ class AudioAPIModuleInstaller {
3535
getCreateAudioRecorderFunction(jsiRuntime, audioEventHandlerRegistry);
3636
auto createOfflineAudioContext = getCreateOfflineAudioContextFunction(
3737
jsiRuntime, jsCallInvoker, audioEventHandlerRegistry, uiRuntime);
38-
auto createAudioBuffer = getCrateAudioBufferFunction(jsiRuntime);
38+
auto createAudioBuffer = getCreateAudioBufferFunction(jsiRuntime);
3939
auto createAudioDecoder = getCreateAudioDecoderFunction(jsiRuntime, jsCallInvoker);
4040
auto createAudioStretcher = getCreateAudioStretcherFunction(jsiRuntime, jsCallInvoker);
4141

@@ -185,10 +185,10 @@ class AudioAPIModuleInstaller {
185185
});
186186
}
187187

188-
static jsi::Function getCrateAudioBufferFunction(jsi::Runtime *jsiRuntime) {
188+
static jsi::Function getCreateAudioBufferFunction(jsi::Runtime *jsiRuntime) {
189189
return jsi::Function::createFromHostFunction(
190190
*jsiRuntime,
191-
jsi::PropNameID::forAscii(*jsiRuntime, "createAudioStretcher"),
191+
jsi::PropNameID::forAscii(*jsiRuntime, "createAudioBuffer"),
192192
3,
193193
[](jsi::Runtime &runtime, const jsi::Value &thisValue, const jsi::Value *args, size_t count)
194194
-> jsi::Value {

0 commit comments

Comments
 (0)