fix: calculate array length in bytes instead of elements count (#978)

* fix: calculate array length in bytes instead of elements count

* fix: removed comment

---------

Co-authored-by: maciejmakowski2003 <maciejmakowski2003@users.noreply.github.com>

Author: maciejmakowski2003

apps/fabric-example/ios/Podfile.lock

@@ -2588,7 +2588,7 @@ SPEC CHECKSUMS:
   ReactCodegen: f66521b131699d6af0790f10653933b3f1f79a6f
   ReactCommon: 07572bf9e687c8a52fbe4a3641e9e3a1a477c78e
   ReactNativeDependencies: 3467a1fea6f7a524df13b30430bebcc254d9aee2
-  RNAudioAPI: cb97b644449ba63f7ae31c02f73e9cf1ab8fd259
+  RNAudioAPI: fa5c075d2fcdb1ad9a695754b38f07c8c3074396
   RNGestureHandler: 07de6f059e0ee5744ae9a56feb07ee345338cc31
   RNReanimated: d75c81956bf7531fe08ba4390149002ab8bdd127
   RNScreens: 6cb648bdad8fe9bee9259fe144df95b6d1d5b707

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioParamHostObject.cpp

@@ -104,7 +104,7 @@ JSI_HOST_FUNCTION_IMPL(AudioParamHostObject, setValueCurveAtTime) {
   auto arrayBuffer =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
   auto rawValues = reinterpret_cast<float *>(arrayBuffer.data(runtime));
-  auto length = static_cast<int>(arrayBuffer.size(runtime));
+  auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));
   auto values = std::make_shared<AudioArray>(rawValues, length);
 
   auto event = [param = param_,

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/BaseAudioContextHostObject.cpp

@@ -263,7 +263,7 @@ JSI_HOST_FUNCTION_IMPL(BaseAudioContextHostObject, createPeriodicWave) {
   auto arrayBufferReal =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
   auto real = reinterpret_cast<float *>(arrayBufferReal.data(runtime));
-  auto length = static_cast<int>(arrayBufferReal.size(runtime));
+  auto length = static_cast<int>(arrayBufferReal.size(runtime) / sizeof(float));
 
   auto arrayBufferImag =
       args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/analysis/AnalyserNodeHostObject.cpp

@@ -80,7 +80,7 @@ JSI_HOST_FUNCTION_IMPL(AnalyserNodeHostObject, getFloatFrequencyData) {
   auto arrayBuffer =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
   auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
-  auto length = static_cast<int>(arrayBuffer.size(runtime));
+  auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));
 
   auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
   analyserNode->getFloatFrequencyData(data, length);
@@ -104,7 +104,7 @@ JSI_HOST_FUNCTION_IMPL(AnalyserNodeHostObject, getFloatTimeDomainData) {
   auto arrayBuffer =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
   auto data = reinterpret_cast<float *>(arrayBuffer.data(runtime));
-  auto length = static_cast<int>(arrayBuffer.size(runtime));
+  auto length = static_cast<int>(arrayBuffer.size(runtime) / sizeof(float));
 
   auto analyserNode = std::static_pointer_cast<AnalyserNode>(node_);
   analyserNode->getFloatTimeDomainData(data, length);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/BiquadFilterNodeHostObject.cpp

@@ -68,8 +68,7 @@ JSI_HOST_FUNCTION_IMPL(BiquadFilterNodeHostObject, getFrequencyResponse) {
   auto arrayBufferFrequency =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
   auto frequencyArray = reinterpret_cast<float *>(arrayBufferFrequency.data(runtime));
-  // arrayBufferFrequency is Float32Array from JS and size is in bytes thus hardcoded division by 4
-  auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime) / 4);
+  auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime) / sizeof(float));
 
   auto arrayBufferMag =
       args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/effects/IIRFilterNodeHostObject.cpp

@@ -18,7 +18,7 @@ JSI_HOST_FUNCTION_IMPL(IIRFilterNodeHostObject, getFrequencyResponse) {
   auto arrayBufferFrequency =
       args[0].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);
   auto frequencyArray = reinterpret_cast<float *>(arrayBufferFrequency.data(runtime));
-  auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime));
+  auto length = static_cast<size_t>(arrayBufferFrequency.size(runtime) / sizeof(float));
 
   auto arrayBufferMag =
       args[1].getObject(runtime).getPropertyAsObject(runtime, "buffer").getArrayBuffer(runtime);