refactor: disconnect all outputs from a node

Author: maciejmakowski2003

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioNodeHostObject.cpp

@@ -63,7 +63,7 @@ JSI_HOST_FUNCTION_IMPL(AudioNodeHostObject, connect) {
   auto obj = args[0].getObject(runtime);
   if (obj.isHostObject<AudioNodeHostObject>(runtime)) {
     auto node = obj.getHostObject<AudioNodeHostObject>(runtime);
-    connectNode(*node);
+    connect(*node);
   } else if (obj.isHostObject<AudioDestinationNodeHostObject>(runtime)) {
     auto dest = obj.getHostObject<AudioDestinationNodeHostObject>(runtime);
     graph_->addEdge(node_, dest->rawNode());
@@ -77,15 +77,14 @@ JSI_HOST_FUNCTION_IMPL(AudioNodeHostObject, connect) {
 
 JSI_HOST_FUNCTION_IMPL(AudioNodeHostObject, disconnect) {
   if (args[0].isUndefined()) {
-    // TODO
-    // node_->disconnect();
+    disconnect();
     return jsi::Value::undefined();
   }
 
   auto obj = args[0].getObject(runtime);
   if (obj.isHostObject<AudioNodeHostObject>(runtime)) {
     auto node = obj.getHostObject<AudioNodeHostObject>(runtime);
-    disconnectNode(*node);
+    disconnect(*node);
   } else if (obj.isHostObject<AudioDestinationNodeHostObject>(runtime)) {
     auto dest = obj.getHostObject<AudioDestinationNodeHostObject>(runtime);
     graph_->removeEdge(node_, dest->rawNode());

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioNodeHostObject.h

@@ -29,6 +29,9 @@ class AudioNodeHostObject : public JsiHostObject, public utils::graph::HostNode
   JSI_PROPERTY_GETTER_DECL(channelCountMode);
   JSI_PROPERTY_GETTER_DECL(channelInterpretation);
 
+  using utils::graph::HostNode::connect;
+  using utils::graph::HostNode::disconnect;
+
   JSI_HOST_FUNCTION_DECL(connect);
   JSI_HOST_FUNCTION_DECL(disconnect);
 

packages/react-native-audio-api/common/cpp/audioapi/core/utils/graph/Graph.hpp

@@ -173,6 +173,15 @@ class Graph {
     });
   }
 
+  /// @brief Removes all outgoing edges from `from`.
+  Res removeAllEdges(HNode *from) {
+    hostGraph.collectDisposedNodes();
+    return hostGraph.removeAllEdges(from).map([&](AGEvent event) {
+      eventSender_.send(std::move(event));
+      return NoneType{};
+    });
+  }
+
   // ── Param bridge API ───────────────────────────────────────────────────
 
   /// @brief Creates a bridge node representing: source → bridge → owner.

packages/react-native-audio-api/common/cpp/audioapi/core/utils/graph/HostGraph.hpp

@@ -103,6 +103,10 @@ class HostGraph {
   /// @return AGEvent that removes the input on the AudioGraph side.
   Res removeEdge(Node *from, Node *to);
 
+  /// @brief Removes all outgoing edges from `from`.
+  /// @return single AGEvent that removes all inputs on the AudioGraph side, or NODE_NOT_FOUND.
+  Res removeAllEdges(Node *from);
+
   /// @brief Current number of live (non-ghost) edges.
   [[nodiscard]] size_t edgeCount() const;
 
@@ -258,6 +262,32 @@ inline auto HostGraph::removeEdge(Node *from, Node *to) -> Res {
   });
 }
 
+inline auto HostGraph::removeAllEdges(Node *from) -> Res {
+  if (std::find(nodes.begin(), nodes.end(), from) == nodes.end() || from->ghost) {
+    return Res::Err(ResultError::NODE_NOT_FOUND);
+  }
+
+  auto pairs = std::make_shared<std::vector<std::pair<std::uint32_t, std::uint32_t>>>();
+  pairs->reserve(from->outputs.size());
+
+  for (Node *to : from->outputs) {
+    auto itIn = std::find(to->inputs.begin(), to->inputs.end(), from);
+    if (itIn != to->inputs.end()) {
+      to->inputs.erase(itIn);
+    }
+    edgeCount_--;
+    pairs->emplace_back(from->handle->index, to->handle->index);
+  }
+  from->outputs.clear();
+
+  return Res::Ok([pairs = std::move(pairs)](AudioGraph &graph, auto &) {
+    for (auto &[fromIdx, toIdx] : *pairs) {
+      graph.pool().remove(graph[toIdx].input_head, fromIdx);
+    }
+    graph.markDirty();
+  });
+}
+
 inline bool HostGraph::hasPath(Node *start, Node *end) {
   if (start == end) {
     return true;

packages/react-native-audio-api/common/cpp/audioapi/core/utils/graph/HostNode.hpp

@@ -93,13 +93,13 @@ class HostNode {
 
   /// @brief Connects this node's output to another node's input (this → other).
   /// @return Ok on success, Err on cycle / duplicate / not-found
-  Res connectNode(HostNode &other) {
+  Res connect(HostNode &other) {
     return graph_->addEdge(node_, other.node_);
   }
 
   /// @brief Disconnects this node's output from another node's input.
   /// @return Ok on success, Err on not-found
-  Res disconnectNode(HostNode &other) {
+  Res disconnect(HostNode &other) {
     return graph_->removeEdge(node_, other.node_);
   }
 
@@ -115,6 +115,12 @@ class HostNode {
     return graph_->disconnectParam(node_, owner.node_, param);
   }
 
+  /// @brief Disconnects all this node's outputs.
+  /// @return Ok on success, Err on not-found
+  Res disconnect() {
+    return graph_->removeAllEdges(node_);
+  }
+
   /// @brief Returns the raw HostGraph::Node pointer (for advanced usage / testing).
   [[nodiscard]] HNode *rawNode() const {
     return node_;