enhance: when cloning remote repo or opening local repo, the Group is No Group (Uncategorized) by default (#2258)

Signed-off-by: leo <longshuang@msn.cn>

Author: love-linger

src/ViewModels/Clone.cs

@@ -85,9 +85,9 @@ public Clone(string pageId)
             _pageId = pageId;
 
             Groups = new List<RepositoryNode>();
+            Groups.Add(new RepositoryNode { Name = "No Group (Uncategorized)", Id = string.Empty });
+            SelectedGroup = Groups[0];
             CollectGroups(Groups, Preferences.Instance.RepositoryNodes);
-            if (Groups.Count > 0)
-                SelectedGroup = Groups[0];
 
             Bookmarks = new List<int>();
             for (var i = 0; i < Models.Bookmarks.Brushes.Length; i++)
@@ -166,7 +166,8 @@ public override async Task<bool> Sure()
 
             log.Complete();
 
-            var node = Preferences.Instance.FindOrAddNodeByRepositoryPath(path, _selectedGroup, true);
+            var parent = _selectedGroup is { Id: not "" } ? _selectedGroup : null;
+            var node = Preferences.Instance.FindOrAddNodeByRepositoryPath(path, parent, true);
             node.Bookmark = _bookmark;
             await node.UpdateStatusAsync(false, null);
 

src/ViewModels/OpenLocalRepository.cs

@@ -41,12 +41,11 @@ public int Bookmark
         public OpenLocalRepository(string pageId, RepositoryNode group)
         {
             _pageId = pageId;
-            _group = group;
 
             Groups = new List<RepositoryNode>();
+            Groups.Add(new RepositoryNode { Name = "No Group (Uncategorized)", Id = string.Empty });
+            Group = group ?? Groups[0];
             CollectGroups(Groups, Preferences.Instance.RepositoryNodes);
-            if (Groups.Count > 0 && _group == null)
-                Group = Groups[0];
 
             Bookmarks = new List<int>();
             for (var i = 0; i < Models.Bookmarks.Brushes.Length; i++)
@@ -63,6 +62,7 @@ public static ValidationResult ValidateRepoPath(string folder, ValidationContext
         public override async Task<bool> Sure()
         {
             var isBare = await new Commands.IsBareRepository(_repoPath).GetResultAsync();
+            var parent = _group is { Id: not "" } ? _group : null;
             var repoRoot = _repoPath;
             if (!isBare)
             {
@@ -78,7 +78,7 @@ public override async Task<bool> Sure()
                     {
                         if (page.Node.Id.Equals(_pageId, StringComparison.Ordinal))
                         {
-                            page.Popup = new Init(page.Node.Id, _repoPath, _group, test.StdErr);
+                            page.Popup = new Init(page.Node.Id, _repoPath, parent, test.StdErr);
                             break;
                         }
                     }
@@ -87,7 +87,7 @@ public override async Task<bool> Sure()
                 }
             }
 
-            var node = Preferences.Instance.FindOrAddNodeByRepositoryPath(repoRoot, _group, true);
+            var node = Preferences.Instance.FindOrAddNodeByRepositoryPath(repoRoot, parent, true);
             node.Bookmark = _bookmark;
             await node.UpdateStatusAsync(false, null);
             Welcome.Instance.Refresh();