chore: adopt ESLint

Author: felixfbecker

.eslintrc.json

@@ -0,0 +1,6 @@
+{
+  "extends": "@sourcegraph/eslint-config",
+  "parserOptions": {
+    "project": "tsconfig.json"
+  }
+}

.travis.yml

@@ -9,8 +9,8 @@ jobs:
     - stage: test
       script:
         - npm run prettier-check
-        - npm run tslint
         - npm run typecheck
+        - npm run eslint
         - npm run build
         - npm run cover
         - nyc report --reporter json

.vscode/tasks.json

@@ -0,0 +1,12 @@
+{
+  // See https://go.microsoft.com/fwlink/?LinkId=733558
+  // for the documentation about the tasks.json format
+  "version": "2.0.0",
+  "tasks": [
+    {
+      "type": "npm",
+      "script": "eslint",
+      "problemMatcher": ["$eslint-stylish"]
+    }
+  ]
+}

package.json

@@ -90,7 +90,7 @@
     ]
   },
   "scripts": {
-    "tslint": "tslint -p tsconfig.json './src/**/*.ts'",
+    "eslint": "eslint './src/**/*.ts'",
     "typecheck": "tsc -p tsconfig.json",
     "test": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' mocha --require ts-node/register --require source-map-support/register --opts mocha.opts",
     "cover": "TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --require ts-node/register --require source-map-support/register --all mocha --opts mocha.opts --timeout 10000",
@@ -109,12 +109,13 @@
   "devDependencies": {
     "@commitlint/cli": "^7.0.0",
     "@commitlint/config-conventional": "^7.0.1",
+    "@sourcegraph/eslint-config": "^0.12.0",
     "@sourcegraph/prettierrc": "^2.2.0",
     "@sourcegraph/tsconfig": "^3.0.0",
-    "@sourcegraph/tslint-config": "^12.1.0",
     "@types/mocha": "^5.2.6",
     "@types/node": "^12.7.3",
     "@types/sinon": "^7.0.8",
+    "eslint": "^6.8.0",
     "husky": "^1.3.1",
     "mocha": "^6.0.2",
     "nyc": "^13.3.0",
@@ -124,7 +125,6 @@
     "source-map-support": "^0.5.10",
     "sourcegraph": "^23.0.0",
     "ts-node": "^8.0.2",
-    "tslint": "^5.13.1",
     "typescript": "^3.3.3333"
   },
   "dependencies": {

src/codeownersFile.ts

@@ -4,19 +4,6 @@ import gql from 'tagged-template-noop'
 import { resolveURI } from './uri'
 import { memoizeAsync } from './util/memoizeAsync'
 
-export async function getCodeOwners(uri: string): Promise<string[] | null> {
-    const codeownersFile = await getCodeownersFile({ uri, sourcegraph })
-    if (!codeownersFile) {
-        return null
-    }
-    const codeownersEntries = parseCodeownersFile(codeownersFile)
-    const entry = matchCodeownersFile(resolveURI(uri).path, codeownersEntries)
-    if (entry) {
-        return entry.owners
-    }
-    return null
-}
-
 const getCodeownersFile = memoizeAsync(
     async ({
         uri,
@@ -61,6 +48,19 @@ const getCodeownersFile = memoizeAsync(
     }
 )
 
+export async function getCodeOwners(uri: string): Promise<string[] | null> {
+    const codeownersFile = await getCodeownersFile({ uri, sourcegraph })
+    if (!codeownersFile) {
+        return null
+    }
+    const codeownersEntries = parseCodeownersFile(codeownersFile)
+    const entry = matchCodeownersFile(resolveURI(uri).path, codeownersEntries)
+    if (entry) {
+        return entry.owners
+    }
+    return null
+}
+
 /**
  * An individual entry from a CODEOWNERS file
  */

src/extension.ts

@@ -1,38 +1,41 @@
 import { combineLatest, from, Observable } from 'rxjs'
-import { startWith } from 'rxjs/operators'
+import { startWith, switchMap, filter, map } from 'rxjs/operators'
 import * as sourcegraph from 'sourcegraph'
 import { getCodeOwners } from './codeownersFile'
 import { formatCodeOwners } from './codeOwners'
 
 export function activate(ctx: sourcegraph.ExtensionContext): void {
     ctx.subscriptions.add(
-        combineLatest(
+        combineLatest([
             from(sourcegraph.workspace.onDidOpenTextDocument).pipe(
                 startWith(
                     sourcegraph.app.activeWindow && sourcegraph.app.activeWindow.activeViewComponent
                         ? sourcegraph.app.activeWindow.activeViewComponent.document
                         : null
                 )
             ),
-            new Observable(subscriber => sourcegraph.configuration.subscribe(() => subscriber.next()))
-        ).subscribe(async ([doc]) => {
-            if (!doc) {
-                return
-            }
-
-            let owners: string[] | null = null
-            if (!sourcegraph.configuration.get().value['codeOwnership.hide']) {
-                try {
-                    owners = await getCodeOwners(doc.uri)
-                } catch (err) {
-                    console.error(`Error getting code owners for ${doc.uri}:`, err)
-                }
-            }
-            const { label, description } = formatCodeOwners(owners)
-            sourcegraph.internal.updateContext({
-                [`codeOwnership.file.${doc.uri}.label`]: label,
-                [`codeOwnership.file.${doc.uri}.description`]: description,
+            new Observable(subscriber => sourcegraph.configuration.subscribe(() => subscriber.next())),
+        ])
+            .pipe(
+                map(([textDocument]) => textDocument),
+                filter((textDocument): textDocument is NonNullable<typeof textDocument> => !!textDocument),
+                switchMap(async textDocument => {
+                    if (!sourcegraph.configuration.get().value['codeOwnership.hide']) {
+                        try {
+                            return { textDocument, owners: await getCodeOwners(textDocument.uri) }
+                        } catch (err) {
+                            console.error(`Error getting code owners for ${textDocument.uri}:`, err)
+                        }
+                    }
+                    return { textDocument, owners: null }
+                })
+            )
+            .subscribe(({ textDocument, owners }) => {
+                const { label, description } = formatCodeOwners(owners)
+                sourcegraph.internal.updateContext({
+                    [`codeOwnership.file.${textDocument.uri}.label`]: label,
+                    [`codeOwnership.file.${textDocument.uri}.description`]: description,
+                })
             })
-        })
     )
 }