Skip to content
This repository was archived by the owner on Mar 10, 2022. It is now read-only.

Commit 4993714

Browse files
committed
fix: remove todos
1 parent 429e19f commit 4993714

3 files changed

Lines changed: 3 additions & 6 deletions

File tree

src/commands/goToRepositoryCommand.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { openSourcegraphUriCommand } from './openSourcegraphUriCommand'
66
import { BrowseQuickPickItem, SourcegraphQuickPick } from './SourcegraphQuickPick'
77
import { recentlyOpenRepositoriesSetting } from '../settings/recentlyOpenRepositoriesSetting'
88
import { endpointSetting } from '../settings/endpointSetting'
9+
import { log } from '../log'
910

1011
export async function goToRepositoryCommand(fs: SourcegraphFileSystemProvider): Promise<void> {
1112
const quick = new SourcegraphQuickPick(fs)
@@ -31,8 +32,8 @@ export async function goToRepositoryCommand(fs: SourcegraphFileSystemProvider):
3132
detail: query.text,
3233
}
3334
quick.pick.items = [item]
34-
} catch {
35-
// TODO: report helpful error message
35+
} catch (error) {
36+
log.error(`goToRepositoryCommand(${query.text})`, error)
3637
}
3738
return
3839
}

src/file-system/FileTree.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ export class FileTree {
1212
return `FileTree(${this.uri.uri}, files.length=${this.files.length})`
1313
}
1414

15-
// TODO: optimize this for very large repos like chromium/chromium. It's
16-
// usable in its current state but could be much faster if we use binary
17-
// search to skip unrelated paths.
1815
public directChildren(directory: string): string[] {
1916
return this.directChildrenInternal(directory, true)
2017
}

src/search/SourcegraphLocationRenderer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// TODO: try to use file extension `.mts` or see if we can add types.
21
/**
32
* Renders the 'application/sourcegraph-location' MIME type for Sourcegraph Notebooks
43
*

0 commit comments

Comments
 (0)