fix formatting and error messages

Author: peterguy

cmd/src/main.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"encoding/json"
 	"flag"
-	"fmt"
 	"io"
 	"log"
 	"net"
@@ -117,10 +116,10 @@ func parseEndpoint(endpoint string) (*url.URL, error) {
 		return nil, err
 	}
 	if !(u.Scheme == "http" || u.Scheme == "https") {
-		return nil, errors.Newf("Invalid scheme %s. Require http or https", u.Scheme)
+		return nil, errors.Newf("invalid scheme %s: require http or https", u.Scheme)
 	}
 	if u.Host == "" {
-		return nil, errors.Newf("Empty host")
+		return nil, errors.Newf("empty host")
 	}
 	return u, nil
 }
@@ -273,20 +272,20 @@ func readConfig() (*config, error) {
 			}
 			isValidUDS, err := isValidUnixSocket(path)
 			if err != nil {
-				return nil, errors.Newf("Invalid proxy configuration: %w", err)
+				return nil, errors.Newf("invalid proxy configuration: %w", err)
 			}
 			if !isValidUDS {
 				return nil, errors.Newf("invalid proxy socket: %s", path)
 			}
 			cfg.proxyPath = path
 		} else {
-			return nil, errors.Newf("Invalid proxy endpoint: %s", proxyStr)
+			return nil, errors.Newf("invalid proxy endpoint: %s", proxyStr)
 		}
 	} else {
 		// no SRC_PROXY; check for the standard proxy env variables HTTP_PROXY, HTTPS_PROXY, and NO_PROXY
 		if u, err := http.ProxyFromEnvironment(&http.Request{URL: cfg.endpointURL}); err != nil {
 			// when there's an error, the value for the env variable is not a legit URL
-			return nil, fmt.Errorf("Invalid HTTP_PROXY or HTTPS_PROXY value: %w", err)
+			return nil, errors.Newf("invalid HTTP_PROXY or HTTPS_PROXY value: %w", err)
 		} else {
 			cfg.proxyURL = u
 		}
@@ -321,7 +320,7 @@ func isValidUnixSocket(path string) (bool, error) {
 		if os.IsNotExist(err) {
 			return false, nil
 		}
-		return false, errors.Newf("Not a UNIX Domain Socket: %v: %w", path, err)
+		return false, errors.Newf("not a UNIX domain socket: %v: %w", path, err)
 	}
 	defer conn.Close()
 

cmd/src/search_stream_test.go

@@ -5,8 +5,8 @@ import (
 	"io"
 	"net"
 	"net/http"
-	"net/url"
 	"net/http/httptest"
+	"net/url"
 	"os"
 	"testing"