close the connection if the TLS handshake errors

peterguy · peterguy · commit d14fe39301eb · 2026-03-10T21:40:41.000-07:00
diff --git a/internal/api/proxy.go b/internal/api/proxy.go
@@ -63,6 +63,7 @@ func withProxyTransport(baseTransport *http.Transport, proxyURL *url.URL, proxyP
 		}
 		tlsConn := tls.Client(conn, cfg)
 		if err := tlsConn.HandshakeContext(ctx); err != nil {
+			tlsConn.Close()
 			return nil, err
 		}
 		return tlsConn, nil

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,7 @@ func withProxyTransport(baseTransport http.Transport, proxyURL url.URL, proxyP`
`63`	`63`	`}`
`64`	`64`	`tlsConn := tls.Client(conn, cfg)`
`65`	`65`	`if err := tlsConn.HandshakeContext(ctx); err != nil {`
	`66`	`+ tlsConn.Close()`
`66`	`67`	`return nil, err`
`67`	`68`	`}`
`68`	`69`	`return tlsConn, nil`