Merge pull request #13 from splitgraph/gcs-scheme-alignement

gruuya · web-flow · commit 42fba471d009 · 2025-05-21T14:11:45.000+02:00
feat: align GCS scheme name with other libs
diff --git a/iceberg-rust/src/object_store/mod.rs b/iceberg-rust/src/object_store/mod.rs
@@ -31,7 +31,7 @@ impl Display for Bucket<'_> {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             Bucket::S3(s) => write!(f, "s3://{}", s),
-            Bucket::GCS(s) => write!(f, "gcs://{}", s),
+            Bucket::GCS(s) => write!(f, "gs://{}", s),
             Bucket::Local => write!(f, ""),
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ impl Display for Bucket<'_> {`
`31`	`31`	`fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {`
`32`	`32`	`match self {`
`33`	`33`	`Bucket::S3(s) => write!(f, "s3://{}", s),`
`34`		`- Bucket::GCS(s) => write!(f, "gcs://{}", s),`
	`34`	`+ Bucket::GCS(s) => write!(f, "gs://{}", s),`
`35`	`35`	`Bucket::Local => write!(f, ""),`
`36`	`36`	`}`
`37`	`37`	`}`