fix clippy warnings

Author: JanKaul

iceberg-rust-spec/src/spec/materialized_view_metadata.rs

@@ -29,7 +29,7 @@ pub type MaterializedViewMetadata = GeneralViewMetadata<FullIdentifier>;
 pub type MaterializedViewMetadataBuilder = GeneralViewMetadataBuilder<FullIdentifier>;
 
 impl MaterializedViewMetadata {
-    pub fn as_ref(&self) -> TabularMetadataRef {
+    pub fn as_ref(&self) -> TabularMetadataRef<'_> {
         TabularMetadataRef::MaterializedView(self)
     }
 }

iceberg-rust-spec/src/spec/table_metadata.rs

@@ -204,7 +204,7 @@ impl TableMetadata {
     pub fn current_partition_fields(
         &self,
         branch: Option<&str>,
-    ) -> Result<Vec<BoundPartitionField>, Error> {
+    ) -> Result<Vec<BoundPartitionField<'_>>, Error> {
         let schema = self.current_schema(branch)?;
         let partition_spec = self.default_partition_spec()?;
         partition_fields(partition_spec, schema)
@@ -218,7 +218,10 @@ impl TableMetadata {
     /// # Returns
     /// * `Result<Vec<BoundPartitionField>, Error>` - Vector of partition fields bound to their source schema fields,
     ///   or an error if the schema or partition spec cannot be found
-    pub fn partition_fields(&self, snapshot_id: i64) -> Result<Vec<BoundPartitionField>, Error> {
+    pub fn partition_fields(
+        &self,
+        snapshot_id: i64,
+    ) -> Result<Vec<BoundPartitionField<'_>>, Error> {
         let schema = self.schema(snapshot_id)?;
         self.default_partition_spec()?
             .fields()
@@ -325,7 +328,7 @@ impl TableMetadata {
             .map(|x| *x.sequence_number())
     }
 
-    pub fn as_ref(&self) -> TabularMetadataRef {
+    pub fn as_ref(&self) -> TabularMetadataRef<'_> {
         TabularMetadataRef::Table(self)
     }
 }

iceberg-rust-spec/src/spec/view_metadata.rs

@@ -143,7 +143,7 @@ impl<T: Materialization> GeneralViewMetadata<T> {
 }
 
 impl ViewMetadata {
-    pub fn as_ref(&self) -> TabularMetadataRef {
+    pub fn as_ref(&self) -> TabularMetadataRef<'_> {
         TabularMetadataRef::View(self)
     }
 }

iceberg-rust/src/file_format/parquet.rs

@@ -258,8 +258,7 @@ pub fn parquet_to_datafile(
     }
 
     let content = builder
-        .build()
-        .map_err(iceberg_rust_spec::error::Error::from)?;
+        .build()?;
     Ok(content)
 }
 

iceberg-rust/src/materialized_view/mod.rs

@@ -152,7 +152,7 @@ impl MaterializedView {
     ///
     /// # Returns
     /// A new transaction that can be used to perform multiple operations atomically
-    pub fn new_transaction(&mut self, branch: Option<&str>) -> MaterializedViewTransaction {
+    pub fn new_transaction(&mut self, branch: Option<&str>) -> MaterializedViewTransaction<'_> {
         MaterializedViewTransaction::new(self, branch)
     }
     /// Returns the storage table that contains the materialized data for this view

iceberg-rust/src/object_store/mod.rs

@@ -40,7 +40,7 @@ impl Display for Bucket<'_> {
 
 impl Bucket<'_> {
     /// Get the bucket and coud provider from the location string
-    pub fn from_path(path: &str) -> Result<Bucket, Error> {
+    pub fn from_path(path: &str) -> Result<Bucket<'_>, Error> {
         if path.starts_with("s3://") || path.starts_with("s3a://") {
             let prefix = if path.starts_with("s3://") {
                 "s3://"

iceberg-rust/src/table/manifest.rs

@@ -37,7 +37,7 @@ use iceberg_rust_spec::{
 };
 use object_store::ObjectStore;
 
-use crate::{error::Error, spec};
+use crate::error::Error;
 
 type ReaderZip<'a, R> = Zip<AvroReader<'a, R>, Repeat<Arc<(Schema, PartitionSpec, FormatVersion)>>>;
 type ReaderMap<'a, R> = Map<
@@ -130,8 +130,7 @@ impl<R: Read> ManifestReader<'_, R> {
         let partition_spec = PartitionSpec::builder()
             .with_spec_id(spec_id)
             .with_fields(partition_fields)
-            .build()
-            .map_err(spec::error::Error::from)?;
+            .build()?;
         Ok(Self {
             reader: reader
                 .zip(repeat(Arc::new((schema, partition_spec, format_version))))

iceberg-rust/src/table/mod.rs

@@ -287,7 +287,7 @@ impl Table {
     ///
     /// The transaction must be committed for any changes to take effect.
     /// Multiple operations can be chained within a single transaction.
-    pub fn new_transaction(&mut self, branch: Option<&str>) -> TableTransaction {
+    pub fn new_transaction(&mut self, branch: Option<&str>) -> TableTransaction<'_> {
         TableTransaction::new(self, branch)
     }
 }

iceberg-rust/src/table/transaction/operation.rs

@@ -149,9 +149,7 @@ impl Operation {
                                 .with_format_version(table_metadata.format_version)
                                 .with_status(Status::Added)
                                 .with_data_file(data_file)
-                                .build()
-                                .map_err(crate::spec::error::Error::from)
-                                .map_err(Error::from)
+                                .build().map_err(Error::from)
                         });
 
                 let snapshot_id = generate_snapshot_id();
@@ -198,8 +196,7 @@ impl Operation {
                     snapshot_builder.with_parent_snapshot_id(*snapshot.snapshot_id());
                 }
                 let snapshot = snapshot_builder
-                    .build()
-                    .map_err(iceberg_rust_spec::error::Error::from)?;
+                    .build()?;
 
                 Ok((
                     old_snapshot.map(|x| TableRequirement::AssertRefSnapshotId {
@@ -253,9 +250,7 @@ impl Operation {
                         .with_snapshot_id(snapshot_id)
                         .with_sequence_number(sequence_number)
                         .with_data_file(data_file.clone())
-                        .build()
-                        .map_err(crate::spec::error::Error::from)
-                        .map_err(Error::from)
+                        .build().map_err(Error::from)
                 });
 
                 let manifest_schema = ManifestEntry::schema(
@@ -347,8 +342,7 @@ impl Operation {
                         other: additional_summary.unwrap_or_default(),
                     });
                 let snapshot = snapshot_builder
-                    .build()
-                    .map_err(iceberg_rust_spec::error::Error::from)?;
+                    .build()?;
 
                 Ok((
                     old_snapshot.map(|x| TableRequirement::AssertRefSnapshotId {
@@ -422,9 +416,7 @@ impl Operation {
                         .with_format_version(table_metadata.format_version)
                         .with_status(Status::Added)
                         .with_data_file(data_file)
-                        .build()
-                        .map_err(crate::spec::error::Error::from)
-                        .map_err(Error::from)
+                        .build().map_err(Error::from)
                 });
 
                 let snapshot_id = generate_snapshot_id();
@@ -489,8 +481,7 @@ impl Operation {
                     );
                 snapshot_builder.with_parent_snapshot_id(*old_snapshot.snapshot_id());
                 let snapshot = snapshot_builder
-                    .build()
-                    .map_err(iceberg_rust_spec::error::Error::from)?;
+                    .build()?;
 
                 Ok((
                     Some(TableRequirement::AssertRefSnapshotId {

iceberg-rust/src/view/mod.rs

@@ -181,7 +181,7 @@ impl View {
     ///
     /// Transactions ensure that all changes are applied atomically with ACID guarantees.
     /// Multiple operations can be chained and will be committed together.
-    pub fn new_transaction(&mut self, branch: Option<&str>) -> ViewTransaction {
+    pub fn new_transaction(&mut self, branch: Option<&str>) -> ViewTransaction<'_> {
         ViewTransaction::new(self, branch)
     }
 }