Skip to content

Commit 437e4ba

Browse files
committed
Fix airbyte tests and bump to Multicorn master
1 parent 0044f7b commit 437e4ba

4 files changed

Lines changed: 9 additions & 13 deletions

File tree

engine/src/Multicorn

splitgraph/ingestion/athena/__init__.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
import base64
2-
import json
3-
import urllib.parse
4-
from copy import deepcopy
51
from typing import TYPE_CHECKING, Any, Dict, Optional
62

73
from splitgraph.core.types import Credentials, Params, TableInfo
@@ -103,7 +99,7 @@ def get_server_options(self):
10399
options: Dict[str, Optional[str]] = {
104100
"wrapper": "multicorn.sqlalchemyfdw.SqlAlchemyFdw",
105101
"db_url": self._build_db_url(),
106-
"cast_quals": "yes",
102+
"cast_quals": "true",
107103
}
108104

109105
# For some reason, in SQLAlchemy, if this is not passed

test/splitgraph/ingestion/test_airbyte.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def _assert_scd_data(repo):
546546
def _assert_normalized_data(repo, unique_key=False):
547547
expected = [
548548
{
549-
"discovery": "2012-11-11T08:06:26Z",
549+
"discovery": "2012-11-11T08:06:26.000000Z",
550550
"friendly": True,
551551
"binary_data": "YmludHN0AA==",
552552
"name": "portobello",
@@ -555,10 +555,10 @@ def _assert_normalized_data(repo, unique_key=False):
555555
"_airbyte_ab_id": mock.ANY,
556556
"_airbyte_emitted_at": mock.ANY,
557557
"_airbyte_normalized_at": mock.ANY,
558-
"_airbyte_mushrooms_hashid": "e48f260f784baa48a5c4643ef36024af",
558+
"_airbyte_mushrooms_hashid": "882da3c55d7481c75a8f8919fc8441e1",
559559
},
560560
{
561-
"discovery": "2018-03-17T08:06:26Z",
561+
"discovery": "2018-03-17T08:06:26.000000Z",
562562
"friendly": False,
563563
"binary_data": "AAAxMjMAAA==",
564564
"name": "deathcap",
@@ -567,7 +567,7 @@ def _assert_normalized_data(repo, unique_key=False):
567567
"_airbyte_ab_id": mock.ANY,
568568
"_airbyte_emitted_at": mock.ANY,
569569
"_airbyte_normalized_at": mock.ANY,
570-
"_airbyte_mushrooms_hashid": "5257322455a690592e14baeb4d24069c",
570+
"_airbyte_mushrooms_hashid": "7c835aeba7c53e3a13acb6f953820bb6",
571571
},
572572
]
573573

@@ -670,7 +670,7 @@ def _assert_raw_data(repo):
670670
"_airbyte_data": {
671671
"name": "portobello",
672672
"friendly": True,
673-
"discovery": "2012-11-11T08:06:26Z",
673+
"discovery": "2012-11-11T08:06:26.000000Z",
674674
"binary_data": "YmludHN0AA==",
675675
"mushroom_id": 1,
676676
"varbinary_data": "fwAAAQ==",
@@ -682,7 +682,7 @@ def _assert_raw_data(repo):
682682
"_airbyte_data": {
683683
"name": "deathcap",
684684
"friendly": False,
685-
"discovery": "2018-03-17T08:06:26Z",
685+
"discovery": "2018-03-17T08:06:26.000000Z",
686686
"binary_data": "AAAxMjMAAA==",
687687
"mushroom_id": 2,
688688
"varbinary_data": "fwAAAQ==",

test/splitgraph/ingestion/test_athena.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def test_athena_data_source_options():
2424
assert source.get_server_options() == {
2525
"db_url": "awsathena+rest://key:secret@athena.eu-west-3.amazonaws.com:443/mydb?s3_staging_dir=s3://athena/results/",
2626
"wrapper": "multicorn.sqlalchemyfdw.SqlAlchemyFdw",
27-
"cast_quals": "yes",
27+
"cast_quals": "true",
2828
}
2929

3030

0 commit comments

Comments
 (0)