Skip to content

Commit f62787c

Browse files
mmelogranommelograno
committed
rollback change
1 parent 1a5dbda commit f62787c

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

‎src/SplitIO/Grammar/Condition.php‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,11 @@ public function match($key, array $attributes = null, $bucketingKey = null)
7575
//Check if Matcher has attributes
7676
if (!$matcher->hasAttribute()) {
7777
// scenario 1: no attr in matcher
78-
// e.g. if user is in segment all then feature flag 100:on
78+
// e.g. if user is in segment all then split 100:on
7979
$_evaluation = $matcher->evaluate($key);
8080
} else {
8181
// scenario 2: attribute provided but no attribute value provided. Matcher does not match
82-
// e.g. if user.age is >= 10 then feature flag 100:on
82+
// e.g. if user.age is >= 10 then split 100:on
8383
if ($attributes === null || !isset($attributes[$matcher->getAttribute()])) {
8484
$_evaluation = false;
8585
} else {

‎tests/Suite/Attributes/SdkAttributesTest.php‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ private function inOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
6262
private function equalToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
6363
{
6464
// = Operator
65-
//if user.attr = 0 then feature flag 100:on
65+
//if user.attr = 0 then split 100:on
6666
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_eq_number_zero', array('attr' => 0)));
6767
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_eq_number_zero', array('attr' => -0)));
6868
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_number_zero', array('attr' => 15)));
@@ -75,7 +75,7 @@ private function equalToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
7575
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_zero', array()));
7676
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_zero', null));
7777

78-
//if user.attr = 10 then feature flag 100:on
78+
//if user.attr = 10 then split 100:on
7979
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_eq_number_ten', array('attr' => 10)));
8080
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_number_ten', array('attr' => -10)));
8181
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_number_ten', array('attr' => 15)));
@@ -88,7 +88,7 @@ private function equalToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
8888
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_ten', array()));
8989
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_ten', null));
9090

91-
//if user.attr = -10 then feature flag 100:on
91+
//if user.attr = -10 then split 100:on
9292
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_eq_negative_number_ten', array('attr' => -10)));
9393
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_negative_number_ten', array('attr' => 10)));
9494
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_negative_number_ten', array('attr' => 15)));
@@ -101,7 +101,7 @@ private function equalToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
101101
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_negative_ten', array()));
102102
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_eq_negative_ten', null));
103103

104-
//if user.attr = datetime 1458240947021 then feature flag 100:on
104+
//if user.attr = datetime 1458240947021 then split 100:on
105105
//For DATETIME the EQUAL_TO remove the time in order to compare only the date.
106106
$date = new \DateTime("2016/03/17 06:55:23PM", new \DateTimeZone("UTC"));
107107
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_eq_datetime_1458240947021', array('attr' => $date->getTimestamp())));
@@ -123,7 +123,7 @@ private function equalToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
123123
private function greaterThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
124124
{
125125
// >= Operator
126-
//if user.attr >= 10 then feature flag 100:on
126+
//if user.attr >= 10 then split 100:on
127127
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_gte_10', array('attr' => 10)));
128128
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_gte_10', array('attr' => 11)));
129129
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_gte_10', array('attr' => 9)));
@@ -136,7 +136,7 @@ private function greaterThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $spli
136136
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_gte_number_10', array()));
137137
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_gte_number_10', null));
138138

139-
//if user.attr >= -10 then feature flag 100:on
139+
//if user.attr >= -10 then split 100:on
140140
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_gte_negative_10', array('attr' => -10)));
141141
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_gte_negative_10', array('attr' => -9)));
142142
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_gte_negative_10', array('attr' => -11)));
@@ -149,7 +149,7 @@ private function greaterThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $spli
149149
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_gte_negative_number_10', array()));
150150
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_gte_negative_number_10', null));
151151

152-
//if user.attr >= datetime 1458240947021 then feature flag 100:on
152+
//if user.attr >= datetime 1458240947021 then split 100:on
153153
$date = new \DateTime("2016/03/17 06:55:23PM", new \DateTimeZone("UTC"));
154154
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_gte_datetime_1458240947021', array('attr' => $date->getTimestamp())));
155155
$date = new \DateTime("2016/03/17 06:55:00PM", new \DateTimeZone("UTC"));
@@ -165,7 +165,7 @@ private function greaterThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $spli
165165
private function lessThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
166166
{
167167
// <= Operator
168-
//if user.attr <= 10 then feature flag 100:on
168+
//if user.attr <= 10 then split 100:on
169169
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_lte_10', array('attr' => 10)));
170170
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_lte_10', array('attr' => 9)));
171171
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_lte_10', array('attr' => 11)));
@@ -178,7 +178,7 @@ private function lessThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $splitSd
178178
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_lte_number_10', array()));
179179
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_lte_number_10', null));
180180

181-
//if user.attr <= -10 then feature flag 100:on
181+
//if user.attr <= -10 then split 100:on
182182
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_lte_negative_10', array('attr' => -10)));
183183
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_lte_negative_10', array('attr' => -11)));
184184
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_lte_negative_10', array('attr' => -9)));
@@ -191,7 +191,7 @@ private function lessThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $splitSd
191191
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_lte_negative_number_10', array()));
192192
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_lte_negative_number_10', null));
193193

194-
//if user.attr <= datetime 1458240947021 then feature flag 100:on
194+
//if user.attr <= datetime 1458240947021 then split 100:on
195195
$date = new \DateTime("2016/03/17 06:55:23PM", new \DateTimeZone("UTC"));
196196
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_lte_datetime_1458240947021', array('attr' => $date->getTimestamp())));
197197
$date = new \DateTime("2016/03/17 06:55:00PM", new \DateTimeZone("UTC"));
@@ -207,7 +207,7 @@ private function lessThanOrEqualToOperator(\SplitIO\Sdk\ClientInterface $splitSd
207207
private function betweenOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
208208
{
209209
// Between Operator
210-
//if user.attr is between -10 and 20 then feature flag 100:on
210+
//if user.attr is between -10 and 20 then split 100:on
211211
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_btw_negative_10_and_20', array('attr' => -10)));
212212
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_btw_negative_10_and_20', array('attr' => 0)));
213213
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_btw_negative_10_and_20', array('attr' => 20)));
@@ -224,7 +224,7 @@ private function betweenOperator(\SplitIO\Sdk\ClientInterface $splitSdk)
224224
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_btw_number_negative_10_and_20', array()));
225225
$this->assertEquals('off', $splitSdk->getTreatment('user1', 'user_attr_btw_number_negative_10_and_20', null));
226226

227-
//if user.attr is between datetime 1458240947021 and 1459452812642 then feature flag 100:on
227+
//if user.attr is between datetime 1458240947021 and 1459452812642 then split 100:on
228228
$date = new \DateTime("2016/03/17 06:55:47PM", new \DateTimeZone("UTC"));
229229
$this->assertEquals('on', $splitSdk->getTreatment('user1', 'user_attr_btw_datetime_1458240947021_and_1458246884077', array('attr' => $date->getTimestamp())));
230230
$date = new \DateTime("2016/03/17 08:34:44PM", new \DateTimeZone("UTC"));

0 commit comments

Comments
 (0)