Skip to content

Commit 26f230d

Browse files
chillaqchillaq
committed
Fixing test error on git
1 parent c6a5bc6 commit 26f230d

1 file changed

Lines changed: 47 additions & 48 deletions

File tree

‎tests/integration/test_client_e2e.py‎

Lines changed: 47 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def setup_method(self):
5353

5454
telemetry_storage = InMemoryTelemetryStorage()
5555
telemetry_producer = TelemetryStorageProducer(telemetry_storage)
56-
telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
56+
# telemetry_consumer = TelemetryStorageConsumer(telemetry_storage)
5757
telemetry_runtime_producer = telemetry_producer.get_telemetry_runtime_producer()
5858
telemetry_evaluation_producer = telemetry_producer.get_telemetry_evaluation_producer()
5959

@@ -990,119 +990,118 @@ def test_localhost_e2e(self):
990990
def test_localhost_json_e2e(self):
991991
"""Instantiate a client with a JSON file and issue get_treatment() calls."""
992992
filename = os.path.join(os.path.dirname(__file__), 'files', 'split_changes_temp.json')
993-
factory = get_factory('localhost', config={'splitFile': filename})
994-
factory.block_until_ready()
995-
client = factory.client()
993+
self.factory = get_factory('localhost', config={'splitFile': filename})
994+
self.factory.block_until_ready(1)
995+
client = self.factory.client()
996996

997997
# Tests 1
998-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
998+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
999999
self._update_temp_file(splits_json['splitChange1_1'])
1000-
self._synchronize_now(factory)
1000+
self._synchronize_now()
10011001

1002-
assert sorted(factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
1002+
assert sorted(self.factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
10031003
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
10041004
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10051005

10061006
self._update_temp_file(splits_json['splitChange1_2'])
1007-
self._synchronize_now(factory)
1007+
self._synchronize_now()
10081008

1009-
assert sorted(factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
1009+
assert sorted(self.factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
10101010
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
10111011
assert client.get_treatment("key", "SPLIT_2", None) == 'off'
10121012

10131013
self._update_temp_file(splits_json['splitChange1_3'])
1014-
self._synchronize_now(factory)
1014+
self._synchronize_now()
10151015

1016-
assert factory.manager().split_names() == ["SPLIT_2"]
1016+
assert self.factory.manager().split_names() == ["SPLIT_2"]
10171017
assert client.get_treatment("key", "SPLIT_1", None) == 'control'
10181018
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10191019

10201020
# Tests 2
1021-
factory._storages['splits'].remove('SPLIT_1')
1022-
factory._storages['splits'].remove('SPLIT_2')
1023-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
1021+
self.factory._storages['splits'].remove('SPLIT_2')
1022+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
10241023
self._update_temp_file(splits_json['splitChange2_1'])
1025-
self._synchronize_now(factory)
1024+
self._synchronize_now()
10261025

1027-
assert factory.manager().split_names() == ["SPLIT_1"]
1026+
assert self.factory.manager().split_names() == ["SPLIT_1"]
10281027
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
10291028

10301029
# Tests 3
1031-
factory._storages['splits'].remove('SPLIT_1')
1032-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
1030+
self.factory._storages['splits'].remove('SPLIT_1')
1031+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
10331032
self._update_temp_file(splits_json['splitChange3_1'])
1034-
self._synchronize_now(factory)
1033+
self._synchronize_now()
10351034

1036-
assert factory.manager().split_names() == ["SPLIT_2"]
1035+
assert self.factory.manager().split_names() == ["SPLIT_2"]
10371036
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10381037

10391038
self._update_temp_file(splits_json['splitChange3_2'])
1040-
self._synchronize_now(factory)
1039+
self._synchronize_now()
10411040

1042-
assert factory.manager().split_names() == ["SPLIT_2"]
1041+
assert self.factory.manager().split_names() == ["SPLIT_2"]
10431042
assert client.get_treatment("key", "SPLIT_2", None) == 'off'
10441043

10451044
# Tests 4
1046-
factory._storages['splits'].remove('SPLIT_2')
1047-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
1045+
self.factory._storages['splits'].remove('SPLIT_2')
1046+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
10481047
self._update_temp_file(splits_json['splitChange4_1'])
1049-
self._synchronize_now(factory)
1048+
self._synchronize_now()
10501049

1051-
assert sorted(factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
1050+
assert sorted(self.factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
10521051
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
10531052
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10541053

10551054
self._update_temp_file(splits_json['splitChange4_2'])
1056-
self._synchronize_now(factory)
1055+
self._synchronize_now()
10571056

1058-
assert sorted(factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
1057+
assert sorted(self.factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
10591058
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
10601059
assert client.get_treatment("key", "SPLIT_2", None) == 'off'
10611060

10621061
self._update_temp_file(splits_json['splitChange4_3'])
1063-
self._synchronize_now(factory)
1062+
self._synchronize_now()
10641063

1065-
assert factory.manager().split_names() == ["SPLIT_2"]
1064+
assert self.factory.manager().split_names() == ["SPLIT_2"]
10661065
assert client.get_treatment("key", "SPLIT_1", None) == 'control'
10671066
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10681067

10691068
# Tests 5
1070-
factory._storages['splits'].remove('SPLIT_1')
1071-
factory._storages['splits'].remove('SPLIT_2')
1072-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
1069+
self.factory._storages['splits'].remove('SPLIT_1')
1070+
self.factory._storages['splits'].remove('SPLIT_2')
1071+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
10731072
self._update_temp_file(splits_json['splitChange5_1'])
1074-
self._synchronize_now(factory)
1073+
self._synchronize_now()
10751074

1076-
assert factory.manager().split_names() == ["SPLIT_2"]
1075+
assert self.factory.manager().split_names() == ["SPLIT_2"]
10771076
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10781077

10791078
self._update_temp_file(splits_json['splitChange5_2'])
1080-
self._synchronize_now(factory)
1079+
self._synchronize_now()
10811080

1082-
assert factory.manager().split_names() == ["SPLIT_2"]
1081+
assert self.factory.manager().split_names() == ["SPLIT_2"]
10831082
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10841083

10851084
# Tests 6
1086-
factory._storages['splits'].remove('SPLIT_2')
1087-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
1085+
self.factory._storages['splits'].remove('SPLIT_2')
1086+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._split_storage.set_change_number(-1)
10881087
self._update_temp_file(splits_json['splitChange6_1'])
1089-
self._synchronize_now(factory)
1088+
self._synchronize_now()
10901089

1091-
assert sorted(factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
1090+
assert sorted(self.factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
10921091
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
10931092
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
10941093

10951094
self._update_temp_file(splits_json['splitChange6_2'])
1096-
self._synchronize_now(factory)
1095+
self._synchronize_now()
10971096

1098-
assert sorted(factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
1097+
assert sorted(self.factory.manager().split_names()) == ["SPLIT_1", "SPLIT_2"]
10991098
assert client.get_treatment("key", "SPLIT_1", None) == 'off'
11001099
assert client.get_treatment("key", "SPLIT_2", None) == 'off'
11011100

11021101
self._update_temp_file(splits_json['splitChange6_3'])
1103-
self._synchronize_now(factory)
1102+
self._synchronize_now()
11041103

1105-
assert factory.manager().split_names() == ["SPLIT_2"]
1104+
assert self.factory.manager().split_names() == ["SPLIT_2"]
11061105
assert client.get_treatment("key", "SPLIT_1", None) == 'control'
11071106
assert client.get_treatment("key", "SPLIT_2", None) == 'on'
11081107

@@ -1111,7 +1110,7 @@ def _update_temp_file(self, json_body):
11111110
f.write(json.dumps(json_body))
11121111
f.close()
11131112

1114-
def _synchronize_now(self, factory):
1113+
def _synchronize_now(self):
11151114
filename = os.path.join(os.path.dirname(__file__), 'files', 'split_changes_temp.json')
1116-
factory._sync_manager._synchronizer._split_synchronizers._split_sync._filename = filename
1117-
factory._sync_manager._synchronizer._split_synchronizers._split_sync.synchronize_splits()
1115+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync._filename = filename
1116+
self.factory._sync_manager._synchronizer._split_synchronizers._split_sync.synchronize_splits()

0 commit comments

Comments
 (0)