polishing

Author: chillaq

splitio/storage/pluggable.py

@@ -486,7 +486,11 @@ def __init__(self, pluggable_adapter, sdk_metadata, prefix=None):
         :type sdk_metadata: splitio.client.util.SdkMetadata
         """
         self._pluggable_adapter = pluggable_adapter
-        self._sdk_metadata = sdk_metadata
+        self._sdk_metadata = {
+                                's': sdk_metadata.sdk_version,
+                                'n': sdk_metadata.instance_name,
+                                'i': sdk_metadata.instance_ip,
+                            }
         self._impressions_queue_key = 'SPLITIO.impressions'
         if prefix is not None:
             self._impressions_queue_key = prefix + "." + self._impressions_queue_key
@@ -505,12 +509,8 @@ def _wrap_impressions(self, impressions):
         for impression in impressions:
             if isinstance(impression, Impression):
                 to_store = {
-                    'm': {  # METADATA PORTION
-                        's': self._sdk_metadata.sdk_version,
-                        'n': self._sdk_metadata.instance_name,
-                        'i': self._sdk_metadata.instance_ip,
-                    },
-                    'i': {  # IMPRESSION PORTION
+                    'm': self._sdk_metadata,
+                    'i': {
                         'k': impression.matching_key,
                         'b': impression.bucketing_key,
                         'f': impression.feature_name,

tests/storage/test_pluggable.py

@@ -338,7 +338,11 @@ def setup_method(self):
 
     def test_init(self):
         assert(self.pluggable_imp_storage._impressions_queue_key == "myprefix.SPLITIO.impressions")
-        assert(self.pluggable_imp_storage._sdk_metadata == self.metadata)
+        assert(self.pluggable_imp_storage._sdk_metadata == {
+                                's': self.metadata.sdk_version,
+                                'n': self.metadata.instance_name,
+                                'i': self.metadata.instance_ip,
+                            })
 
         pluggable2 = PluggableImpressionsStorage(self.mock_adapter, self.metadata)
         assert(pluggable2._impressions_queue_key == "SPLITIO.impressions")