ensure syncall does not throw an exception

Author: mredolatti

CHANGES.txt

@@ -1,3 +1,6 @@
+8.3.1 (TBD)
+ - Fixed error handling when split server fails, so that it doesn't bring streaming down.
+
 8.3.0 (Nov 4, 2020)
  - Added local impressions deduping. Defaulting to optimized
  - Added support for the new Split streaming architecture. When enabled (default), the SDK will not poll for updates but instead receive notifications every time there's a change in your environments, allowing to process those much quicker. If disabled or in the event of an issue, the SDK will fallback to the known polling mechanism to provide a seamless experience.

splitio/sync/synchronizer.py

@@ -251,12 +251,13 @@ def sync_all(self):
         """Synchronize all split data."""
         try:
             self.synchronize_splits(None)
-            if not self._synchronize_segments():
-                _LOGGER.error('Failed syncing segments')
-                raise RuntimeError('Failed syncing segments')
-        except APIException as exc:
+        except APIException:
             _LOGGER.error('Failed syncing splits')
-            raise_from(APIException('Failed to sync splits'), exc)
+            _LOGGER.debug('Error: ', exc_info=True)
+
+        if not self._synchronize_segments():
+            _LOGGER.error('Failed syncing segments')
+            _LOGGER.debug('Error: ', exc_info=True)
 
     def shutdown(self, blocking):
         """

splitio/version.py

@@ -1 +1 @@
-__version__ = '8.3.0'
+__version__ = '8.3.1-rc1'

tests/sync/test_manager.py

@@ -45,8 +45,7 @@ def run(x):
         synchronizer = Synchronizer(synchronizers, split_tasks)
         manager = Manager(threading.Event(), synchronizer,  mocker.Mock(), False)
 
-        with pytest.raises(APIException):
-            manager.start()
+        manager.start()  # should not throw!
 
     def test_start_streaming_false(self, mocker):
         splits_ready_event = threading.Event()

tests/sync/test_synchronizer.py

@@ -35,8 +35,8 @@ def run(x):
 
         with pytest.raises(APIException):
             sychronizer.synchronize_splits(None)
-        with pytest.raises(APIException):
-            sychronizer.sync_all()
+
+        sychronizer.sync_all()  # sync_all should not throw!
 
     def test_sync_all_failed_segments(self, mocker):
         api = mocker.Mock()
@@ -55,8 +55,7 @@ def run(x, y):
                                                  mocker.Mock(), mocker.Mock(), mocker.Mock())
         sychronizer = Synchronizer(split_synchronizers, mocker.Mock(spec=SplitTasks))
 
-        with pytest.raises(RuntimeError):
-            sychronizer.sync_all()
+        sychronizer.sync_all()  # SyncAll should not throw!
         assert not sychronizer._synchronize_segments()
 
     splits = [{