removed producer mode methods

Author: chillaq

splitio/storage/pluggable.py

@@ -240,7 +240,7 @@ def update(self, segment_name, to_add, to_remove, change_number=None):
             if to_remove is not None:
                 self._pluggable_adapter.remove_items(self._prefix.format(segment_name=segment_name), to_remove)
             if change_number is not None:
-                self.set_change_number(segment_name, change_number)
+                self._pluggable_adapter.set(self._segment_till_prefix.format(segment_name=segment_name), change_number)
         except Exception:
             _LOGGER.error('Error updating segment storage')
             _LOGGER.debug('Error: ', exc_info=True)
@@ -254,11 +254,13 @@ def set_change_number(self, segment_name, change_number):
         :param change_number: change number
         :type segment_name: int
         """
-        try:
-            self._pluggable_adapter.set(self._segment_till_prefix.format(segment_name=segment_name), change_number)
-        except Exception:
-            _LOGGER.error('Error updating segment change number')
-            _LOGGER.debug('Error: ', exc_info=True)
+        pass
+        # TODO: To be added when producer mode is aupported
+#        try:
+#            self._pluggable_adapter.set(self._segment_till_prefix.format(segment_name=segment_name), change_number)
+#        except Exception:
+#            _LOGGER.error('Error updating segment change number')
+#            _LOGGER.debug('Error: ', exc_info=True)
 
     def get_change_number(self, segment_name):
         """
@@ -313,7 +315,7 @@ def get_segment_names(self):
 #            _LOGGER.debug('Error: ', exc_info=True)
 #            return None
 
-    def segment_contains(self, segment_name, key):
+    def segment_contains_key(self, segment_name, key):
         """
         Check if segment contains a key
 
@@ -332,19 +334,35 @@ def segment_contains(self, segment_name, key):
             _LOGGER.debug('Error: ', exc_info=True)
             return None
 
+    def segment_contains(self, segment_name, key):
+        """
+        Check if segment contains a key, added for backward compatibility as its implemented in Redis
+
+        :param segment_name: segment name
+        :type segment_name: str
+        :param key: key
+        :type key: str
+
+        :return: True if found, otherwise False
+        :rtype: bool
+        """
+        self.segment_contains_key(segment_name, key)
+
     def get_segment_keys_count(self):
         """
         Get count of all keys in segments.
 
         :return: keys count
         :rtype: int
         """
-        try:
-            return sum([self._pluggable_adapter.get_items_count(key) for key in self._pluggable_adapter.get_keys_by_prefix(self._prefix)])
-        except Exception:
-            _LOGGER.error('Error getting segment keys')
-            _LOGGER.debug('Error: ', exc_info=True)
-            return None
+        pass
+        # TODO: To be added when producer mode is aupported
+#        try:
+#            return sum([self._pluggable_adapter.get_items_count(key) for key in self._pluggable_adapter.get_keys_by_prefix(self._prefix)])
+#        except Exception:
+#            _LOGGER.error('Error getting segment keys')
+#            _LOGGER.debug('Error: ', exc_info=True)
+#            return None
 
     def get(self, segment_name):
         """
@@ -356,12 +374,14 @@ def get(self, segment_name):
         :return: segment object
         :rtype: splitio.models.segments.Segment
         """
-        try:
-            return segments.from_raw({'name': segment_name, 'added': list(self._pluggable_adapter.get(self._prefix.format(segment_name=segment_name))), 'removed': [], 'till': self._pluggable_adapter.get(self._segment_till_prefix.format(segment_name=segment_name))})
-        except Exception:
-            _LOGGER.error('Error getting segment')
-            _LOGGER.debug('Error: ', exc_info=True)
-            return None
+        pass
+        # TODO: To be added when producer mode is aupported
+#        try:
+#            return segments.from_raw({'name': segment_name, 'added': list(self._pluggable_adapter.get(self._prefix.format(segment_name=segment_name))), 'removed': [], 'till': self._pluggable_adapter.get(self._segment_till_prefix.format(segment_name=segment_name))})
+#        except Exception:
+#            _LOGGER.error('Error getting segment')
+#            _LOGGER.debug('Error: ', exc_info=True)
+#            return None
 
     def put(self, segment):
         """
@@ -370,10 +390,12 @@ def put(self, segment):
         :param segment: Segment to store.
         :type segment: splitio.models.segment.Segment
         """
-        try:
-            self._pluggable_adapter.add_items(self._prefix.format(segment_name=segment.name), list(segment.keys))
-            if segment.change_number is not None:
-                self._pluggable_adapter.set(self._segment_till_prefix.format(segment_name=segment.name), segment.change_number)
-        except Exception:
-            _LOGGER.error('Error updating segment storage')
-            _LOGGER.debug('Error: ', exc_info=True)
+        pass
+        # TODO: To be added when producer mode is aupported
+#       try:
+#            self._pluggable_adapter.add_items(self._prefix.format(segment_name=segment.name), list(segment.keys))
+#            if segment.change_number is not None:
+#                self._pluggable_adapter.set(self._segment_till_prefix.format(segment_name=segment.name), segment.change_number)
+#        except Exception:
+#            _LOGGER.error('Error updating segment storage')
+#            _LOGGER.debug('Error: ', exc_info=True)

tests/storage/test_pluggable.py

@@ -274,8 +274,9 @@ def test_update_change_number(self):
         self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
         assert(self.pluggable_segment_storage.get_change_number('segment1') == 123)
 
-        self.pluggable_segment_storage.set_change_number('segment1', 124)
-        assert(self.mock_adapter._keys['myprefix.SPLITIO.segment.segment1.till'] == 124)
+    # TODO: To be added when producer mode is implemented
+#        self.pluggable_segment_storage.set_change_number('segment1', 124)
+#        assert(self.mock_adapter._keys['myprefix.SPLITIO.segment.segment1.till'] == 124)
 
     def test_get_segment_names(self):
         self.mock_adapter._keys = {}
@@ -294,32 +295,35 @@ def test_get_segment_names(self):
     def test_segment_contains(self):
         self.mock_adapter._keys = {}
         self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
-        assert(self.pluggable_segment_storage.segment_contains('segment1', 'key1'))
+        assert(self.pluggable_segment_storage.segment_contains_key('segment1', 'key1'))
         assert(not self.pluggable_segment_storage.segment_contains('segment1', 'key5'))
 
-    def get_segment_keys_count(self):
-        self.mock_adapter._keys = {}
-        self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
-        self.pluggable_segment_storage.update('segment2', [], [], 123)
-        self.pluggable_segment_storage.update('segment3', ['key1', 'key5'], [], 123)
-        assert(self.pluggable_segment_storage.get_segment_keys_count() == 4)
+    # TODO: To be added when producer mode is implemented
+#    def get_segment_keys_count(self):
+#        self.mock_adapter._keys = {}
+#        self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
+#        self.pluggable_segment_storage.update('segment2', [], [], 123)
+#        self.pluggable_segment_storage.update('segment3', ['key1', 'key5'], [], 123)
+#        assert(self.pluggable_segment_storage.get_segment_keys_count() == 4)
 
-    def test_get(self):
-        self.mock_adapter._keys = {}
-        self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
-        segment = self.pluggable_segment_storage.get('segment1')
-        assert(segment.name == 'segment1')
-        assert(segment.keys == {'key1', 'key2'})
-        assert(segment.change_number == 123)
+    # TODO: To be added when producer mode is implemented
+#    def test_get(self):
+#        self.mock_adapter._keys = {}
+#        self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
+#        segment = self.pluggable_segment_storage.get('segment1')
+#        assert(segment.name == 'segment1')
+#        assert(segment.keys == {'key1', 'key2'})
+#        assert(segment.change_number == 123)
 
-    def test_put(self):
-        self.mock_adapter._keys = {}
-        self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
-        segment = self.pluggable_segment_storage.get('segment1')
-        segment._name = 'segment2'
-        segment._keys.add('key3')
-
-        self.pluggable_segment_storage.put(segment)
-        assert('myprefix.SPLITIO.segment.segment2' in self.mock_adapter._keys)
-        assert(self.mock_adapter._keys['myprefix.SPLITIO.segment.segment2'] == {'key1', 'key2', 'key3'})
-        assert(self.mock_adapter._keys['myprefix.SPLITIO.segment.segment2.till'] == 123)
+    # TODO: To be added when producer mode is implemented
+#    def test_put(self):
+#        self.mock_adapter._keys = {}
+#        self.pluggable_segment_storage.update('segment1', ['key1', 'key2'], [], 123)
+#        segment = self.pluggable_segment_storage.get('segment1')
+#        segment._name = 'segment2'
+#        segment._keys.add('key3')
+#
+#        self.pluggable_segment_storage.put(segment)
+#        assert('myprefix.SPLITIO.segment.segment2' in self.mock_adapter._keys)
+#        assert(self.mock_adapter._keys['myprefix.SPLITIO.segment.segment2'] == {'key1', 'key2', 'key3'})
+#        assert(self.mock_adapter._keys['myprefix.SPLITIO.segment.segment2.till'] == 123)