Skip to content

Commit ecd65cb

Browse files
committed
.
1 parent b89e5a3 commit ecd65cb

4 files changed

Lines changed: 11 additions & 8 deletions

File tree

splitio/push/sse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def build(self):
8080
class SSEClient(object):
8181
"""SSE Client implementation."""
8282

83-
_DEFAULT_HEADERS = {'Accept': 'text/event-stream'}
83+
_DEFAULT_HEADERS = {'accept': 'text/event-stream'}
8484
_EVENT_SEPARATORS = set([b'\n', b'\r\n'])
8585

8686
def __init__(self, callback):

tests/helpers/mockserver.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ def do_GET(self): #pylint:disable=invalid-name
7171
self.end_headers()
7272

7373
if self._req_queue is not None:
74-
self._req_queue.put(self.path)
74+
headers = dict(zip(self.headers.keys(), self.headers.values()))
75+
self._req_queue.put(Request('GET', self.path, headers, None))
7576

7677
def write_chunk(chunk):
7778
"""Write an event/chunk."""

tests/push/test_splitsse.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
from splitio.models.token import Token
88
from splitio.push.splitsse import SplitSSEClient
99
from splitio.push.sse import SSEEvent
10-
11-
from .mockserver import SSEMockServer
10+
from tests.helpers.mockserver import SSEMockServer
1211

1312

1413
class SSEClientTests(object):
@@ -41,7 +40,9 @@ def handler(event):
4140
time.sleep(1)
4241
client.stop()
4342

44-
assert request_queue.get() == '/event-stream?v=1.1&accessToken=some&channels=chan1,[?occupancy=metrics.publishers]chan2'
43+
request = request_queue.get(1)
44+
assert request.path == '/event-stream?v=1.1&accessToken=some&channels=chan1,[?occupancy=metrics.publishers]chan2'
45+
assert request.headers['accept'] == 'text/event-stream'
4546

4647
assert events == [
4748
SSEEvent('1', 'message', '1', 'a'),
@@ -74,8 +75,9 @@ def handler(event):
7475
with pytest.raises(Exception):
7576
client.stop()
7677

77-
assert request_queue.get() == ('/event-stream?v=1.1&accessToken=some'
78-
'&channels=chan1,[?occupancy=metrics.publishers]chan2')
78+
request = request_queue.get(1)
79+
assert request.path == '/event-stream?v=1.1&accessToken=some&channels=chan1,[?occupancy=metrics.publishers]chan2'
80+
assert request.headers['accept'] == 'text/event-stream'
7981

8082
server.publish(SSEMockServer.VIOLENT_REQUEST_END)
8183
server.stop()

tests/push/test_sse.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import threading
55
import pytest
66
from splitio.push.sse import SSEClient, SSEEvent
7-
from .mockserver import SSEMockServer
7+
from tests.helpers.mockserver import SSEMockServer
88

99

1010
class SSEClientTests(object):

0 commit comments

Comments
 (0)