Skip to content

Commit 727e436

Browse files
removed 'commit_hash' env var, that is not used anymore
1 parent 0cb0a2b commit 727e436

4 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
run: npm run test -- --coverage
4444

4545
- name: npm build
46-
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") BUILD_COMMIT=${{ github.sha }} npm run build
46+
run: BUILD_BRANCH=$(echo "${GITHUB_REF#refs/heads/}") npm run build
4747

4848
- name: Set VERSION env
4949
run: echo "VERSION=$(cat package.json | jq -r .version)" >> $GITHUB_ENV

CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
1.9.1 (September XX, 2023)
2+
- Updated linter and other dependencies for vulnerability fixes.
3+
14
1.9.0 (July 18, 2023)
25
- Updated some transitive dependencies for vulnerability fixes.
36
- Updated @splitsoftware/splitio package to version 10.23.0 that includes:

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"scripts": {
2020
"build:cjs": "rimraf lib/* types/* && tsc -m commonjs --outDir lib -d true --declarationDir types",
2121
"build:esm": "rimraf es/* && tsc",
22-
"build:umd": "rimraf umd/* && webpack --config webpack.dev.js --env branch=$BUILD_BRANCH --env commit_hash=$BUILD_COMMIT && webpack --config webpack.prod.js --env branch=$BUILD_BRANCH --env commit_hash=$BUILD_COMMIT",
22+
"build:umd": "rimraf umd/* && webpack --config webpack.dev.js --env branch=$BUILD_BRANCH && webpack --config webpack.prod.js --env branch=$BUILD_BRANCH",
2323
"build": "npm run build:cjs && npm run build:esm && npm run build:umd",
2424
"postbuild": "replace 'REACT_SDK_VERSION_NUMBER' $npm_package_version ./lib/constants.js ./es/constants.js ./umd -r",
2525
"check": "npm run check:lint && npm run check:types",

src/SplitClient.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export class SplitComponent extends React.Component<IUpdateProps & { factory: Sp
2222

2323
// Using `getDerivedStateFromProps` since the state depends on the status of the client in props, which might change over time.
2424
// It could be avoided by removing the client and its status from the component state.
25-
// But it implies to have another instance property to use instead of the state, because we need a unique reference value for SplitContext.Producer
25+
// But it implies to have another instance property to use instead of the state, because we need a unique reference value for SplitContext.Provider
2626
static getDerivedStateFromProps(props: ISplitClientProps & { factory: SplitIO.IBrowserSDK | null, client: SplitIO.IBrowserClient | null }, state: ISplitContextValues) {
2727
const { client, factory, attributes } = props;
2828
// initAttributes can be called in the `render` method too, but it is better here for separation of concerns

0 commit comments

Comments
 (0)