Merge pull request #166 from splitio/hooks_options_object

Options object for hooks arguments

Author: EmilianoSanchez

package-lock.json

@@ -159,7 +159,7 @@ describe.each([
     </SplitTreatments>
   ),
   ({ names, attributes }) => {
-    useSplitTreatments(names, attributes);
+    useSplitTreatments({ names, attributes });
     renderTimes++;
     return null;
   }

src/__tests__/SplitTreatments.test.tsx

@@ -1,100 +1,23 @@
-import React from 'react';
-import { render } from '@testing-library/react';
-
 /** Mocks */
-import { mockSdk } from './testUtils/mockSplitSdk';
-jest.mock('@splitsoftware/splitio/client', () => {
-  return { SplitFactory: mockSdk() };
-});
-import { SplitFactory as SplitSdk } from '@splitsoftware/splitio/client';
-import { sdkBrowser } from './testUtils/sdkConfigs';
+const useSplitClientMock = jest.fn();
+jest.mock('../useSplitClient', () => ({
+  useSplitClient: useSplitClientMock
+}));
 
 /** Test target */
-import { SplitFactory } from '../SplitFactory';
-import { SplitClient } from '../SplitClient';
 import { useClient } from '../useClient';
-import { testAttributesBinding, TestComponentProps } from './testUtils/utils';
 
 describe('useClient', () => {
 
-  test('returns the main client from the context updated by SplitFactory.', () => {
-    const outerFactory = SplitSdk(sdkBrowser);
-    let client;
-    render(
-      <SplitFactory factory={outerFactory} >
-        {React.createElement(() => {
-          client = useClient();
-          return null;
-        })}
-      </SplitFactory>
-    );
-    expect(client).toBe(outerFactory.client());
-  });
-
-  test('returns the client from the context updated by SplitClient.', () => {
-    const outerFactory = SplitSdk(sdkBrowser);
-    let client;
-    render(
-      <SplitFactory factory={outerFactory} >
-        <SplitClient splitKey='user2' >
-          {React.createElement(() => {
-            client = useClient();
-            return null;
-          })}
-        </SplitClient>
-      </SplitFactory>
-    );
-    expect(client).toBe(outerFactory.client('user2'));
-  });
-
-  test('returns a new client from the factory at Split context given a splitKey.', () => {
-    const outerFactory = SplitSdk(sdkBrowser);
-    let client;
-    render(
-      <SplitFactory factory={outerFactory} >
-        {React.createElement(() => {
-          (outerFactory.client as jest.Mock).mockClear();
-          client = useClient('user2', 'user');
-          return null;
-        })}
-      </SplitFactory>
-    );
-    expect(outerFactory.client as jest.Mock).toBeCalledWith('user2', 'user');
-    expect(outerFactory.client as jest.Mock).toHaveReturnedWith(client);
-  });
-
-  test('returns null if invoked outside Split context.', () => {
-    let client;
-    let sharedClient;
-    render(
-      React.createElement(() => {
-        client = useClient();
-        sharedClient = useClient('user2', 'user');
-        return null;
-      })
-    );
-    expect(client).toBe(null);
-    expect(sharedClient).toBe(null);
-  });
-
-  test('attributes binding test with utility', (done) => {
-
-    // eslint-disable-next-line react/prop-types
-    const InnerComponent = ({ splitKey, attributesClient, testSwitch}) => {
-      useClient(splitKey, 'user', attributesClient);
-      testSwitch(done, splitKey);
-      return null;
-    };
+  test('calls useSplitClient with the correct arguments and returns the client.', () => {
+    const attributes = { someAttribute: 'someValue' };
+    const client = 'client';
+    useSplitClientMock.mockReturnValue({ client, isReady: false });
 
-    function Component({ attributesFactory, attributesClient, splitKey, testSwitch, factory }: TestComponentProps) {
-      return (
-        <SplitFactory factory={factory} attributes={attributesFactory} >
-          <InnerComponent splitKey={splitKey} attributesClient={attributesClient} testSwitch={testSwitch} />
-        </SplitFactory>
-      );
-    }
+    expect(useClient('someKey', 'someTrafficType', attributes)).toBe(client);
 
-    testAttributesBinding(Component);
+    expect(useSplitClientMock).toHaveBeenCalledTimes(1);
+    expect(useSplitClientMock).toHaveBeenCalledWith({ splitKey: 'someKey', trafficType: 'someTrafficType', attributes });
   });
 
 });