Merge pull request #144 from splitio/linter_update

Update `prefer-const` linter rule

Author: EmilianoSanchez

.eslintrc.js

@@ -35,6 +35,9 @@ module.exports = {
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-unused-vars': ['warn', { 'argsIgnorePattern': '^_' }],
+    'prefer-const': ['error', {
+      'destructuring': 'all'
+    }]
   },
   'overrides': [{
     'files': ['src/**/*.ts', 'src/**/*.tsx'],

src/__tests__/SplitClient.test.tsx

@@ -1,5 +1,5 @@
 import React from 'react';
-import { render, RenderResult, act } from '@testing-library/react';
+import { render, act } from '@testing-library/react';
 
 /** Mocks and test utils */
 import { mockSdk, Event, assertNoListeners, clientListenerCount } from './testUtils/mockSplitSdk';
@@ -263,8 +263,7 @@ describe('SplitClient', () => {
   test(`passes a new client if re-rendered with a different splitKey.
         Only updates the state if the new client triggers an event, but not the previous one.`, (done) => {
     const outerFactory = SplitSdk(sdkBrowser);
-    let renderTimes = 0; // eslint-disable-next-line prefer-const
-    let wrapper: RenderResult;
+    let renderTimes = 0;
 
     class InnerComponent extends React.Component<any, { splitKey: string }> {
 
@@ -294,6 +293,7 @@ describe('SplitClient', () => {
                           expect(renderTimes).toBe(6);
 
                           // check that outerFactory's clients have no event listeners
+                          // eslint-disable-next-line no-use-before-define
                           wrapper.unmount();
                           assertNoListeners(outerFactory);
                           done();
@@ -352,7 +352,7 @@ describe('SplitClient', () => {
       }
     }
 
-    wrapper = render(
+    const wrapper = render(
       <SplitFactory factory={outerFactory} >
         <InnerComponent />
       </SplitFactory>);

src/useClient.ts

@@ -13,7 +13,7 @@ import { getSplitSharedClient, checkHooks, initAttributes } from './utils';
  */
 const useClient = (key?: SplitIO.SplitKey, trafficType?: string, attributes?: SplitIO.Attributes): SplitIO.IBrowserClient | null => {
   if (!checkHooks(ERROR_UC_NO_USECONTEXT)) return null;
-  // eslint-disable-next-line prefer-const
+
   let { factory, client } = React.useContext(SplitContext);
   if (key && factory) {
     client = getSplitSharedClient(factory, key, trafficType, attributes);

types/SplitTreatments.d.ts

@@ -7,9 +7,9 @@ import { ISplitTreatmentsProps } from './types';
  * @see {@link https://help.split.io/hc/en-us/articles/360020448791-JavaScript-SDK#get-treatments-with-configurations}
  */
 declare class SplitTreatments extends React.Component<ISplitTreatmentsProps> {
-  private logWarning?;
-  private evaluateFeatureFlags;
-  render(): JSX.Element;
-  componentDidMount(): void;
+    private logWarning?;
+    private evaluateFeatureFlags;
+    render(): JSX.Element;
+    componentDidMount(): void;
 }
 export default SplitTreatments;