Skip to content

Commit 40fc8f0

Browse files
committed
rolled back include in events manager
1 parent df3f78e commit 40fc8f0

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

lib/splitclient-rb/engine/events/events_manager.rb

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@ module SplitIoClient
44
module Engine
55
module Events
66
class EventsManager
7-
include SplitIoClient::Engine::Models
8-
97
def initialize(events_manager_config, events_delivery, config)
108
@manager_config = events_manager_config
119
@events_delivery = events_delivery
@@ -20,15 +18,15 @@ def register(sdk_event, event_handler)
2018

2119
@mutex.synchronize do
2220
# SDK ready already fired
23-
if sdk_event == SdkEvent::SDK_READY && event_already_triggered(sdk_event)
24-
@active_subscriptions[sdk_event] = EventActiveSubscriptions.new(true, event_handler)
21+
if sdk_event == Engine::Models::SdkEvent::SDK_READY && event_already_triggered(sdk_event)
22+
@active_subscriptions[sdk_event] = Engine::Models::EventActiveSubscriptions.new(true, event_handler)
2523
@config.logger.debug('EventsManager: Firing SDK_READY event for new subscription') if @config.debug_enabled
2624
fire_sdk_event(sdk_event, nil)
2725
return
2826
end
2927

3028
@config.logger.debug("EventsManager: Register event: #{sdk_event}") if @config.debug_enabled
31-
@active_subscriptions[sdk_event] = EventActiveSubscriptions.new(false, event_handler)
29+
@active_subscriptions[sdk_event] = Engine::Models::EventActiveSubscriptions.new(false, event_handler)
3230
end
3331
end
3432

@@ -52,7 +50,7 @@ def notify_internal_event(sdk_internal_event, event_metadata)
5250
# if client is not subscribed to SDK_READY
5351
if check_if_register_needed(sorted_event)
5452
@config.logger.debug('EventsManager: Registering SDK_READY event as fired') if @config.debug_enabled
55-
@active_subscriptions[SdkEvent::SDK_READY] = EventActiveSubscriptions.new(true, nil)
53+
@active_subscriptions[Engine::Models::SdkEvent::SDK_READY] = Engine::Models::EventActiveSubscriptions.new(true, nil)
5654
end
5755
end
5856
end
@@ -68,7 +66,7 @@ def destroy
6866
private
6967

7068
def check_if_register_needed(sorted_event)
71-
sorted_event == SdkEvent::SDK_READY &&
69+
sorted_event == Engine::Models::SdkEvent::SDK_READY &&
7270
get_event_handler(sorted_event).nil? &&
7371
!@active_subscriptions.include?(sorted_event)
7472
end
@@ -112,15 +110,15 @@ def get_event_handler(sdk_event)
112110
end
113111

114112
def get_sdk_event_if_applicable(sdk_internal_event)
115-
final_sdk_event = ValidSdkEvent.new(nil, false)
113+
final_sdk_event = Engine::Models::ValidSdkEvent.new(nil, false)
116114

117115
events_to_fire = []
118116
require_any_sdk_event = check_require_any(sdk_internal_event)
119117
if require_any_sdk_event.valid
120118
if (!event_already_triggered(require_any_sdk_event.sdk_event) &&
121119
execution_limit(require_any_sdk_event.sdk_event) == 1) ||
122120
execution_limit(require_any_sdk_event.sdk_event) == -1
123-
final_sdk_event = ValidSdkEvent.new(
121+
final_sdk_event = Engine::Models::ValidSdkEvent.new(
124122
require_any_sdk_event.sdk_event,
125123
check_prerequisites(require_any_sdk_event.sdk_event) &&
126124
check_suppressed_by(require_any_sdk_event.sdk_event)
@@ -180,10 +178,10 @@ def execution_limit(sdk_event)
180178
end
181179

182180
def check_require_any(sdk_internal_event)
183-
valid_sdk_event = ValidSdkEvent.new(nil, false)
181+
valid_sdk_event = Engine::Models::ValidSdkEvent.new(nil, false)
184182
@manager_config.require_any.each do |name, val|
185183
if val.include?(sdk_internal_event)
186-
valid_sdk_event = ValidSdkEvent.new(name, true)
184+
valid_sdk_event = Engine::Models::ValidSdkEvent.new(name, true)
187185
return valid_sdk_event
188186
end
189187
end

0 commit comments

Comments
 (0)