polish

Author: Bilal Al

lib/splitclient-rb/engine/matchers/between_semver_matcher.rb

@@ -16,7 +16,7 @@ def initialize(attribute, start_value, end_value, logger, validator)
     end
 
     def match?(args)
-      return false if !verify_semver_arg?(args, "BetweenSemverMatcher")
+      return false unless verify_semver_arg?(args, 'BetweenSemverMatcher')
 
       value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
       unless !value_to_match.nil? && !@semver_start.nil? && !@semver_end.nil?

lib/splitclient-rb/engine/matchers/equal_to_semver_matcher.rb

@@ -15,10 +15,10 @@ def initialize(attribute, string_value, logger, validator)
     end
 
     def match?(args)
-      return false if !verify_semver_arg?(args, "EqualsToSemverMatcher")
+      return false unless verify_semver_arg?(args, 'EqualsToSemverMatcher')
 
       value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
-      return false if !check_semver_value_to_match(value_to_match, MATCHER_TYPE)
+      return false unless check_semver_value_to_match(value_to_match, MATCHER_TYPE)
 
       matches = (@semver.version == value_to_match.version)
       @logger.debug("[EqualsToSemverMatcher] #{value_to_match} matches -> #{matches}")

lib/splitclient-rb/engine/matchers/greater_than_or_equal_to_semver_matcher.rb

@@ -15,10 +15,10 @@ def initialize(attribute, string_value, logger, validator)
     end
 
     def match?(args)
-      return false if !verify_semver_arg?(args, "GreaterThanOrEqualsToSemverMatcher")
+      return false unless verify_semver_arg?(args, 'GreaterThanOrEqualsToSemverMatcher')
 
       value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
-      return false if !check_semver_value_to_match(value_to_match, MATCHER_TYPE)
+      return false unless check_semver_value_to_match(value_to_match, MATCHER_TYPE)
 
       matches = [0, 1].include?(value_to_match.compare(@semver))
       @logger.debug("[GreaterThanOrEqualsToSemverMatcher] #{value_to_match} matches -> #{matches}")

lib/splitclient-rb/engine/matchers/in_list_semver_matcher.rb

@@ -15,7 +15,7 @@ def initialize(attribute, list_value, logger, validator)
     end
 
     def match?(args)
-      return false if !verify_semver_arg?(args, "InListSemverMatcher")
+      return false unless verify_semver_arg?(args, 'InListSemverMatcher')
 
       value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
       unless !value_to_match.nil? && @semver_list.all? { |n| !n.nil? }

lib/splitclient-rb/engine/matchers/less_than_or_equal_to_semver_matcher.rb

@@ -15,10 +15,10 @@ def initialize(attribute, string_value, logger, validator)
     end
 
     def match?(args)
-      return false if !verify_semver_arg?(args, "LessThanOrEqualsToSemverMatcher")
+      return false unless verify_semver_arg?(args, 'LessThanOrEqualsToSemverMatcher')
 
       value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
-      return false if !check_semver_value_to_match(value_to_match, MATCHER_TYPE)
+      return false unless check_semver_value_to_match(value_to_match, MATCHER_TYPE)
 
       matches = [0, -1].include?(value_to_match.compare(@semver))
       @logger.debug("[LessThanOrEqualsToSemverMatcher] #{value_to_match} matches -> #{matches}")