polish

Author: Bilal Al

lib/splitclient-rb/engine/matchers/between_semver_matcher.rb

@@ -19,7 +19,7 @@ def match?(args)
       @logger.debug('[BetweenSemverMatcher] evaluating value and attributes.')
       return false unless @validator.valid_matcher_arguments(args)
 
-      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym],  @logger)
+      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
       unless !value_to_match.nil? && !@semver_start.nil? && !@semver_end.nil?
         @logger.error('betweenStringMatcherData is required for BETWEEN_SEMVER matcher type')
         return false

lib/splitclient-rb/engine/matchers/equal_to_semver_matcher.rb

@@ -18,7 +18,7 @@ def match?(args)
       @logger.debug('[EqualsToSemverMatcher] evaluating value and attributes.')
       return false unless @validator.valid_matcher_arguments(args)
 
-      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym],  @logger)
+      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
       unless !value_to_match.nil? && !@semver.nil?
         @logger.error('stringMatcherData is required for EQUAL_TO_SEMVER matcher type')
         return false

lib/splitclient-rb/engine/matchers/greater_than_or_equal_to_semver_matcher.rb

@@ -18,7 +18,7 @@ def match?(args)
       @logger.debug('[GreaterThanOrEqualsToSemverMatcher] evaluating value and attributes.')
       return false unless @validator.valid_matcher_arguments(args)
 
-      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym],  @logger)
+      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
       unless !value_to_match.nil? && !@semver.nil?
         @logger.error('stringMatcherData is required for GREATER_THAN_OR_EQUAL_TO_SEMVER matcher type')
         return false

lib/splitclient-rb/engine/matchers/less_than_or_equal_to_semver_matcher.rb

@@ -18,7 +18,7 @@ def match?(args)
       @logger.debug('[LessThanOrEqualsToSemverMatcher] evaluating value and attributes.')
       return false unless @validator.valid_matcher_arguments(args)
 
-      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym],  @logger)
+      value_to_match = SplitIoClient::Semver.build(args[:attributes][@attribute.to_sym], @logger)
       unless !value_to_match.nil? && !@semver.nil?
         @logger.error('stringMatcherData is required for LESS_THAN_OR_EQUAL_TO_SEMVER matcher type')
         return false

lib/splitclient-rb/engine/matchers/semver.rb

@@ -27,7 +27,10 @@ def initialize(version)
     # @return [type] Semver instance
     def self.build(version, logger)
       new(version)
-    rescue StandardError, NoMethodError => e
+    rescue NoMethodError => e
+      logger.error("Failed to parse Semver data, incorrect data type:  #{e}")
+      nil
+    rescue StandardError => e
       logger.error("Failed to parse Semver data:  #{e}")
       nil
     end