fixed spec

Author: sanzmauro

lib/splitclient-rb/cache/repositories/splits_repository.rb

@@ -5,7 +5,7 @@ module Cache
     module Repositories
       class SplitsRepository < Repository
         attr_reader :adapter
-        DEFAULT_CONDITIONS_TEMPLATE =   {
+        DEFAULT_CONDITIONS_TEMPLATE = [{
           conditionType: "ROLLOUT",
           matcherGroup: {
               combiner: "AND",
@@ -30,7 +30,7 @@ class SplitsRepository < Repository
               }
           ],
           label: "unsupported matcher type"
-      }
+      }]
         def initialize(config, flag_sets_repository, flag_set_filter)
           super(config)
           @tt_cache = {}
@@ -182,7 +182,7 @@ def add_feature_flag(split)
 
           if check_undefined_matcher(split)
             @config.logger.warn("Feature Flag #{split[:name]} has undefined matcher, setting conditions to default template.")
-            split[:conditions] = [SplitsRepository::DEFAULT_CONDITIONS_TEMPLATE]
+            split[:conditions] = SplitsRepository::DEFAULT_CONDITIONS_TEMPLATE
           end
           if !split[:sets].nil?
             for flag_set in split[:sets]

spec/cache/repositories/splits_repository_spec.rb

@@ -127,28 +127,49 @@
         }]
       }
       repository.update([split], [], -1)
-      expect(repository.get_split('corge')[:conditions]).to eq [SplitIoClient::Cache::Repositories::SplitsRepository::DEFAULT_CONDITIONS_TEMPLATE]
+      expect(repository.get_split('corge')[:conditions]).to eq SplitIoClient::Cache::Repositories::SplitsRepository::DEFAULT_CONDITIONS_TEMPLATE
 
       # test with multiple conditions
-      split[:conditions] .append({
-        partitions: [
-            {treatment: 'on', size: 25},
-            {treatment: 'off', size: 75}
-        ],
-        contitionType: 'WHITELIST',
-        label: 'some_other_label',
-        matcherGroup: {
-            matchers: [
-                {
-                    matcherType: 'ALL_KEYS',
-                    negate: false,
-                }
+      split2 = {
+        name: 'corge2',
+        trafficTypeName: 'tt_name_5',
+        conditions: [
+          {
+              partitions: [
+                  {treatment: 'on', size: 50},
+                  {treatment: 'off', size: 50}
+              ],
+              contitionType: 'WHITELIST',
+              label: 'some_label',
+              matcherGroup: {
+                  matchers: [
+                      {
+                          matcherType: 'UNDEFINED',
+                          whitelistMatcherData: {
+                              whitelist: ['k1', 'k2', 'k3']
+                          },
+                          negate: false,
+                      }
+                  ],
+                  combiner: 'AND'
+              }
+          },
+          {
+            partitions: [
+              {treatment: 'on', size: 25},
+              {treatment: 'off', size: 75}
             ],
-            combiner: 'AND'
+            contitionType: 'WHITELIST',
+            label: 'some_other_label',
+            matcherGroup: {
+              matchers: [{matcherType: 'ALL_KEYS', negate: false}],
+              combiner: 'AND'
+            }
+          }]
         }
-      })
-      repository.update([split], [], -1)
-      expect(repository.get_split('corge')[:conditions]).to eq [SplitIoClient::Cache::Repositories::SplitsRepository::DEFAULT_CONDITIONS_TEMPLATE]
+
+      repository.update([split2], [], -1)
+      expect(repository.get_split('corge2')[:conditions]).to eq SplitIoClient::Cache::Repositories::SplitsRepository::DEFAULT_CONDITIONS_TEMPLATE
     end
   end