added version length check for compare

Author: Bilal Al

lib/splitclient-rb/engine/matchers/semver.rb

@@ -63,7 +63,10 @@ def compare(to_compare)
       return compare_attributes(to_compare) if compare_attributes(to_compare) != 0
 
       # Compare pre-release versions lexically
-      compare_pre_release(to_compare)
+      return compare_pre_release(to_compare) if compare_pre_release(to_compare) != 0
+
+      # compare length of version
+      compare_vars(@version.length, to_compare.version.length)
     end
 
     private

spec/engine/matchers/semver_spec.rb

@@ -4,23 +4,28 @@
 describe SplitIoClient::Semver do
   let(:valid_versions) do
     CSV.parse(File.read(File.expand_path(File.join(File.dirname(__FILE__),
-                                         '../../test_data/splits/semver/valid-semantic-versions.csv'))))
+                                         '../../test_data/splits/semver/valid-semantic-versions.csv'))), headers: true)
   end
   let(:invalid_versions) do
     CSV.parse(File.read(File.expand_path(File.join(File.dirname(__FILE__),
-                                         '../../test_data/splits/semver/invalid-semantic-versions.csv'))))
+                                         '../../test_data/splits/semver/invalid-semantic-versions.csv'))), headers: true)
   end
   let(:equal_to_versions) do
     CSV.parse(File.read(File.expand_path(File.join(File.dirname(__FILE__),
-                                         '../../test_data/splits/semver/equal-to-semver.csv'))))
+                                         '../../test_data/splits/semver/equal-to-semver.csv'))), headers: true)
+  end
+
+  let(:between_versions) do
+    CSV.parse(File.read(File.expand_path(File.join(File.dirname(__FILE__),
+                                         '../../test_data/splits/semver/between-semver.csv'))), headers: true)
   end
 
   let(:logger) { Logger.new('/dev/null') }
 
   context 'check versions' do
     it 'accept valid versions' do
       for i in (0..valid_versions.length-1)
-        expect(described_class.build(valid_versions[i][0], logger)).should_not be_nil
+        expect(described_class.build(valid_versions[i][0], logger)).not_to be_nil
       end
     end
     it 'reject invalid versions' do
@@ -39,12 +44,26 @@
         expect(described_class.build(valid_versions[i][1], logger).compare(described_class.build(valid_versions[i][1], logger))).to eq(0)
       end
       for i in (1..equal_to_versions.length-1)
-        if valid_versions[i][2]
-          expect(described_class.build(valid_versions[i][0], logger).compare(described_class.build(valid_versions[i][1], logger))).to eq(0)
+        if equal_to_versions[i][2]=='true'
+          expect(described_class.build(equal_to_versions[i][0], logger).compare(described_class.build(equal_to_versions[i][1], logger))).to eq(0)
         else
-          expect(described_class.build(valid_versions[i][0], logger).compare(described_class.build(valid_versions[i][1], logger))).not_to eq(0)
+          expect(described_class.build(equal_to_versions[i][0], logger).compare(described_class.build(equal_to_versions[i][1], logger))).not_to eq(0)
         end
       end
+      for i in (1..between_versions.length-1)
+        sem1 = described_class.build(between_versions[i][0], logger)
+        sem2 = described_class.build(between_versions[i][2], logger)
+        to_check = described_class.build(between_versions[i][1], logger)
+        if between_versions[i][3]=='true'
+          expect(sem1.compare(to_check)).to eq(-1)
+          expect(sem2.compare(to_check)).to eq(1)
+        else
+          compare1 = sem1.compare(to_check)
+          compare2 = sem2.compare(to_check)
+          expect(compare1 == -1 && compare2 == 1).to eq(false)
+        end
+      end
+
     end
   end
 end