polish

Author: chillaq

lib/splitclient-rb/cache/fetchers/split_fetcher.rb

@@ -22,7 +22,7 @@ def call
           splits_thread
         end
 
-        def fetch_splits(fetch_options = { cache_control_headers: false, till: nil, till_rbs: nil })
+        def fetch_splits(fetch_options = { cache_control_headers: false, till: nil })
           @semaphore.synchronize do
             data = splits_since(@splits_repository.get_change_number, @rule_based_segments_repository.get_change_number, fetch_options)
 
@@ -57,7 +57,7 @@ def splits_thread
           end
         end
 
-        def splits_since(since, since_rbs, fetch_options = { cache_control_headers: false, till: nil, till_rbs: nil })
+        def splits_since(since, since_rbs, fetch_options = { cache_control_headers: false, till: nil })
           splits_api.since(since, since_rbs, fetch_options)
         end
 

lib/splitclient-rb/engine/api/splits.rb

@@ -12,13 +12,12 @@ def initialize(api_key, config, telemetry_runtime_producer)
         @flag_sets_filter = @config.flag_sets_filter
       end
 
-      def since(since, since_rbs, fetch_options = { cache_control_headers: false, till: nil, till_rbs: nil, sets: nil})
+      def since(since, since_rbs, fetch_options = { cache_control_headers: false, till: nil, sets: nil})
         start = Time.now
 
         params = { s: SplitIoClient::Spec::FeatureFlags::SPEC_VERSION, since: since, rbSince: since_rbs }
         params[:sets] = @flag_sets_filter.join(",") unless @flag_sets_filter.empty?
         params[:till] = fetch_options[:till] unless fetch_options[:till].nil?
-        params[:till_rbs] = fetch_options[:till_rbs] unless fetch_options[:till_rbs].nil?
         @config.logger.debug("Fetching from splitChanges with #{params}: ")
         response = get_api("#{@config.base_uri}/splitChanges", @api_key, params, fetch_options[:cache_control_headers])
         if response.status == 414

spec/engine/api/splits_spec.rb

@@ -52,7 +52,7 @@
               })
         .to_return(status: 200, body: splits)
 
-      fetch_options = { cache_control_headers: false, till: nil, till_rbs: nil, sets: ['set_1','set_2'] }
+      fetch_options = { cache_control_headers: false, till: nil, sets: ['set_1','set_2'] }
       returned_splits = splits_api.since(-1, -1, fetch_options)
       expect(returned_splits[:segment_names]).to eq(Set.new(%w[demo employees]))
 
@@ -72,7 +72,7 @@
               })
         .to_return(status: 414, body: splits)
 
-      fetch_options = { cache_control_headers: false, till: nil, till_rbs: nil, sets: ['set_1','set_2'] }
+      fetch_options = { cache_control_headers: false, till: nil, sets: ['set_1','set_2'] }
       captured = 0
       begin
         returned_splits = splits_api.since(-1, -1, fetch_options)
@@ -126,7 +126,7 @@
               })
         .to_return(status: 200, body: splits)
 
-      fetch_options = { cache_control_headers: false, till: 123_123, till_rbs: nil, sets: nil }
+      fetch_options = { cache_control_headers: false, till: 123_123, sets: nil }
       returned_splits = splits_api.since(-1, -1, fetch_options)
       expect(returned_splits[:segment_names]).to eq(Set.new(%w[demo employees]))
 
@@ -147,7 +147,7 @@
               })
         .to_return(status: 200, body: splits)
 
-      fetch_options = { cache_control_headers: true, till: nil, till_rbs: nil, sets: nil }
+      fetch_options = { cache_control_headers: true, till: nil, sets: nil }
       returned_splits = splits_api.since(-1, -1, fetch_options)
       expect(returned_splits[:segment_names]).to eq(Set.new(%w[demo employees]))