Skip to content

Commit a2ce544

Browse files
committed
fix sse issue
1 parent b7013d4 commit a2ce544

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

lib/splitclient-rb/engine/matchers/rule_based_segment_matcher.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ def match?(args)
2828
key = update_key(args)
2929
return false if rule_based_segment[:excluded][:keys].include?(key)
3030

31-
return false unless check_excluded_segments(rule_based_segment)
31+
return false unless check_excluded_segments(rule_based_segment, key, args)
3232

3333
matches = false
3434
rule_based_segment[:conditions].each do |c|
@@ -44,15 +44,15 @@ def match?(args)
4444

4545
private
4646

47-
def check_excluded_segments(rule_based_segment)
47+
def check_excluded_segments(rule_based_segment, key, args)
4848
rule_based_segment[:excluded][:segments].each do |segment|
4949
return false if segment[:type] == 'standard' && @segments_repository.in_segment?(segment[:name], key)
5050

5151
return false if segment[:type] == 'rule-based' && match_rbs(
5252
@rule_based_segments_repository.get_rule_based_segment(segment[:name]), args
5353
)
5454
end
55-
True
55+
true
5656
end
5757

5858
def update_key(args)

lib/splitclient-rb/helpers/repository_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def self.update_feature_flag_repository(feature_flag_repository, feature_flags,
1313
next
1414
end
1515

16-
feature_flag = self.check_impressions_disabled(feature_flag, config)
16+
feature_flag = check_impressions_disabled(feature_flag, config)
1717

1818
config.logger.debug("storing feature flag (#{feature_flag[:name]})") if config.debug_enabled
1919
to_add.push(feature_flag)

lib/splitclient-rb/sse/notification_processor.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def process(incoming_notification)
2727
private
2828

2929
def process_split_update(notification)
30-
@config.logger.debug("#{notification.type} notification received: #{notification}") if @config.debug_enabled
30+
@config.logger.debug("#{notification.event_type} notification received: #{notification}") if @config.debug_enabled
3131
@splits_worker.add_to_queue(notification)
3232
end
3333

0 commit comments

Comments
 (0)