Merge pull request #450 from splitio/telemtry-validation

[Telemetry] Fixed time until ready

Author: sanzmauro

lib/splitclient-rb/cache/adapters/redis_adapter.rb

@@ -99,7 +99,7 @@ def bool(key)
         alias find_sets_by_prefix find_strings_by_prefix
 
         def add_to_set(key, val)
-          @redis.sadd(key, val)
+          @redis.sadd?(key, val)
         end
 
         def delete_from_set(key, val)

lib/splitclient-rb/split_config.rb

@@ -117,7 +117,7 @@ def initialize(opts = {})
 
       @counter_refresh_rate = SplitConfig.default_counter_refresh_rate(@cache_adapter)
 
-      @sdk_start_time = Time.now
+      @sdk_start_time = Time.now.to_f
 
       @on_demand_fetch_retry_delay_seconds = SplitConfig.default_on_demand_fetch_retry_delay_seconds
       @on_demand_fetch_max_retries = SplitConfig.default_on_demand_fetch_max_retries

lib/splitclient-rb/telemetry/domain/structs.rb

@@ -13,9 +13,10 @@ module Telemetry
     # s: sdkUrl, e: eventsUrl, a: authUrl, st: streamUrl, t: telemetryUrl
     UrlOverrides = Struct.new(:s, :e, :a, :st, :t)
 
-    # om: operationMode, se: streamingEnabled, st: storage, rr: refreshRate, uo: urlOverrides, iq: impressionsQueueSize,
-    # eq: eventsQueueSize, im: impressionsMode, il: impressionListenerEnabled, hp: httpProxyDetected, af: activeFactories,
-    # rf: redundantActiveFactories, tr: timeUntilSdkReady, bt: burTimeouts, nr: sdkNotReadyUsage, t: tags, i: integrations
+    # om: operationMode, st: storage, af: activeFactories, rf: redundantActiveFactories, t: tags, se: streamingEnabled,
+    # rr: refreshRate, uo: urlOverrides, iq: impressionsQueueSize, eq: eventsQueueSize, im: impressionsMode,
+    # il: impressionListenerEnabled, hp: httpProxyDetected, tr: timeUntilSdkReady, bt: burTimeouts,
+    # nr: sdkNotReadyUsage, i: integrations
     ConfigInit = Struct.new(:om, :st, :af, :rf, :t, :se, :rr, :uo, :iq, :eq, :im, :il, :hp, :tr, :bt, :nr, :i)
 
     # ls: lastSynchronization, ml: clientMethodLatencies, me: clientMethodExceptions, he: httpErros, hl: httpLatencies,

lib/splitclient-rb/telemetry/memory/memory_synchronizer.rb

@@ -56,6 +56,7 @@ def synchronize_config(active_factories = nil, redundant_active_factories = nil,
 
         active_factories ||= SplitIoClient.split_factory_registry.active_factories
         redundant_active_factories ||= SplitIoClient.split_factory_registry.redundant_active_factories
+        time_until_ready ||= ((Time.now.to_f - @config.sdk_start_time) * 1000.0).to_i
 
         init_config = ConfigInit.new(mode,
                                      'memory',
@@ -70,7 +71,7 @@ def synchronize_config(active_factories = nil, redundant_active_factories = nil,
                                      impressions_mode,
                                      !@config.impression_listener.nil?,
                                      http_proxy_detected?,
-                                     time_until_ready || Time.now.to_i - @config.sdk_start_time.to_i,
+                                     time_until_ready,
                                      @telemetry_init_consumer.bur_timeouts,
                                      @telemetry_init_consumer.non_ready_usages)
 

lib/splitclient-rb/version.rb

@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '8.1.0'
+  VERSION = '8.1.1.pre.rc2'
 end