pr feedback

Author: sanzmauro

lib/splitclient-rb/split_config.rb

@@ -311,31 +311,17 @@ def self.default_on_demand_fetch_max_retries
     end
 
     def init_impressions_mode(impressions_mode, adapter)
-      if adapter == :redis
-        impressions_mode ||= :debug
-
-        case impressions_mode
-        when :optimized
-          return :optimized
-        when :none
-         return :none
-        else
-          @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
-          return :debug
-        end
-      end
-
-      return :debug if adapter == :redis
-
-      impressions_mode ||= :optimized
       case impressions_mode
-      when :debug
-        return :debug
+      when :optimized
+        return :optimized
       when :none
        return :none
+      when :debug
+        return :debug
       else
-        @logger.error('You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug or :optimized. Defaulting to :optimized mode') unless impressions_mode == :optimized
-        return :optimized
+        default = adapter == :redis ? :debug : :optimized
+        @logger.error("You passed an invalid impressions_mode, impressions_mode should be one of the following values: :debug, :optimized or :none. Defaulting to #{default} mode")
+        return default
       end
     end
 

spec/splitclient/split_config_spec.rb

@@ -113,6 +113,16 @@
       configs3 = SplitIoClient::SplitConfig.new(options3)
 
       expect(configs3.impressions_mode).to eq(:optimized)
+
+      options4 = { impressions_mode: :sarasa, cache_adapter: :redis }
+      configs4 = SplitIoClient::SplitConfig.new(options4)
+
+      expect(configs4.impressions_mode).to eq(:debug)
+
+      options5 = { impressions_mode: :optimized, cache_adapter: :redis }
+      configs5 = SplitIoClient::SplitConfig.new(options5)
+
+      expect(configs5.impressions_mode).to eq(:optimized)
     end
 
     it 'set impressions refresh rate with impressions optimized mode' do