Removed properties if nil in sender

Author: chillaq

lib/splitclient-rb/cache/senders/impressions_formatter.rb

@@ -36,17 +36,30 @@ def feature_impressions(filtered_impressions, feature)
         end
 
         def current_impressions(feature_impressions)
+          formatted = []
           feature_impressions.map do |impression|
-            {
-              k: impression[:i][:k],
-              t: impression[:i][:t],
-              m: impression[:i][:m],
-              b: impression[:i][:b],
-              r: impression[:i][:r],
-              c: impression[:i][:c],
-              pt: impression[:i][:pt],
-              properties: impression[:i][:properties].to_json.to_s
-            }
+            if impression[:i][:properties].nil?
+              impression = {
+                k: impression[:i][:k],
+                t: impression[:i][:t],
+                m: impression[:i][:m],
+                b: impression[:i][:b],
+                r: impression[:i][:r],
+                c: impression[:i][:c],
+                pt: impression[:i][:pt]
+              }
+            else
+              impression = {
+                k: impression[:i][:k],
+                t: impression[:i][:t],
+                m: impression[:i][:m],
+                b: impression[:i][:b],
+                r: impression[:i][:r],
+                c: impression[:i][:c],
+                pt: impression[:i][:pt],
+                properties: impression[:i][:properties].to_json.to_s
+              }
+            end
           end
         end
 

lib/splitclient-rb/engine/common/impressions_manager.rb

@@ -18,7 +18,8 @@ def initialize(config,
           @unique_keys_tracker = unique_keys_tracker
         end
 
-        def build_impression(matching_key, bucketing_key, split_name, treatment_data, impressions_disabled, params = {}, properties = nil)
+        def build_impression(matching_key, bucketing_key, split_name, treatment_data, impressions_disabled, params = {},
+                             properties = nil)
           impression_data = impression_data(matching_key, bucketing_key, split_name, treatment_data, params[:time], properties)
           begin
             if @config.impressions_mode == :none || impressions_disabled
@@ -83,7 +84,8 @@ def record_stats(stats)
         end
 
         # added param time for test
-        def impression_data(matching_key, bucketing_key, split_name, treatment, time = nil, properties = nil)
+        def impression_data(matching_key, bucketing_key, split_name, treatment, time = nil,
+                            properties = nil)
           {
             k: matching_key,
             b: bucketing_key,

spec/cache/senders/impressions_formatter_spec.rb

@@ -58,8 +58,7 @@
                                 b: 'foo1',
                                 r: 'custom_label1',
                                 c: 123_456,
-                                pt: nil,
-                                properties: "null" }]
+                                pt: nil}]
                         },
                          {
                            f: :foo2,
@@ -69,8 +68,7 @@
                                  b: 'foo2',
                                  r: 'custom_label2',
                                  c: 123_499,
-                                pt: nil,
-                                properties: "null" }]
+                                pt: nil}]
                          }])
     end
 
@@ -89,8 +87,7 @@
             b: 'foo1',
             r: 'custom_label1',
             c: 123_456,
-            pt: nil,
-            properties: 'null'
+            pt: nil
           }
         ]
       )
@@ -104,8 +101,7 @@
             b: 'foo2',
             r: 'custom_label2',
             c: 123_499,
-            pt: nil,
-            properties: "null"
+            pt: nil
           },
           {
             k: 'matching_key3',

spec/cache/senders/impressions_sender_spec.rb

@@ -75,8 +75,7 @@
                 b: 'foo1',
                 r: 'custom_label1',
                 c: 123_456,
-                pt: nil,
-                properties: "null"
+                pt: nil
               }
             ]
           },