Merge pull request #404 from splitio/development

sanzmauro · web-flow · commit ff87c7bfa8c3 · 2022-01-28T18:15:22.000-03:00
[7.3.3] Development into master
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -65,3 +65,4 @@ AllCops:
     - spec/telemetry/synchronizer_spec.rb
     - lib/splitclient-rb/engine/synchronizer.rb
     - tmp/**/*
+    - lib/splitclient-rb/sse/event_source/client.rb
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,5 +1,15 @@
 CHANGES
 
+7.3.3 (Jan 28, 2021)
+- Fixed edge cases where the sdk lost streaming connection.
+- Updated default auth service url to https://auth.split.io/api/v2/auth
+- Updated dependencies:
+  - faraday to  >= 0.8, < 2.0
+  - net-http-persistent to >= 2.9, < 5.0
+  - redis to >= 4.0.0, < 5.0
+  - socketry to >= 0.4, < 1.0
+  - thread_safe to ~> 0.3
+
 7.3.2 (Dec 10, 2021)
 - Updated the readiness flow to be more consistent with the other sdks and improve the readiness time.
 - Updated the name of telemety key latencies in Redis.
diff --git a/lib/splitclient-rb/cache/fetchers/segment_fetcher.rb b/lib/splitclient-rb/cache/fetchers/segment_fetcher.rb
@@ -15,15 +15,10 @@ def initialize(segments_repository, api_key, config, telemetry_runtime_producer)
         def call
           if ENV['SPLITCLIENT_ENV'] == 'test'
             fetch_segments
-          else
-            segments_thread
-
-            if defined?(PhusionPassenger)
-              PhusionPassenger.on_event(:starting_worker_process) do |forked|
-                segments_thread if forked
-              end
-            end
+            return
           end
+          
+          segments_thread
         end
 
         def fetch_segments_if_not_exists(names, cache_control_headers = false)
diff --git a/lib/splitclient-rb/cache/fetchers/split_fetcher.rb b/lib/splitclient-rb/cache/fetchers/split_fetcher.rb
@@ -15,15 +15,10 @@ def initialize(splits_repository, api_key, config, telemetry_runtime_producer)
         def call
           if ENV['SPLITCLIENT_ENV'] == 'test'
             fetch_splits
-          else
-            splits_thread
-
-            if defined?(PhusionPassenger)
-              PhusionPassenger.on_event(:starting_worker_process) do |forked|
-                splits_thread if forked
-              end
-            end
+            return
           end
+          
+          splits_thread
         end
 
         def fetch_splits(fetch_options = { cache_control_headers: false, till: nil })
diff --git a/lib/splitclient-rb/cache/senders/events_sender.rb b/lib/splitclient-rb/cache/senders/events_sender.rb
@@ -11,12 +11,6 @@ def initialize(events_repository, config)
 
         def call          
           events_thread
-
-          if defined?(PhusionPassenger)
-            PhusionPassenger.on_event(:starting_worker_process) do |forked|
-              events_thread if forked
-            end
-          end
         end
 
         private
diff --git a/lib/splitclient-rb/cache/senders/impressions_count_sender.rb b/lib/splitclient-rb/cache/senders/impressions_count_sender.rb
@@ -14,12 +14,6 @@ def initialize(config, impression_counter, impressions_api)
 
         def call
           impressions_count_thread
-
-          if defined?(PhusionPassenger)
-            PhusionPassenger.on_event(:starting_worker_process) do |forked|
-              impressions_count_thread if forked
-            end
-          end
         end
 
         private
diff --git a/lib/splitclient-rb/cache/senders/impressions_sender.rb b/lib/splitclient-rb/cache/senders/impressions_sender.rb
@@ -12,12 +12,6 @@ def initialize(impressions_repository, config, impressions_api)
 
         def call
           impressions_thread
-
-          if defined?(PhusionPassenger)
-            PhusionPassenger.on_event(:starting_worker_process) do |forked|
-              impressions_thread if forked
-            end
-          end
         end
 
         private
diff --git a/lib/splitclient-rb/engine/push_manager.rb b/lib/splitclient-rb/engine/push_manager.rb
@@ -34,7 +34,6 @@ def start_sse
       end
 
       def stop_sse
-        @sse_handler.process_disconnect if @sse_handler.sse_client.nil?
         @sse_handler.stop
         SplitIoClient::Helpers::ThreadHelper.stop(:schedule_next_token_refresh, @config)
       end
diff --git a/lib/splitclient-rb/engine/sync_manager.rb b/lib/splitclient-rb/engine/sync_manager.rb
@@ -56,10 +56,6 @@ def start_thread
           if @config.streaming_enabled
             @config.logger.debug('Starting Straming mode ...')
             connected = @push_manager.start_sse
-
-            if defined?(PhusionPassenger)
-              PhusionPassenger.on_event(:starting_worker_process) { |forked| sse_thread_forked if forked }
-            end
           end
 
           unless connected
@@ -140,6 +136,7 @@ def process_disconnect(reconnect)
         record_telemetry(Telemetry::Domain::Constants::SYNC_MODE, SYNC_MODE_POLLING)
 
         if reconnect
+          @push_manager.stop_sse
           @synchronizer.sync_all
           @push_manager.start_sse
         end
@@ -150,11 +147,6 @@ def process_disconnect(reconnect)
       def record_telemetry(type, data)
         @telemetry_runtime_producer.record_streaming_event(type, data)
       end
-
-      def sse_thread_forked
-        connected = @push_manager.start_sse
-        @synchronizer.start_periodic_fetch unless connected
-      end
     end
   end
 end
diff --git a/lib/splitclient-rb/helpers/thread_helper.rb b/lib/splitclient-rb/helpers/thread_helper.rb
@@ -8,7 +8,6 @@ def self.stop(thread_sym, config)
 
         unless thread.nil?
           config.logger.debug("Stopping #{thread_sym} thread...") if config.debug_enabled
-          sleep(0.1) while thread.status == 'run'
           Thread.kill(thread)
         end
       rescue StandardError => e
diff --git a/lib/splitclient-rb/split_config.rb b/lib/splitclient-rb/split_config.rb
@@ -329,7 +329,7 @@ def self.default_streaming_service_url
     end
 
     def self.default_auth_service_url
-      'https://auth.split.io/api/auth'
+      'https://auth.split.io/api/v2/auth'
     end
 
     def self.default_auth_retry_back_off_base
diff --git a/lib/splitclient-rb/sse/event_source/client.rb b/lib/splitclient-rb/sse/event_source/client.rb
@@ -35,11 +35,15 @@ def on_action(&action)
           @on[:action] = action
         end
 
-        def close(action = Constants::PUSH_NONRETRYABLE_ERROR)
-          dispatch_action(action)
+        def close(action = nil)
+          unless connected?
+            @config.logger.error('SSEClient already disconected.') if @config.debug_enabled
+            return
+          end
+
           @connected.make_false
-          SplitIoClient::Helpers::ThreadHelper.stop(:connect_stream, @config)
           @socket&.close
+          dispatch_action(action) unless action.nil?
         rescue StandardError => e
           @config.logger.error("SSEClient close Error: #{e.inspect}")
         end
@@ -72,12 +76,14 @@ def connected?
         def connect_thread(latch)
           @config.threads[:connect_stream] = Thread.new do
             @config.logger.info('Starting connect_stream thread ...') if @config.debug_enabled
-            connect_stream(latch)
+            action = connect_stream(latch)
+            dispatch_action(action) unless action.nil?
+            @config.logger.info('connect_stream thread finished.') if @config.debug_enabled
           end
         end
 
         def connect_stream(latch)
-          socket_write(latch)
+          return Constants::PUSH_NONRETRYABLE_ERROR unless socket_write(latch)
 
           while connected? || @first_event.value
             begin
@@ -86,24 +92,30 @@ def connect_stream(latch)
               read_first_event(partial_data, latch)
 
               raise 'eof exception' if partial_data == :eof
+            rescue Errno::EBADF, IOError => e
+              @config.logger.error(e.inspect)
+              return nil
             rescue StandardError => e
-              @config.logger.error('Error reading partial data: ' + e.inspect) if @config.debug_enabled
-              close(Constants::PUSH_RETRYABLE_ERROR)
-              return
+              return nil if ENV['SPLITCLIENT_ENV'] == 'test'
+
+              @config.logger.error("Error reading partial data: #{e.inspect}") if @config.debug_enabled
+              return Constants::PUSH_RETRYABLE_ERROR
             end
 
             process_data(partial_data)
           end
+          nil
         end
 
         def socket_write(latch)
           @first_event.make_true
           @socket = socket_connect
           @socket.write(build_request(@uri))
+          true
         rescue StandardError => e
           @config.logger.error("Error during connecting to #{@uri.host}. Error: #{e.inspect}")
-          close(Constants::PUSH_NONRETRYABLE_ERROR)
           latch.count_down
+          false
         end
 
         def read_first_event(data, latch)
@@ -181,8 +193,10 @@ def dispatch_event(event)
         end
 
         def dispatch_action(action)
-          @config.logger.debug("Dispatching action: #{action}") if @config.debug_enabled
-          @on[:action].call(action)
+          @config.threads[:dispatch_action] = Thread.new do
+            @config.logger.debug("Dispatching action: #{action}") if @config.debug_enabled
+            @on[:action].call(action)
+          end
         end
       end
     end
diff --git a/lib/splitclient-rb/sse/sse_handler.rb b/lib/splitclient-rb/sse/sse_handler.rb
@@ -31,7 +31,7 @@ def start(token_jwt, channels)
       end
 
       def stop
-        @sse_client.close
+        @sse_client.close(Constants::PUSH_NONRETRYABLE_ERROR)
         stop_workers
       rescue StandardError => e
         @config.logger.debug("SSEHandler stop error: #{e.inspect}") if @config.debug_enabled
diff --git a/lib/splitclient-rb/sse/workers/segments_worker.rb b/lib/splitclient-rb/sse/workers/segments_worker.rb
@@ -13,11 +13,6 @@ def initialize(synchronizer, config, segments_repository)
         end
 
         def add_to_queue(change_number, segment_name)
-          unless @running.value
-            @config.logger.debug('segments worker not running.')
-            return
-          end
-
           item = { change_number: change_number, segment_name: segment_name }
           @config.logger.debug("SegmentsWorker add to queue #{item}")
           @queue.push(item)
@@ -61,10 +56,6 @@ def perform_thread
             perform
           end
         end
-
-        def perform_passenger_forked
-          PhusionPassenger.on_event(:starting_worker_process) { |forked| perform_thread if forked }
-        end
       end
     end
   end
diff --git a/lib/splitclient-rb/sse/workers/splits_worker.rb b/lib/splitclient-rb/sse/workers/splits_worker.rb
@@ -33,21 +33,11 @@ def stop
         end
 
         def add_to_queue(change_number)
-          unless @running.value
-            @config.logger.debug('splits worker not running.')
-            return
-          end
-
           @config.logger.debug("SplitsWorker add to queue #{change_number}")
           @queue.push(change_number)
         end
 
         def kill_split(change_number, split_name, default_treatment)
-          unless @running.value
-            @config.logger.debug('splits worker not running.')
-            return
-          end
-
           return if @splits_repository.get_change_number.to_i > change_number
 
           @config.logger.debug("SplitsWorker kill #{split_name}, #{change_number}")
@@ -70,10 +60,6 @@ def perform_thread
             perform
           end
         end
-
-        def perform_passenger_forked
-          PhusionPassenger.on_event(:starting_worker_process) { |forked| perform_thread if forked }
-        end
       end
     end
   end
diff --git a/lib/splitclient-rb/telemetry/sync_task.rb b/lib/splitclient-rb/telemetry/sync_task.rb
@@ -10,8 +10,6 @@ def initialize(config, telemetry_synchronizer)
 
       def call
         stats_thread
-
-        PhusionPassenger.on_event(:starting_worker_process) { |forked| stats_thread if forked } if defined?(PhusionPassenger)
       end
 
       private
diff --git a/lib/splitclient-rb/version.rb b/lib/splitclient-rb/version.rb
@@ -1,3 +1,3 @@
 module SplitIoClient
-  VERSION = '7.3.2'
+  VERSION = '7.3.3'
 end
diff --git a/spec/engine/push_manager_spec.rb b/spec/engine/push_manager_spec.rb
@@ -93,7 +93,6 @@
 
       expect(connected).to eq(false)
       expect(sse_handler.connected?).to eq(false)
-      expect(action_event).to eq(SplitIoClient::Constants::PUSH_NONRETRYABLE_ERROR)
     end
 
     it 'must not connect to server. Auth server return 401' do
@@ -119,7 +118,6 @@
 
       expect(connected).to eq(false)
       expect(sse_handler.connected?).to eq(false)
-      expect(action_event).to eq(SplitIoClient::Constants::PUSH_NONRETRYABLE_ERROR)
     end
   end
 
diff --git a/spec/engine/sync_manager_spec.rb b/spec/engine/sync_manager_spec.rb
@@ -74,7 +74,7 @@
       sleep(2)
       expect(a_request(:get, 'https://sdk.split.io/api/splitChanges?since=-1')).to have_been_made.once
 
-      expect(config.threads.size).to eq(10)
+      expect(config.threads.size).to eq(11)
     end
   end
 
@@ -93,7 +93,7 @@
       sleep(2)
       expect(a_request(:get, 'https://sdk.split.io/api/splitChanges?since=-1')).to have_been_made.once
 
-      expect(config.threads.size).to eq(6)
+      expect(config.threads.size).to eq(7)
     end
   end
 
diff --git a/spec/integrations/dedupe_impression_spec.rb b/spec/integrations/dedupe_impression_spec.rb
@@ -60,6 +60,7 @@
 
       factory = SplitIoClient::SplitFactory.new('test_api_key_debug-2', streaming_enabled: false, impressions_mode: :debug)
       debug_client = factory.client
+      debug_client.block_until_ready
 
       debug_client.get_treatments('nico_test', %w[FACUNDO_TEST MAURO_TEST Test_Save_1])
       debug_client.get_treatments('admin', %w[FACUNDO_TEST MAURO_TEST Test_Save_1])
diff --git a/spec/integrations/push_client_spec.rb b/spec/integrations/push_client_spec.rb
diff --git a/spec/sse/event_source/client_spec.rb b/spec/sse/event_source/client_spec.rb
diff --git a/spec/sse/sse_handler_spec.rb b/spec/sse/sse_handler_spec.rb
diff --git a/spec/sse/workers/splits_worker_spec.rb b/spec/sse/workers/splits_worker_spec.rb
diff --git a/splitclient-rb.gemspec b/splitclient-rb.gemspec
