Pass all env to tools.py (#140)

Author: mateusz834

splunklib/ai/tools.py

@@ -299,18 +299,9 @@ async def connect_local_mcp(
     server_params = StdioServerParameters(
         command=sys.executable,
         args=[local_tools_path],
+        env=dict(os.environ),
     )
 
-    # Splunk starts processes with a custom LD_LIBRARY_PATH env var, the mcp lib
-    # does not forward all env, but few restricted ones by default. If we don't do
-    # so then the shared object that python loads would fail to succeed.
-    # TODO: If needed we might in future pass all env vars, but we would have to investigate why
-    # the mcp lib did that filtering in the first place. For now we only allow additionally
-    # the LD_LIBRARY_PATH.
-    ld = os.environ.get("LD_LIBRARY_PATH")
-    if ld is not None:
-        server_params.env = {"LD_LIBRARY_PATH": ld}
-
     async with stdio_client(server_params) as (read, write):
         logging_handler = _MCPLoggingHandler(logger)
         async with ClientSession(

tests/system/test_apps/ai_agentic_test_local_tools_app/bin/tools.py

@@ -22,6 +22,9 @@
 
 registry = ToolRegistry()
 
+# Asserts that SPLUNK_HOME is available.
+assert os.environ["SPLUNK_HOME"] == "/opt/splunk"
+
 
 @registry.tool(description="Returns the current temperature in the city")
 def temperature(ctx: ToolContext, city: str) -> str: