Skip to content

Commit b07bc2c

Browse files
committed
Apply nullable value class fix to InvocableHandlerMethod
See gh-36643
1 parent 57d4765 commit b07bc2c

5 files changed

Lines changed: 20 additions & 5 deletions

File tree

spring-core/src/test/kotlin/org/springframework/core/CoroutinesUtilsTests.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ class CoroutinesUtilsTests {
238238
}
239239

240240
@Test
241-
suspend fun invokeSuspendingFunctionWithNullableValueClassParameterWithNonnullObject() {
241+
suspend fun invokeSuspendingFunctionWithNullableValueClassParameterAndNonNullParameter() {
242242
val method = CoroutinesUtilsTests::class.java.declaredMethods.first { it.name.startsWith("suspendingFunctionWithNullableValueClass") }
243243
val mono = CoroutinesUtils.invokeSuspendingFunction(method, this, ValueClass("foo"), null) as Mono
244244
Assertions.assertThat(mono.awaitSingleOrNull()).isEqualTo("foo")

spring-web/src/main/java/org/springframework/web/method/support/InvocableHandlerMethod.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ public static Object invokeFunction(Method method, Object target, Object[] args)
321321
Object arg = args[index];
322322
if (!(parameter.isOptional() && arg == null)) {
323323
KType type = parameter.getType();
324-
if (!(type.isMarkedNullable() && arg == null) &&
324+
if (!type.isMarkedNullable() &&
325325
type.getClassifier() instanceof KClass<?> kClass &&
326326
KotlinDetector.isInlineClass(JvmClassMappingKt.getJavaClass(kClass))) {
327327
arg = box(kClass, arg);
@@ -342,7 +342,7 @@ public static Object invokeFunction(Method method, Object target, Object[] args)
342342
private static Object box(KClass<?> kClass, @Nullable Object arg) {
343343
KFunction<?> constructor = Objects.requireNonNull(KClasses.getPrimaryConstructor(kClass));
344344
KType type = constructor.getParameters().get(0).getType();
345-
if (!(type.isMarkedNullable() && arg == null) &&
345+
if (!type.isMarkedNullable() &&
346346
type.getClassifier() instanceof KClass<?> parameterClass &&
347347
KotlinDetector.isInlineClass(JvmClassMappingKt.getJavaClass(parameterClass))) {
348348
arg = box(parameterClass, arg);

spring-web/src/test/kotlin/org/springframework/web/method/support/InvocableHandlerMethodKotlinTests.kt

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -148,6 +148,13 @@ class InvocableHandlerMethodKotlinTests {
148148
Assertions.assertThatIllegalArgumentException().isThrownBy { invocable.invokeForRequest(request, null) }
149149
}
150150

151+
@Test
152+
fun valueClassWithNullableAndNonNullParameter() {
153+
composite.addResolver(StubArgumentResolver(LongValueClass::class.java, LongValueClass(1)))
154+
val value = getInvocable(ValueClassHandler::valueClassWithNullable.javaMethod!!).invokeForRequest(request, null)
155+
Assertions.assertThat(value).isEqualTo(1L)
156+
}
157+
151158
@Test
152159
fun valueClassWithNullable() {
153160
composite.addResolver(StubArgumentResolver(LongValueClass::class.java, null))

spring-webflux/src/main/java/org/springframework/web/reactive/result/method/InvocableHandlerMethod.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@ public static Object invokeFunction(Method method, Object target, Object[] args,
360360
Object arg = args[index];
361361
if (!(parameter.isOptional() && arg == null)) {
362362
KType type = parameter.getType();
363-
if (!(type.isMarkedNullable() && arg == null) &&
363+
if (!type.isMarkedNullable() &&
364364
type.getClassifier() instanceof KClass<?> kClass &&
365365
KotlinDetector.isInlineClass(JvmClassMappingKt.getJavaClass(kClass))) {
366366
arg = box(kClass, arg);
@@ -382,7 +382,7 @@ public static Object invokeFunction(Method method, Object target, Object[] args,
382382
private static Object box(KClass<?> kClass, @Nullable Object arg) {
383383
KFunction<?> constructor = Objects.requireNonNull(KClasses.getPrimaryConstructor(kClass));
384384
KType type = constructor.getParameters().get(0).getType();
385-
if (!(type.isMarkedNullable() && arg == null) &&
385+
if (!type.isMarkedNullable() &&
386386
type.getClassifier() instanceof KClass<?> parameterClass &&
387387
KotlinDetector.isInlineClass(JvmClassMappingKt.getJavaClass(parameterClass))) {
388388
arg = box(parameterClass, arg);

spring-webflux/src/test/kotlin/org/springframework/web/reactive/result/InvocableHandlerMethodKotlinTests.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -250,6 +250,14 @@ class InvocableHandlerMethodKotlinTests {
250250
assertExceptionThrown(result, IllegalArgumentException::class)
251251
}
252252

253+
@Test
254+
fun valueClassWithNullableAndNonNullParameter() {
255+
this.resolvers.add(stubResolver(LongValueClass(1), LongValueClass::class.java))
256+
val method = ValueClassController::valueClassWithNullable.javaMethod!!
257+
val result = invoke(ValueClassController(), method)
258+
assertHandlerResultValue(result, "1")
259+
}
260+
253261
@Test
254262
fun valueClassWithNullable() {
255263
this.resolvers.add(stubResolver(null, LongValueClass::class.java))

0 commit comments

Comments
 (0)