Primary key constraint forces not null (#851) (#860)

Author: henrybaxter

internal/endtoend/testdata/primary_key_later/go/db.go

@@ -0,0 +1,9 @@
+-- name: GetAuthor :one
+SELECT
+    *
+FROM
+    authors
+WHERE
+    id = $1
+LIMIT 1;
+

internal/endtoend/testdata/primary_key_later/go/models.go

@@ -0,0 +1,7 @@
+CREATE TABLE authors (
+    id bigserial,
+    name text NOT NULL,
+    bio text,
+    PRIMARY KEY (id)
+);
+

internal/endtoend/testdata/primary_key_later/go/queries.sql.go

@@ -0,0 +1,12 @@
+{
+  "version": "1",
+  "packages": [
+    {
+      "engine": "postgresql",
+      "path": "go",
+      "name": "primary_key_later",
+      "schema": "schema.sql",
+      "queries": "queries.sql"
+    }
+  ]
+}

internal/endtoend/testdata/primary_key_later/queries.sql

@@ -399,6 +399,17 @@ func translate(node nodes.Node) (ast.Node, error) {
 			Name:        name,
 			IfNotExists: n.IfNotExists,
 		}
+		primaryKey := make(map[string]bool)
+		for _, elt := range n.TableElts.Items {
+			switch n := elt.(type) {
+			case nodes.Constraint:
+				if n.Contype == nodes.CONSTR_PRIMARY {
+					for _, item := range n.Keys.Items {
+						primaryKey[item.(nodes.String).Str] = true
+					}
+				}
+			}
+		}
 		for _, elt := range n.TableElts.Items {
 			switch n := elt.(type) {
 			case nodes.ColumnDef:
@@ -409,7 +420,7 @@ func translate(node nodes.Node) (ast.Node, error) {
 				create.Cols = append(create.Cols, &ast.ColumnDef{
 					Colname:   *n.Colname,
 					TypeName:  tn,
-					IsNotNull: isNotNull(n),
+					IsNotNull: isNotNull(n) || primaryKey[*n.Colname],
 					IsArray:   isArray(n.TypeName),
 				})
 			}