Skip to content

Commit 5057451

Browse files
committed
Refactor CodePushDialog to extend BaseJavaModule and improve activity retrieval logic
1 parent c32369b commit 5057451

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

android/app/src/main/java/com/microsoft/codepush/react/CodePushDialog.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
import android.app.AlertDialog;
55
import android.content.DialogInterface;
66

7+
import com.facebook.react.bridge.BaseJavaModule;
78
import com.facebook.react.bridge.Callback;
89
import com.facebook.react.bridge.LifecycleEventListener;
910
import com.facebook.react.bridge.ReactApplicationContext;
10-
import com.facebook.react.bridge.ReactContextBaseJavaModule;
1111
import com.facebook.react.bridge.ReactMethod;
1212

13-
public class CodePushDialog extends ReactContextBaseJavaModule{
13+
public class CodePushDialog extends BaseJavaModule {
1414

1515
public CodePushDialog(ReactApplicationContext reactContext) {
1616
super(reactContext);
@@ -19,14 +19,14 @@ public CodePushDialog(ReactApplicationContext reactContext) {
1919
@ReactMethod
2020
public void showDialog(final String title, final String message, final String button1Text,
2121
final String button2Text, final Callback successCallback, Callback errorCallback) {
22-
Activity currentActivity = getCurrentActivity();
22+
Activity currentActivity = getReactApplicationContext().getCurrentActivity();
2323
if (currentActivity == null || currentActivity.isFinishing()) {
2424
// If getCurrentActivity is null, it could be because the app is backgrounded,
2525
// so we show the dialog when the app resumes)
2626
getReactApplicationContext().addLifecycleEventListener(new LifecycleEventListener() {
2727
@Override
2828
public void onHostResume() {
29-
Activity currentActivity = getCurrentActivity();
29+
Activity currentActivity = getReactApplicationContext().getCurrentActivity();
3030
if (currentActivity != null) {
3131
getReactApplicationContext().removeLifecycleEventListener(this);
3232
showDialogInternal(title, message, button1Text, button2Text, successCallback, currentActivity);

0 commit comments

Comments
 (0)