Skip to content

Commit 5296c52

Browse files
committed
updated docs
1 parent 3ee7c56 commit 5296c52

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

docs/modules/airflow/examples/example-airflow-gitsync-https.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,11 @@ spec:
2323
# --rev: git-sync-tag # N.B. tag must be covered by "depth" (the number of commits to clone)
2424
# --rev: 39ee3598bd9946a1d958a448c9f7d3774d7a8043 # N.B. commit must be covered by "depth"
2525
# --git-config: http.sslCAInfo:/tmp/ca-cert/ca.crt # N.B. this will trigger a warning if caCertSecretName is also supplied
26-
caCertSecretName: git-ca-cert # <11>
26+
tls:
27+
verification:
28+
server:
29+
caCert:
30+
secretClass: git-ca-cert # <11>
2731
webservers:
2832
...
2933
---

docs/modules/airflow/pages/usage-guide/mounting-dags.adoc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,11 @@ include::example$example-airflow-gitsync-https.yaml[]
6969
If a tag or commit hash is specified, then git-sync recognizes this and does not perform further cloning.
7070
Git-sync settings can be provided inline, although some of these (`--dest`, `--root`) are specified internally in the operator and are ignored if provided by the user.
7171
Git-config settings can also be specified, although a warning is logged if `safe.directory` is specified as this is defined internally, and should not be defined by the user.
72-
<11> An optional secret used for holding CA certificates that will be used to verify the git server's TLS certificate by passing it to the git config option `http.sslCAInfo` passed with the gitsync command.
73-
The secret must have a key named `ca.crt` whose value is the PEM-encoded certificate bundle.
72+
<11> An optional reference to the SecretClass used for holding CA certificates that will be used to verify the git server's TLS certificate by passing it to the git config option `http.sslCAInfo` passed with the gitsync command.
73+
The associated secret must have a key named `ca.crt` whose value is the PEM-encoded certificate bundle.
74+
If this field is set to `webPki: {}` or is omitted altogether, then no changes will be made to the gitsync command and it will default to presenting no certificate to the backend.
75+
Omitting this field is non-breaking behaviour and as such it does *not* set `http.sslverify` to `false` as disabling security checks should be a last resort and not something activated by default.
76+
This can still be achieved by passing `--git-config: http.sslverify=false` explicitly.
7477

7578
.git-sync usage example: ssh
7679
[source,yaml]

0 commit comments

Comments
 (0)