Delegate route.fail handling to app

Author: pcj

js/ui/app.js

@@ -56,7 +56,7 @@ class App extends Component {
    */
   handleHistoryNavigate(e) {
     this.router_.go(e.token).thenCatch(err => {
-      this.notifyError(`Routing failure while nagivating to ${e.token}`);
+      console.warn(`Routing failure while nagivating to ${e.token}`);
     });
   }
 

js/ui/history.js

@@ -45,7 +45,7 @@ class History extends EventTarget {
   }
 
   /**
-   * @param {!events.Event} e
+   * @param {!events.BrowserEvent} e
    */
   handleDocumentClick(e) {
     //console.log("history; click!");
@@ -68,7 +68,13 @@ class History extends EventTarget {
       return;
     }
     e.preventDefault();
-    e.stopPropagation();
+    // e.stopPropagation();
+
+    if (e.ctrlKey) {
+      const href = anchor.href.replace("/#/", "/");
+      window.open(href, "_blank");
+      return;
+    } 
     hash = hash.substring(2);
     //this.history_.replaceToken(hash);
     //this.replaceToken(hash);

js/ui/router.js

@@ -45,6 +45,13 @@ class Router extends EventTarget {
      * @type {?Route}
      */
     this.route_ = null;
+
+    /**
+     * Strict mode means that an existing route that hasn't finished yet will fail a new attempt.
+     * @private
+     * @type {boolean}
+     */
+    this.strict_ = true;
 
   }
 
@@ -56,7 +63,15 @@ class Router extends EventTarget {
   getCurrentRoute() {
     return this.route_;
   }
-  
+
+  /**
+   * Set the strict mode
+   * @param {boolean} b 
+   */
+  setStrict(b) {
+    this.strict_ = b;
+  }
+
   /**
    * Get a component if registered.
    *i
@@ -66,7 +81,7 @@ class Router extends EventTarget {
   go(path) {
     //console.log('go: ' + path);
     asserts.assertString(path, 'Routing path must be a string');
-    if (this.route_) {
+    if (this.strict_ && this.route_) {
       console.warn(`cannot route to ${path} due to existing route "${this.route_.matchedPath()}" --> "${this.route_.unmatchedPath()}"`);
       return Promise_.reject(
         'Already routing to ' + this.route_.getPath()

js/ui/select.js

@@ -190,7 +190,7 @@ class Select extends Component {
    */
   selectFail(name, route) {
     route.fail(this, 'No tab for ' + name + ' in ' + JSON.stringify(this.name2id_));
-    this.getApp().handle404(route);
+    // this.getApp().handle404(route);
   }
 
   /**