Skip to content

Commit f2e1a97

Browse files
Apply suggestions from code review
Co-authored-by: Radu Bahmata <92028479+BowTiedRadone@users.noreply.github.com>
1 parent a2f6848 commit f2e1a97

2 files changed

Lines changed: 7 additions & 8 deletions

File tree

Makefile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# List of binaries devent needs to function properly
1+
# List of binaries devnet needs to function properly
22
COMMANDS := sudo tar zstd getent stress
33
$(foreach bin,$(COMMANDS),\
44
$(if $(shell command -v $(bin) 2> /dev/null),$(info),$(error Missing required dependency: `$(bin)`)))
@@ -64,7 +64,6 @@ check-not-running:
6464
echo "WARNING: Network appears to be running or was not properly shut down."; \
6565
echo "Current chainstate directory: $$(cat .current-chainstate-dir)"; \
6666
echo ""; \
67-
echo "To backup logs first: make backup-logs"; \
6867
echo "To shut down: make down"; \
6968
echo ""; \
7069
exit 1; \
@@ -108,7 +107,7 @@ genesis: check-not-running | build $(CHAINSTATE_DIR) /usr/bin/sudo
108107
# Secondary name to boot the genesis network
109108
up-genesis: genesis
110109

111-
# Shut down the network (chainstate and logs will be preserved, but not logs)
110+
# Shut down the network (chainstate and logs will be preserved)
112111
down: backup-logs current-chainstate-dir
113112
@echo "Shutting down $(PROJECT) network"
114113
docker compose -f docker/docker-compose.yml --profile default -p $(PROJECT) down
@@ -129,7 +128,7 @@ down-force:
129128
fi
130129

131130

132-
# Stream specified service logs to STDOUT. does not validate if PARAMS is supplied
131+
# Stream specified service logs to STDOUT. Does not validate if PARAMS is supplied
133132
log: current-chainstate-dir
134133
@echo "Logs for service $(PARAMS)"
135134
docker compose -f docker/docker-compose.yml --profile default -p $(PROJECT) logs -t --no-log-prefix $(PARAMS) -f
@@ -158,7 +157,7 @@ backup-logs: current-chainstate-dir /usr/bin/sudo
158157
fi
159158

160159

161-
# Replace the existing chainstate archive. will be used with target `up`
160+
# Replace the existing chainstate archive. Will be used with target `up`
162161
snapshot: current-chainstate-dir down
163162
@echo "Creating $(PROJECT) chainstate snapshot from $(ACTIVE_CHAINSTATE_DIR)"
164163
@if [ -d "$(ACTIVE_CHAINSTATE_DIR)/logs" ]; then \
@@ -169,7 +168,7 @@ snapshot: current-chainstate-dir down
169168
cd $(ACTIVE_CHAINSTATE_DIR); sudo tar --zstd -cf $(CHAINSTATE_ARCHIVE) *; cd $(PWD)
170169

171170

172-
# Pause all services in the network (netork is down, but recoverably with target 'unpause')
171+
# Pause all services in the network (netork is down, but recoverably with target 'unpause')
173172
pause:
174173
@echo "Pausing all services"
175174
docker compose -f docker/docker-compose.yml --profile default -p $(PROJECT) pause $(SERVICES)
@@ -199,7 +198,7 @@ start: check-params current-chainstate-dir | check-running
199198
CHAINSTATE_DIR=$(ACTIVE_CHAINSTATE_DIR) docker compose -f docker/docker-compose.yml --profile default -p $(PROJECT) up -d $(PARAMS)
200199

201200

202-
# Restart a service with a defined servicename/duration - Script will validate PARAMS
201+
# Restart a service with a defined servicename/duration - the script will validate PARAMS
203202
# If no duration is provided, a default of 30s shall be used
204203
restart: check-params | check-running
205204
@echo "Restarting service"

docker/bitcoin/miner.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ function init(){
210210
# Import an address into a wallet
211211
if ! import_address "${btc_wallet}" "${btc_address}"; then
212212
echo "ERROR importing address (${btc_address}) into wallet (${btc_wallet})"
213-
# Exit if address import returns a failure
213+
# Exit if address import returns a failure
214214
exit 1
215215
fi
216216
fi

0 commit comments

Comments
 (0)