more careful handling of object created to be passed to PyErr_SetObject

Author: flexatone

arraymap.c

@@ -1239,7 +1239,12 @@ insert_int(
         return -1;
     }
     if (self->table[table_pos].hash != -1) {
-        PyErr_SetObject(NonUniqueError, PyLong_FromSsize_t(key));
+        PyObject* er = PyLong_FromLongLong(key); // for error reporting
+        if (er == NULL) {
+            return -1;
+        }
+        PyErr_SetObject(NonUniqueError, er);
+        Py_DECREF(er);
         return -1;
     }
     self->table[table_pos].keys_pos = keys_pos;
@@ -1264,7 +1269,12 @@ insert_uint(
         return -1;
     }
     if (self->table[table_pos].hash != -1) {
-        PyErr_SetObject(NonUniqueError, PyLong_FromSsize_t(key));
+        PyObject* er = PyLong_FromUnsignedLongLong(key);
+        if (er == NULL) {
+            return -1;
+        }
+        PyErr_SetObject(NonUniqueError, er);
+        Py_DECREF(er);
         return -1;
     }
     self->table[table_pos].keys_pos = keys_pos;
@@ -1290,7 +1300,12 @@ insert_double(
         return -1;
     }
     if (self->table[table_pos].hash != -1) {
-        PyErr_SetObject(NonUniqueError, PyFloat_FromDouble(key));
+        PyObject* er = PyFloat_FromDouble(key);
+        if (er == NULL) {
+            return -1;
+        }
+        PyErr_SetObject(NonUniqueError, er);
+        Py_DECREF(er);
         return -1;
     }
     self->table[table_pos].keys_pos = keys_pos;
@@ -1316,8 +1331,12 @@ insert_unicode(
         return -1;
     }
     if (self->table[table_pos].hash != -1) {
-        PyErr_SetObject(NonUniqueError,
-            PyUnicode_FromKindAndData(PyUnicode_4BYTE_KIND, key, key_size));
+        PyObject* er = PyUnicode_FromKindAndData(PyUnicode_4BYTE_KIND, key, key_size);
+        if (er == NULL) {
+            return -1;
+        }
+        PyErr_SetObject(NonUniqueError, er);
+        Py_DECREF(er);
         return -1;
     }
     self->table[table_pos].keys_pos = keys_pos;
@@ -1343,8 +1362,12 @@ insert_string(
         return -1;
     }
     if (self->table[table_pos].hash != -1) {
-        PyErr_SetObject(NonUniqueError,
-            PyBytes_FromStringAndSize(key, key_size));
+        PyObject* er = PyBytes_FromStringAndSize(key, key_size);
+        if (er == NULL) {
+            return -1;
+        }
+        PyErr_SetObject(NonUniqueError, er);
+        Py_DECREF(er);
         return -1;
     }
     self->table[table_pos].keys_pos = keys_pos;
@@ -1947,6 +1970,7 @@ fam_init(PyObject *self, PyObject *args, PyObject *kwargs)
     }
     return 0;
 error:
+    // assume all dynamic memory assigned to struct attrs that will be cleaned
     return -1;
 }