Skip to content

Commit 00ec683

Browse files
nirmaljbnirmaljb
committed
test: migrated to ulpdiff
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
1 parent cd9c7b6 commit 00ec683

2 files changed

Lines changed: 10 additions & 36 deletions

File tree

‎lib/node_modules/@stdlib/math/base/special/gammaf/test/test.js‎

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@
2323
var tape = require( 'tape' );
2424
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2525
var incrspace = require( '@stdlib/array/base/incrspace' );
26-
var absf = require( '@stdlib/math/base/special/absf' );
27-
var max = require( '@stdlib/math/base/special/maxn' );
26+
var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' );
2827
var PINF = require( '@stdlib/constants/float32/pinf' );
2928
var NINF = require( '@stdlib/constants/float32/ninf' );
3029
var gammaf = require( './../lib' );
@@ -107,31 +106,23 @@ tape( 'if `x < -34.195...`, the function returns zero', function test( t ) {
107106
});
108107

109108
tape( 'the function evaluates the gamma function (positive integers)', function test( t ) {
110-
var delta;
111-
var tol;
112109
var v;
113110
var i;
114111

115112
for ( i = 0; i < data1.length; i++ ) {
116113
v = gammaf( data1[ i ] );
117-
delta = absf( v - expected1[ i ] );
118-
tol = 2.75e-5 * max( 1.0, absf( v ), absf( expected1[ i ] ) );
119-
t.ok( delta <= tol, 'within tolerance. x: ' + data1[ i ] + '. Value: ' + v + '. Expected: ' + expected1[ i ] + '. Tolerance: ' + tol + '.' );
114+
t.strictEqual( ulpdiff( v, expected1[ i ] ) <= 3, true, 'within tolerance. x: ' + data1[ i ] + '. Value: ' + v + '. Expected: ' + expected1[ i ] );
120115
}
121116
t.end();
122117
});
123118

124119
tape( 'the function evaluates the gamma function (decimal values)', function test( t ) {
125-
var delta;
126-
var tol;
127120
var v;
128121
var i;
129122

130123
for ( i = 0; i < data2.length; i++ ) {
131124
v = gammaf( data2[ i ] );
132-
delta = absf( v - expected2[ i ] );
133-
tol = 2.75e-5 * max( 1.0, absf( v ), absf( expected2[ i ] ) );
134-
t.ok( delta <= tol, 'within tolerance. x: ' + data2[ i ] + '. Value: ' + v + '. Expected: ' + expected2[ i ] + '. Tolerance: ' + tol + '.' );
125+
t.strictEqual( ulpdiff( v, expected2[ i ] ) <= 5, true, 'within tolerance. x: ' + data2[ i ] + '. Value: ' + v + '. Expected: ' + expected2[ i ] );
135126
}
136127
t.end();
137128
});
@@ -145,19 +136,15 @@ tape( 'if provided a positive integer, the function returns the factorial of (n-
145136

146137
tape( 'the function uses a small value approximation for tiny positive x', function test( t ) {
147138
var expected;
148-
var delta;
149-
var tol;
150139
var x;
151140
var v;
152141

153142
x = 0.000009999999747378752; // f32(1e-5) — triggers x < 1e-4 check
154143
v = gammaf( x );
155144

156145
expected = 9.9999422e+4;
157-
delta = absf( v - expected );
158-
tol = 1.0;
159146

160-
t.ok( delta < tol, 'within tolerance. x: ' + x + '. Value: ' + v +
161-
'. Expected: ' + expected + '. Tolerance: ' + tol + '.' );
147+
t.strictEquals( ulpdiff( v, expected ) <= 1, true, 'within tolerance. x: ' + x + '. Value: ' + v +
148+
'. Expected: ' + expected );
162149
t.end();
163150
});

‎lib/node_modules/@stdlib/math/base/special/gammaf/test/test.native.js‎

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ var resolve = require( 'path' ).resolve;
2424
var tape = require( 'tape' );
2525
var isnanf = require( '@stdlib/math/base/assert/is-nanf' );
2626
var incrspace = require( '@stdlib/array/base/incrspace' );
27-
var absf = require( '@stdlib/math/base/special/absf' );
28-
var max = require( '@stdlib/math/base/special/maxn' );
2927
var PINF = require( '@stdlib/constants/float32/pinf' );
28+
var ulpdiff = require( '@stdlib/number/float32/base/ulp-difference' );
3029
var NINF = require( '@stdlib/constants/float32/ninf' );
3130
var tryRequire = require( '@stdlib/utils/try-require' );
3231

@@ -116,31 +115,23 @@ tape( 'if `x < -34.195...`, the function returns zero', function test( t ) {
116115
});
117116

118117
tape( 'the function evaluates the gamma function (positive integers)', opts, function test( t ) {
119-
var delta;
120-
var tol;
121118
var v;
122119
var i;
123120

124121
for ( i = 0; i < data1.length; i++ ) {
125122
v = gammaf( data1[ i ] );
126-
delta = absf( v - expected1[ i ] );
127-
tol = 2.75e-5 * max( 1.0, absf( v ), absf( expected1[ i ] ) );
128-
t.ok( delta <= tol, 'within tolerance. x: ' + data1[ i ] + '. Value: ' + v + '. Expected: ' + expected1[ i ] + '. Tolerance: ' + tol + '.' );
123+
t.strictEqual( ulpdiff( v, expected1[ i ] ) <= 3, true, 'within tolerance. x: ' + data1[ i ] + '. Value: ' + v + '. Expected: ' + expected1[ i ] );
129124
}
130125
t.end();
131126
});
132127

133128
tape( 'the function evaluates the gamma function (decimal values)', opts, function test( t ) {
134-
var delta;
135-
var tol;
136129
var v;
137130
var i;
138131

139132
for ( i = 0; i < data2.length; i++ ) {
140133
v = gammaf( data2[ i ] );
141-
delta = absf( v - expected2[ i ] );
142-
tol = 2.75e-5 * max( 1.0, absf( v ), absf( expected2[ i ] ) );
143-
t.ok( delta <= tol, 'within tolerance. x: ' + data2[ i ] + '. Value: ' + v + '. Expected: ' + expected2[ i ] + '. Tolerance: ' + tol + '.' );
134+
t.strictEqual( ulpdiff( v, expected2[ i ] ) <= 5, true, 'within tolerance. x: ' + data2[ i ] + '. Value: ' + v + '. Expected: ' + expected2[ i ] );
144135
}
145136
t.end();
146137
});
@@ -154,19 +145,15 @@ tape( 'if provided a positive integer, the function returns the factorial of (n-
154145

155146
tape( 'the function uses a small value approximation for tiny positive x', opts, function test( t ) {
156147
var expected;
157-
var delta;
158-
var tol;
159148
var x;
160149
var v;
161150

162151
x = 0.000009999999747378752; // f32(1e-5) — triggers x < 1e-4 check
163152
v = gammaf( x );
164153

165154
expected = 9.9999422e+4;
166-
delta = absf( v - expected );
167-
tol = 1.0;
168155

169-
t.ok( delta < tol, 'within tolerance. x: ' + x + '. Value: ' + v +
170-
'. Expected: ' + expected + '. Tolerance: ' + tol + '.' );
156+
t.strictEquals( ulpdiff( v, expected ) <= 1, true, 'within tolerance. x: ' + x + '. Value: ' + v +
157+
'. Expected: ' + expected );
171158
t.end();
172159
});

0 commit comments

Comments
 (0)