fix: update according to code review

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: nakul-krishnakumar

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/README.md

@@ -24,17 +24,6 @@ limitations under the License.
 
 <section class="intro">
 
-The [hinge loss][hinge-loss] between `y` and `p` is defined as
-
-<!-- <equation class="equation" label="eq:hinge_loss" align="center" raw="g = max(0, 1 - y*p)" alt="Equation for the sample correlation distance."> -->
-
-```math
-g = max(0, 1 - y*p)
-```
-
-<!-- </equation> -->
-
-
 </section>
 
 <!-- /.intro -->
@@ -59,6 +48,26 @@ v = hinge( 1.0, -0.9 );
 // returns 1.9
 ```
 
+If either argument is `NaN`, the function returns `NaN`.
+
+```javascript
+var g = hinge( NaN, 12.0 );
+// returns NaN
+
+g = hinge( 5.0, NaN );
+// returns NaN
+```
+
+If `y` is not +1 or -1, the function returns `NaN`.
+
+```javascript
+var g = hinge( 2.3, 1.0 );
+// returns NaN
+
+g = hinge( -1.3, 0.987 );
+// returns NaN
+```
+
 </section>
 
 <!-- /.usage -->

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/benchmark/benchmark.js

@@ -31,15 +31,17 @@ var hinge = require( './../lib' );
 // MAIN //
 
 bench( pkg, function benchmark( b ) {
+	var len;
 	var y;
 	var p;
 	var g;
 	var i;
 
+	len = 100;
 	y = sample( [ -1, 1 ], {
-		'size': 100
+		'size': len
 	});
-	p = uniform( 100, -2.0, 2.0 );
+	p = uniform( len, -2.0, 2.0 );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/benchmark/benchmark.native.js

@@ -41,15 +41,17 @@ var opts = {
 // MAIN //
 
 bench( format( '%s::native', pkg ), opts, function benchmark( b ) {
+	var len;
 	var y;
 	var p;
 	var g;
 	var i;
 
+	len = 100;
 	y = sample( [ -1, 1 ], {
-		'size': 100
+		'size': len
 	});
-	p = uniform( 100, -2.0, 2.0 );
+	p = uniform( len, -2.0, 2.0 );
 
 	b.tic();
 	for ( i = 0; i < b.iterations; i++ ) {

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/benchmark/c/native/benchmark.c

@@ -86,27 +86,43 @@ static double random_uniform( const double min, const double max ) {
 	return min + ( v*(max-min) );
 }
 
+/**
+* Randomly samples either +1 or -1.
+*
+* @return       random number
+*/
+static double random_sample( void ) {
+	double v = (double)rand() / ( (double)RAND_MAX );
+	if ( v >= 0.5 ) {
+		return 1;
+	}
+	return -1;
+}
+
 /**
 * Runs a benchmark.
 *
 * @param y   true target value
 * @return elapsed time in seconds
 */
-static double benchmark( const double y ) {
+static double benchmark( void ) {
 	double *p;
+	double *y;
 	double elapsed;
 	double g;
 	double t;
 	int i;
 
 	p = (double *) malloc( 100 * sizeof( double ) );
+	y = (double *) malloc( 100 * sizeof( double ) );
 	for ( i = 0; i < 100; i++ ) {
+		y[ i ] = random_sample();
 		p[ i ] = random_uniform( -2.0, 2.0 );
 	}
 
 	t = tic();
 	for ( i = 0; i < ITERATIONS; i++ ) {
-		g = stdlib_base_float64_hinge( y, p[ i % 100 ] );
+		g = stdlib_base_float64_hinge( y[ i % 100 ], p[ i % 100 ] );
 		if ( g != g ) {
 			printf( "should not return NaN\n" );
 			break;
@@ -116,6 +132,7 @@ static double benchmark( const double y ) {
 	if ( g != g ) {
 		printf( "should not return NaN\n" );
 	}
+	free( y );
 	free( p );
 	return elapsed;
 }
@@ -125,24 +142,15 @@ static double benchmark( const double y ) {
 */
 int main( void ) {
 	double elapsed;
-	double y;
 	int i;
 
 	// Use the current time to seed the random number generator:
 	srand( time( NULL ) );
 
 	print_version();
-	y = 1;
-	for ( i = 0; i < REPEATS; i++ ) {
-		printf( "# c::native::%s:y=%.1f\n", NAME, y );
-		elapsed = benchmark( y );
-		print_results( elapsed );
-		printf( "ok %d benchmark finished\n", i+1 );
-	}
-	y = -1;
 	for ( i = 0; i < REPEATS; i++ ) {
-		printf( "# c::native::%s:y=%.1f\n", NAME, y );
-		elapsed = benchmark( y );
+		printf( "# c::native::%s\n", NAME );
+		elapsed = benchmark();
 		print_results( elapsed );
 		printf( "ok %d benchmark finished\n", i+1 );
 	}

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/docs/repl.txt

@@ -2,6 +2,9 @@
 {{alias}}( y, p )
     Computes the hinge loss between two double-precision floating-point number.
 
+    If either argument is `NaN`, the function returns `NaN`.
+    If `y` is not +1 or -1, the function returns `NaN`.
+
     Parameters
     ----------
     y: number
@@ -25,7 +28,7 @@
     ~0.001
     > g = {{alias}}( -1.0, 0.2 )
     1.2
-    > g = {{alias}}( NaN, NaN )
+    > g = {{alias}}( NaN, 0.987 )
     NaN
 
     See Also

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/examples/c/example.c

@@ -26,7 +26,7 @@ int main( void ) {
 	double v;
 	int i;
 	for ( i = 0; i < 10; i++ ) {
-		v = stdlib_base_float64_hinge( x[ i ] );
+		v = stdlib_base_float64_hinge( y[ i ], p[ i ] );
 		printf( "hinge(%lf, %lf) = %lf\n", y[ i ], p[ i ], v );
 	}
 }

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/lib/main.js

@@ -21,6 +21,7 @@
 // MODULES //
 
 var max = require( '@stdlib/math/base/special/max' );
+var isnan = require( '@stdlib/math/base/assert/is-nan' );
 
 
 // MAIN //
@@ -58,6 +59,9 @@ var max = require( '@stdlib/math/base/special/max' );
 * // returns 1.9
 */
 function hinge( y, p ) {
+	if ( isnan( y ) || isnan( p ) ) {
+		return NaN;
+	}
 	if ( y !== -1.0 && y !== 1.0 ) {
 		return NaN;
 	}

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/manifest.json

@@ -36,11 +36,9 @@
       "libraries": [],
       "libpath": [],
       "dependencies": [
-        "@stdlib/napi/create-double",
-        "@stdlib/napi/export",
-        "@stdlib/napi/argv",
-        "@stdlib/napi/argv-double",
+        "@stdlib/math/base/napi/binary",
         "@stdlib/math/base/special/max",
+        "@stdlib/math/base/assert/is-nan",
         "@stdlib/constants/float64/nan"
       ]
     },
@@ -56,6 +54,7 @@
       "libpath": [],
       "dependencies": [
         "@stdlib/math/base/special/max",
+        "@stdlib/math/base/assert/is-nan",
         "@stdlib/constants/float64/nan"
       ]
     },
@@ -71,6 +70,7 @@
       "libpath": [],
       "dependencies": [
         "@stdlib/math/base/special/max",
+        "@stdlib/math/base/assert/is-nan",
         "@stdlib/constants/float64/nan"
       ]
     }

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/package.json

@@ -58,7 +58,10 @@
     "loss",
     "float64",
     "hinge",
-    "hinge loss"
+    "hinge loss",
+    "double-precision",
+    "double",
+    "dbl"
   ],
   "__stdlib__": {}
 }

lib/node_modules/@stdlib/ml/base/loss/float64/hinge/src/addon.c

@@ -17,18 +17,6 @@
 */
 
 #include "stdlib/ml/base/loss/float64/hinge.h"
-#include "stdlib/napi/create_double.h"
-#include "stdlib/napi/argv_double.h"
-#include "stdlib/napi/export.h"
-#include "stdlib/napi/argv.h"
-#include <node_api.h>
+#include "stdlib/math/base/napi/binary.h"
 
-static napi_value addon( napi_env env, napi_callback_info info ) {
-	STDLIB_NAPI_ARGV( env, info, argv, argc, 2 );
-	STDLIB_NAPI_ARGV_DOUBLE( env, y, argv, 0 );
-	STDLIB_NAPI_ARGV_DOUBLE( env, p, argv, 1 );
-	STDLIB_NAPI_CREATE_DOUBLE( env, stdlib_base_float64_hinge( y, p ), v );
-	return v;
-}
-
-STDLIB_NAPI_MODULE_EXPORT_FCN( addon )
+STDLIB_MATH_BASE_NAPI_MODULE_DD_D( stdlib_base_float64_hinge )