build: rename validate-pkg-json to lint-pkgs-metadata-files and move to lint/pkgs

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: passed
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

Author: Planeshifter

.github/workflows/lint_changed_files.yml

@@ -171,11 +171,11 @@ jobs:
         run: |
           . "$GITHUB_WORKSPACE/.github/workflows/scripts/common/lint_package_json_files" "${{ steps.changed-files.outputs.files }}"
 
-      # Validate package.json metadata:
-      - name: 'Validate package.json metadata'
+      # Lint package.json metadata:
+      - name: 'Lint package.json metadata'
         if: success() || failure()
         run: |
-          make validate-pkg-json FILES="${{ steps.changed-files.outputs.files }}"
+          make lint-pkgs-metadata-files FILES="${{ steps.changed-files.outputs.files }}"
 
       # Lint REPL help files...
       - name: 'Lint REPL help files'

tools/git/hooks/pre-commit

@@ -254,10 +254,10 @@ run_lint() {
 	else
 		task_status 'skipped'
 	fi
-	add_task 'validate_package_json'
+	add_task 'lint_pkgs_metadata'
 	if [[ -z "${skip_package_json}" ]]; then
 		files=$(echo "${changed_files}" | tr '\n' ' ')
-		make FILES="${files}" validate-pkg-json > /dev/null >&2
+		make FILES="${files}" lint-pkgs-metadata-files > /dev/null >&2
 		if [[ "$?" -ne 0 ]]; then
 			task_status 'failed'
 			echo '' >&2

tools/make/lib/lint/package_json.mk

@@ -24,9 +24,6 @@ PACKAGE_JSON_LINTER ?= $(TOOLS_PKGS_DIR)/lint/pkg-json/bin/cli
 # Define the command-line options to be used when invoking the executable:
 PACKAGE_JSON_LINTER_FLAGS ?=
 
-# Define the path for script validating `package.json` metadata:
-VALIDATE_PKG_JSON ?= "${TOOLS_PKGS_DIR}/package-json/scripts/validate_package_json_files"
-
 
 # RULES #
 
@@ -41,17 +38,3 @@ lint-pkg-json: $(NODE_MODULES)
 	$(QUIET) NODE_PATH="$(NODE_PATH)" $(NODE) "$(PACKAGE_JSON_LINTER)" $(PACKAGE_JSON_LINTER_FLAGS) "$(ROOT_DIR)"
 
 .PHONY: lint-pkg-json
-
-#/
-# Validates `package.json` metadata associated with a list of files.
-#
-# @param {string} FILES - list of file paths
-#
-# @example
-# make validate-pkg-json FILES='/foo/lib/index.js /bar/package.json'
-#/
-validate-pkg-json: $(NODE_MODULES)
-	$(QUIET) echo 'Validating package.json metadata...'
-	$(QUIET) $(VALIDATE_PKG_JSON) $(FILES)
-
-.PHONY: validate-pkg-json

tools/make/lib/lint/pkgs/Makefile

@@ -16,6 +16,12 @@
 # limitations under the License.
 #/
 
+# VARIABLES #
+
+# Define the path for script validating `package.json` metadata:
+VALIDATE_PKG_JSON ?= "${TOOLS_PKGS_DIR}/package-json/scripts/validate_package_json_files"
+
+
 # RULES #
 
 # TODO: support linting filenames, package.json, REPL help, JavaScript CLI files (see pre-commit hook), license headers
@@ -44,3 +50,17 @@ lint-pkgs: lint-editorconfig
 	$(QUIET) $(MAKE) -f $(this_file) lint-typescript TYPESCRIPT_DECLARATIONS_FILTER=$(PACKAGES_FILTER) TYPESCRIPT_DECLARATIONS_TESTS_FILTER=$(PACKAGES_FILTER)
 
 .PHONY: lint-pkgs
+
+#/
+# Lints `package.json` metadata associated with a list of files.
+#
+# @param {string} FILES - list of file paths
+#
+# @example
+# make lint-pkgs-metadata-files FILES='/foo/lib/index.js /bar/package.json'
+#/
+lint-pkgs-metadata-files: $(NODE_MODULES)
+	$(QUIET) echo 'Linting package.json metadata...'
+	$(QUIET) $(VALIDATE_PKG_JSON) $(FILES)
+
+.PHONY: lint-pkgs-metadata-files