From c3a15633504e9f7a4c5039f151437068c4007763 Mon Sep 17 00:00:00 2001 From: Prajjwal Bajpai Date: Thu, 5 Feb 2026 18:34:59 +0530 Subject: [PATCH 1/2] bench: refactor to use string interpolation in `lapack/base/dlaset` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../@stdlib/lapack/base/dlaset/benchmark/benchmark.js | 3 ++- .../@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js index 3c14acbf5523..1188b15c475a 100644 --- a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js @@ -25,6 +25,7 @@ var uniform = require( '@stdlib/random/array/uniform' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); var floor = require( '@stdlib/math/base/special/floor' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var dlaset = require( './../lib/dlaset.js' ); @@ -106,7 +107,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( pkg+'::equidimensional:order='+ord+',size='+(N*N), f ); + bench( format( '%s::equidimensional:order=%s,size=%d', pkg, ord, (N*N) ), f ); } } } diff --git a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js index f5a91ba25e47..02236b175012 100644 --- a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js @@ -26,6 +26,7 @@ var isColumnMajor = require( '@stdlib/ndarray/base/assert/is-column-major-string var isnan = require( '@stdlib/math/base/assert/is-nan' ); var pow = require( '@stdlib/math/base/special/pow' ); var floor = require( '@stdlib/math/base/special/floor' ); +var format = require( '@stdlib/string/format' ); var pkg = require( './../package.json' ).name; var dlaset = require( './../lib/ndarray.js' ); @@ -116,7 +117,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( pkg+'::equidimensional:order='+ord+',size='+(N*N), f ); + bench( format( '%s::equidimensional:order=%s,size=%d', pkg, ord, (N*N) ), f ); } } } From 2dc170ac1a802f039ea425ed4c90985110ec5c24 Mon Sep 17 00:00:00 2001 From: Athan Date: Sun, 22 Feb 2026 17:49:07 -0800 Subject: [PATCH 2/2] Apply suggestions from code review Signed-off-by: Athan --- .../@stdlib/lapack/base/dlaset/benchmark/benchmark.js | 2 +- .../@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js index 1188b15c475a..936c1903380c 100644 --- a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js +++ b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.js @@ -107,7 +107,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( format( '%s::equidimensional:order=%s,size=%d', pkg, ord, (N*N) ), f ); + bench( format( '%s::equidimensional:order=%s,size=%d', pkg, ord, N*N ), f ); } } } diff --git a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js index 02236b175012..437328b6f3a2 100644 --- a/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js +++ b/lib/node_modules/@stdlib/lapack/base/dlaset/benchmark/benchmark.ndarray.js @@ -117,7 +117,7 @@ function main() { for ( i = min; i <= max; i++ ) { N = floor( pow( pow( 10, i ), 1.0/2.0 ) ); f = createBenchmark( ord, N ); - bench( format( '%s::equidimensional:order=%s,size=%d', pkg, ord, (N*N) ), f ); + bench( format( '%s::equidimensional:order=%s,size=%d', pkg, ord, N*N ), f ); } } }