From 79ffabc3478b99d1d12fe6d5a7b439134328df6f Mon Sep 17 00:00:00 2001 From: Prajjwal Bajpai Date: Fri, 17 Apr 2026 22:42:11 +0530 Subject: [PATCH] test: migrate `math/base/special/acos` to ULP-based testing --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- .../math/base/special/acos/test/test.js | 32 +++---------------- .../base/special/acos/test/test.native.js | 32 +++---------------- 2 files changed, 8 insertions(+), 56 deletions(-) diff --git a/lib/node_modules/@stdlib/math/base/special/acos/test/test.js b/lib/node_modules/@stdlib/math/base/special/acos/test/test.js index c10a101f65f2..4ed97114238e 100644 --- a/lib/node_modules/@stdlib/math/base/special/acos/test/test.js +++ b/lib/node_modules/@stdlib/math/base/special/acos/test/test.js @@ -23,7 +23,7 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var randu = require( '@stdlib/random/base/randu' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var EPS = require( '@stdlib/constants/float64/eps' ); var isPositiveZero = require( '@stdlib/assert/is-positive-zero' ); var acos = require( './../lib' ); @@ -46,8 +46,6 @@ tape( 'main export is a function', function test( t ) { tape( 'the function computes the arccosine', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -57,21 +55,13 @@ tape( 'the function computes the arccosine', function test( t ) { for ( i = 0; i < x.length; i++ ) { y = acos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the arccosine (small negative numbers)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -81,21 +71,13 @@ tape( 'the function computes the arccosine (small negative numbers)', function t for ( i = 0; i < x.length; i++ ) { y = acos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the arccosine (small positive numbers)', function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -105,13 +87,7 @@ tape( 'the function computes the arccosine (small positive numbers)', function t for ( i = 0; i < x.length; i++ ) { y = acos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); diff --git a/lib/node_modules/@stdlib/math/base/special/acos/test/test.native.js b/lib/node_modules/@stdlib/math/base/special/acos/test/test.native.js index 736e148989ac..9820fb2a5f6c 100644 --- a/lib/node_modules/@stdlib/math/base/special/acos/test/test.native.js +++ b/lib/node_modules/@stdlib/math/base/special/acos/test/test.native.js @@ -25,7 +25,7 @@ var tape = require( 'tape' ); var isnan = require( '@stdlib/math/base/assert/is-nan' ); var randu = require( '@stdlib/random/base/randu' ); var tryRequire = require( '@stdlib/utils/try-require' ); -var abs = require( '@stdlib/math/base/special/abs' ); +var isAlmostSameValue = require( '@stdlib/assert/is-almost-same-value' ); var EPS = require( '@stdlib/constants/float64/eps' ); var isPositiveZero = require( '@stdlib/assert/is-positive-zero' ); @@ -55,8 +55,6 @@ tape( 'main export is a function', opts, function test( t ) { tape( 'the function computes the arccosine', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -66,21 +64,13 @@ tape( 'the function computes the arccosine', opts, function test( t ) { for ( i = 0; i < x.length; i++ ) { y = acos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the arccosine (small negative numbers)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -90,21 +80,13 @@ tape( 'the function computes the arccosine (small negative numbers)', opts, func for ( i = 0; i < x.length; i++ ) { y = acos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); }); tape( 'the function computes the arccosine (small positive numbers)', opts, function test( t ) { var expected; - var delta; - var tol; var x; var y; var i; @@ -114,13 +96,7 @@ tape( 'the function computes the arccosine (small positive numbers)', opts, func for ( i = 0; i < x.length; i++ ) { y = acos( x[i] ); - if ( y === expected[ i ] ) { - t.strictEqual( y, expected[ i ], 'x: '+x[i]+'. E: '+expected[i] ); - } else { - delta = abs( y - expected[i] ); - tol = EPS * abs( expected[i] ); - t.ok( delta <= tol, 'within tolerance. x: '+x[i]+'. y: '+y+'. E: '+expected[i]+'. tol: '+tol+'. Δ: '+delta+'.' ); - } + t.strictEqual( isAlmostSameValue( y, expected[ i ], 1 ), true, 'returns expected value' ); } t.end(); });