fix(llama-index): prevent Cypher injection via backtick-escaped identifiers

- add _cypher_ident(): backtick-escapes labels, rel-types, property keys
- get(): lookup nodes by n.id (string) instead of get_node() (expects int)
- get(): escape property keys in WHERE clause
- get_triplets(): escape relation_names; raise NotImplementedError for properties/ids
- upsert_relations(): escape rel.label
- get_rel_map(): implement ignore_rels Python-side filter
- delete(): raise NotImplementedError for relation_names/properties

fix(client): parse host:port regardless of default port value

fix(build): portable sed -i.bak instead of macOS-only sed -i ''

fix(build): sync .PHONY — install-uv to install-pip

fix(release): remove unused outputs from release-please.yml

fix(release): remove trailing blank line in release.yml

feat(coordinode): import __version__ from hatch-vcs _version.py

test(integration): split compound assert for clearer failure messages

Author: polaz

.github/workflows/release-please.yml

@@ -12,9 +12,6 @@ permissions:
 jobs:
   release-please:
     runs-on: ubuntu-latest
-    outputs:
-      release_created: ${{ steps.rp.outputs.release_created }}
-      tag_name: ${{ steps.rp.outputs.tag_name }}
     steps:
       - uses: googleapis/release-please-action@v4
         id: rp

.github/workflows/release.yml

@@ -95,4 +95,3 @@ jobs:
           prerelease: ${{ contains(github.ref_name, 'a') || contains(github.ref_name, 'b') || contains(github.ref_name, 'rc') }}
           generate_release_notes: true
           files: dist/*
-

Makefile

@@ -1,4 +1,4 @@
-.PHONY: proto proto-check install install-uv test test-unit test-integration lint clean
+.PHONY: proto proto-check install install-pip test test-unit test-integration lint clean
 
 PROTO_SRC  := proto
 PROTO_OUT  := coordinode/_proto
@@ -16,8 +16,11 @@ proto:
 	@# Add __init__.py to every generated package directory
 	@find $(PROTO_OUT) -type d -exec touch {}/__init__.py \;
 	@# Fix absolute imports in all generated pb2 files (grpc_tools generates absolute paths)
-	@find $(PROTO_OUT) -name '*.py' -exec sed -i '' \
+	@# sed -i.bak is portable: macOS needs empty-string backup arg, GNU sed uses -i alone;
+	@# using .bak suffix works on both, then we clean up the backup files.
+	@find $(PROTO_OUT) -name '*.py' -exec sed -i.bak \
 		's/from coordinode\./from coordinode._proto.coordinode./g' {} \;
+	@find $(PROTO_OUT) -name '*.py.bak' -delete
 	@echo "==> Proto generation complete: $(PROTO_OUT)/"
 
 proto-check:

coordinode/__init__.py

@@ -26,7 +26,10 @@
     VectorResult,
 )
 
-__version__ = "0.3.0a1"
+try:
+    from coordinode._version import __version__
+except ImportError:
+    __version__ = "0.0.0"  # fallback for editable installs without hatch-vcs
 __all__ = [
     "CoordinodeClient",
     "AsyncCoordinodeClient",

coordinode/_types.py

@@ -35,6 +35,8 @@ def to_property_value(py_val: PyValue) -> Any:
         pv.bytes_value = py_val
     elif isinstance(py_val, list | tuple):
         # Homogeneous float list → Vector; mixed/str list → PropertyList
+        # isinstance() with X|Y union syntax is valid from Python 3.10+ (PEP 604).
+        # This package requires Python >=3.11, so no tuple-of-types workaround needed.
         if py_val and all(isinstance(v, int | float) for v in py_val):
             vec = Vector(values=[float(v) for v in py_val])
             pv.vector_value.CopyFrom(vec)

coordinode/client.py

@@ -102,9 +102,13 @@ def __init__(
         timeout: float = 30.0,
     ) -> None:
         # Support "host:port" as a single string (common gRPC convention).
-        if ":" in host and port == 7080:
+        # Parse whenever the last colon-delimited segment is numeric, regardless
+        # of default port. IPv6 bracket notation ([::1]:7080) is handled correctly
+        # by rsplit(":", 1): "[::1]" + "7080".
+        if ":" in host:
             _h, _p = host.rsplit(":", 1)
-            host, port = _h, int(_p)
+            if _p.isdigit():
+                host, port = _h, int(_p)
         self._host = host
         self._port = port
         self._tls = tls

llama-index-coordinode/llama_index/graph_stores/coordinode/base.py

@@ -15,6 +15,15 @@
 from llama_index.core.vector_stores.types import VectorStoreQuery
 
 
+def _cypher_ident(value: str) -> str:
+    """Backtick-escape a Cypher identifier (label, rel-type, property key).
+
+    Doubles any embedded backticks per the OpenCypher spec so that arbitrary
+    strings can be used safely as identifiers without Cypher injection.
+    """
+    return f"`{value.replace('`', '``')}`"
+
+
 class CoordinodePropertyGraphStore(PropertyGraphStore):
     """LlamaIndex ``PropertyGraphStore`` backed by CoordiNode.
 
@@ -60,17 +69,21 @@ def get(
         nodes: list[LabelledNode] = []
 
         if ids:
-            for node_id in ids:
-                result = self._client.get_node(node_id)
-                if result is not None:
-                    nodes.append(_node_result_to_labelled(node_id, result))
+            # Query by the stored n.id property (string adapter ID), not by the
+            # graph-internal integer node ID that get_node() expects.
+            cypher = "MATCH (n) WHERE n.id IN $ids RETURN n, n.id AS _nid LIMIT 1000"
+            result = self._client.cypher(cypher, params={"ids": ids})
+            for row in result:
+                node_data = row.get("n", {})
+                node_id = str(row.get("_nid", ""))
+                nodes.append(_node_result_to_labelled(node_id, node_data))
         elif properties:
-            where_clauses = " AND ".join(f"n.{k} = ${k}" for k in properties)
-            cypher = f"MATCH (n) WHERE {where_clauses} RETURN n, id(n) AS _id LIMIT 1000"
+            where_clauses = " AND ".join(f"n.{_cypher_ident(k)} = ${k}" for k in properties)
+            cypher = f"MATCH (n) WHERE {where_clauses} RETURN n, n.id AS _nid LIMIT 1000"
             result = self._client.cypher(cypher, params=properties)
             for row in result:
                 node_data = row.get("n", {})
-                node_id = str(row.get("_id", ""))
+                node_id = str(row.get("_nid", ""))
                 nodes.append(_node_result_to_labelled(node_id, node_data))
 
         return nodes
@@ -86,12 +99,14 @@ def get_triplets(
         conditions: list[str] = []
         params: dict[str, Any] = {}
 
+        if properties or ids:
+            raise NotImplementedError("get_triplets() does not yet support filtering by properties or ids")
         if entity_names:
             conditions.append("(n.name IN $entity_names OR m.name IN $entity_names)")
             params["entity_names"] = entity_names
         if relation_names:
-            rel_filter = "|".join(relation_names)
-            # Inline into pattern — CoordiNode supports dynamic type lists
+            # Escape each type name to prevent Cypher injection
+            rel_filter = "|".join(_cypher_ident(t) for t in relation_names)
             rel_pattern = f"[r:{rel_filter}]"
         else:
             rel_pattern = "[r]"
@@ -129,17 +144,16 @@ def get_rel_map(
         if not graph_nodes:
             return []
 
-        ids = [n.id for n in graph_nodes]
-        # ignore_rels: OpenCypher doesn't support dynamic type exclusion in patterns;
-        # would require WHERE NOT type(r) IN $ignore_rels — added when needed.
+        node_ids = [n.id for n in graph_nodes]
+        ignored = set(ignore_rels) if ignore_rels else set()
 
         cypher = (
             f"MATCH (n)-[r*1..{depth}]->(m) "
             f"WHERE id(n) IN $ids "
             f"RETURN n, r, m, id(n) AS _src_id, id(m) AS _dst_id "
             f"LIMIT {limit}"
         )
-        result = self._client.cypher(cypher, params={"ids": ids})
+        result = self._client.cypher(cypher, params={"ids": node_ids})
 
         triplets: list[list[LabelledNode]] = []
         for row in result:
@@ -149,6 +163,10 @@ def get_rel_map(
             dst_id = str(row.get("_dst_id", ""))
             # Variable-length path [r*1..N] returns a list of relationship dicts.
             rels = row.get("r", [])
+            # Skip paths that contain any ignored relationship type.
+            if ignored and isinstance(rels, list):
+                if any(isinstance(r, dict) and r.get("type") in ignored for r in rels):
+                    continue
             if isinstance(rels, list) and rels:
                 first_rel = rels[0]
                 rel_label = first_rel.get("type", "RELATED") if isinstance(first_rel, dict) else str(first_rel)
@@ -174,7 +192,8 @@ def upsert_relations(self, relations: list[Relation]) -> None:
         for rel in relations:
             props = rel.properties or {}
             cypher = (
-                f"MATCH (src {{id: $src_id}}), (dst {{id: $dst_id}}) MERGE (src)-[r:{rel.label}]->(dst) SET r += $props"
+                f"MATCH (src {{id: $src_id}}), (dst {{id: $dst_id}}) "
+                f"MERGE (src)-[r:{_cypher_ident(rel.label)}]->(dst) SET r += $props"
             )
             self._client.cypher(
                 cypher,
@@ -193,6 +212,8 @@ def delete(
         ids: list[str] | None = None,
     ) -> None:
         """Delete nodes and/or relations matching given criteria."""
+        if relation_names or properties:
+            raise NotImplementedError("delete() does not yet support filtering by relation_names or properties")
         if ids:
             cypher = "MATCH (n) WHERE id(n) IN $ids DETACH DELETE n"
             self._client.cypher(cypher, params={"ids": ids})

tests/integration/test_basic.py

@@ -49,7 +49,8 @@ def test_create_and_get_node(client):
         "MATCH (n:IntegrationTest {name: $name}) RETURN n.name AS name",
         params={"name": "sdk-test-node"},
     )
-    assert found and found[0]["name"] == "sdk-test-node"
+    assert found, "MATCH returned no rows"
+    assert found[0]["name"] == "sdk-test-node"
 
     # Clean up
     client.cypher(