Skip to content

Commit cc786bb

Browse files
committed
fix(types,client): use tuple syntax in isinstance, remove no-op proto import
- _types.py: replace isinstance(v, int | float) and isinstance(py_val, list | tuple) with tuple-of-types form (int, float) and (list, tuple); identical semantics on all Python versions, eliminates repeated Copilot false-positive lint hits - client.py: remove no-op 'from coordinode._proto import __init__ as _setup_path' (_proto/__init__.py has no sys.path side effects; import served no purpose)
1 parent a704de5 commit cc786bb

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

coordinode/_types.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,11 @@ def to_property_value(py_val: PyValue) -> Any:
3333
pv.string_value = py_val
3434
elif isinstance(py_val, bytes):
3535
pv.bytes_value = py_val
36-
elif isinstance(py_val, list | tuple):
37-
# Homogeneous float list → Vector; mixed/str list → PropertyList
38-
# isinstance() with X|Y union syntax is valid from Python 3.10+ (PEP 604).
39-
# This package requires Python >=3.11, so no tuple-of-types workaround needed.
36+
elif isinstance(py_val, (list, tuple)):
37+
# Homogeneous float list → Vector; mixed/str list → PropertyList.
4038
# bool is a subclass of int, so exclude it explicitly — [True, False] must
4139
# not be serialised as a Vector of 1.0/0.0 but as a PropertyList.
42-
if py_val and all(isinstance(v, int | float) and not isinstance(v, bool) for v in py_val):
40+
if py_val and all(isinstance(v, (int, float)) and not isinstance(v, bool) for v in py_val):
4341
vec = Vector(values=[float(v) for v in py_val])
4442
pv.vector_value.CopyFrom(vec)
4543
else:

coordinode/client.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
import grpc
1414
import grpc.aio
1515

16-
from coordinode._proto import __init__ as _setup_path # noqa: F401 — path fix
1716
from coordinode._types import (
1817
PyValue,
1918
dict_to_props,

0 commit comments

Comments
 (0)